Commit Graph

28 Commits

Author SHA1 Message Date
Dean Herbert 1b9acdf55c
Abstract out common implementation of `BeatSnapGrid` 2023-10-17 16:42:52 +09:00
Dean Herbert 1a60d6ade5
Use a `DrawablePool` for mania's beat snap grid
I'm not sure what the cause of the issue is, but I'm also not sure why
it wasn't using `DrawablePool` (was it not around back then?).

Either way, switching to a proper pool fixes things just fine.

Resolves https://github.com/ppy/osu/issues/25009.
2023-10-10 13:36:31 +09:00
Dean Herbert 0ab0c52ad5 Automated pass 2023-06-24 01:00:03 +09:00
Dean Herbert 6d446d3e97 Fix incorrect colouring of beat snap grids (mania and catch) 2023-06-07 12:25:34 +09:00
Dan Balasescu 7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
Dan Balasescu f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Dean Herbert 1eed2436e6 Clean up unused resolved properties 2021-12-03 18:49:49 +09:00
ekrctb d262956146 Always use LifetimeEntry to manage hit objects in HitObjectContainer
Previously, non-pooled DHOs were immediately added as children of the HOC when Add is called. Also, non-pooled DHOs were always attached to the HOC as children.
New behavior is that non-pooled DHOs are only added after CheckChildLifetime, and only attached to the HOC while the DHOs are alive.

- LifetimeManagementContainer inheritance of HOC is removed, as it is now all DHOs are "unmanaged" (previously `AddInternal(false)`).
- The signature of `Clear` is changed, and it is now always not disposing the children immediately.
2021-04-29 14:38:01 +09:00
Dean Herbert a3dc1d5730 Update existing implementations 2020-11-04 17:14:23 +09:00
Dean Herbert 6be5917eb0 Remove necessity for custom mania interface caching 2020-05-27 23:15:16 +09:00
Dean Herbert ce35d09e7d Fix incorrect alpha application to lines on rewinding 2020-05-22 12:45:37 +09:00
Dean Herbert d529a2aefa Remove left-over function 2020-05-22 12:28:01 +09:00
Dean Herbert 0bc3073d49 Fix test failures 2020-05-20 15:01:32 +09:00
Dean Herbert d31a59b074 Fix logic results in infinite loop on default timing point return 2020-05-20 14:55:36 +09:00
Dean Herbert 85156c62ef Add xmldoc and address some code quality concerns 2020-05-19 23:05:08 +09:00
Dean Herbert c28a9bdb80 Move load method up 2020-05-19 23:02:20 +09:00
Dean Herbert a6f3dc53f7 Fix time value not being updated for next timing point 2020-05-19 23:01:36 +09:00
Dean Herbert d56466e2b9 Add very basic pooling of grid lines 2020-05-19 19:07:35 +09:00
Dean Herbert 406f39e8bf Construct online visible lines 2020-05-18 21:27:26 +09:00
Dean Herbert b35b150f38 Simplify colouring logic 2020-05-18 19:48:51 +09:00
Dean Herbert 16e85ae0b1 Remove Grid class 2020-05-18 17:52:04 +09:00
Dean Herbert d9bb90078b Move grids to inside columns 2020-05-18 17:47:52 +09:00
smoogipoo 238d87f976 Add comment about gray usage 2020-05-15 15:56:32 +09:00
smoogipoo 1c6c128d11 Add const 2020-05-15 15:51:54 +09:00
smoogipoo 392d44e1fb Always fully display one beat 2020-05-15 15:49:50 +09:00
smoogipoo 0e33494074 Fix flashing when changing beat divisor 2020-05-14 19:58:39 +09:00
smoogipoo 42c3d892cd Only update alive lines 2020-05-14 19:55:14 +09:00
smoogipoo 16585f767e Add initial beat snap grid implementation 2020-05-14 19:17:24 +09:00