RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-01-02 12:22:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add very basic pooling of grid lines

Browse Source
This commit is contained in:
Dean Herbert 2020-05-19 19:07:35 +09:00
parent 406f39e8bf
commit d56466e2b9
1 changed files with 20 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
osu.Game.Rulesets.Mania/Edit/ManiaBeatSnapGrid.cs
View File

@ -90,10 +90,17 @@ namespace osu.Game.Rulesets.Mania.Edit
beatDivisor.BindValueChanged(_ => createLines(), true);
}
private readonly Stack<DrawableGridLine> availableLines = new Stack<DrawableGridLine>();
private void createLines()
{
foreach (var grid in grids)
grid.Clear();
{
foreach (var line in grid.Objects.OfType<DrawableGridLine>())
availableLines.Push(line);
grid.Clear(false);
}
if (selectionTimeRange == null)
return;
@ -127,7 +134,15 @@ namespace osu.Game.Rulesets.Mania.Edit
BindableBeatDivisor.GetDivisorForBeatIndex(Math.Max(1, beat), beatDivisor.Value), colours);
foreach (var grid in grids)
grid.Add(new DrawableGridLine(time, colour));
{
if (!availableLines.TryPop(out var line))
line = new DrawableGridLine();
line.HitObject.StartTime = time;
line.Colour = colour;
grid.Add(line);
}
beat++;
time += timingPoint.BeatLength / beatDivisor.Value;
@ -190,17 +205,13 @@ namespace osu.Game.Rulesets.Mania.Edit
private readonly IBindable<ScrollingDirection> direction = new Bindable<ScrollingDirection>();
public DrawableGridLine(double startTime, Color4 colour)
: base(new HitObject { StartTime = startTime })
public DrawableGridLine()
: base(new HitObject())
{
RelativeSizeAxes = Axes.X;
Height = 2;
AddInternal(new Box
{
RelativeSizeAxes = Axes.Both,
Colour = colour
});
AddInternal(new Box { RelativeSizeAxes = Axes.Both });
}
[BackgroundDependencyLoader]