Commit Graph

1486 Commits

Author SHA1 Message Date
Dean Herbert 5c0494f3ba Remove unnecessary precondition check and disallow vertical catch flips for now 2022-01-06 14:39:29 +09:00
Dean Herbert 6779503e57 Refactor logic to avoid `TimelineSelectionHandler` having to block base calls 2022-01-05 16:56:54 +09:00
Dean Herbert 866ae3472b Add global flip hotkeys 2022-01-05 16:48:07 +09:00
Joseph Madamba 0bd928b5cd Fix incorrect naming / apply review 2021-12-27 21:44:19 -08:00
Joseph Madamba 98524d60a4 Fix clear identifier typos 2021-12-27 20:26:28 -08:00
StanR 40b3ce0ade Clean up comments 2021-12-21 14:03:24 +03:00
StanR cca02a8016 Create PerformanceAttributes 2021-12-21 13:08:31 +03:00
StanR 2f2006715e Slightly refactor difficulty and pp calculators 2021-12-17 23:40:23 +03:00
Dan Balasescu 8a81392d2b Fix use of incorrect variable, add test 2021-12-16 19:26:36 +09:00
Dan Balasescu 5ea081e899 Test hyperdash generation in catch conversion tests 2021-12-16 19:04:42 +09:00
Dean Herbert 9f688f6291 Stop persisting `Skill`s in `DifficultyAttributes` 2021-11-21 12:15:32 +09:00
Dan Balasescu 33294ffda6
Merge branch 'master' into fix-plate-clearing-missing-last-banana 2021-11-19 11:42:57 +09:00
Darius Wattimena 38edeac710 Moved the logic to the bottom as placeCaughtObject is otherwise not called yet 2021-11-18 20:24:40 +01:00
Darius Wattimena 95891bc655 Moved clear plate logic to Catcher class 2021-11-18 20:03:41 +01:00
Dean Herbert fd0cae2bfb
Merge branch 'master' into difficulty-attribute-helpers 2021-11-17 20:49:31 +09:00
Dan Balasescu 815179f713 Use consts for attribute IDs 2021-11-17 20:31:18 +09:00
Dean Herbert 369b4ba789 Update `DifficultyCalculator` to take an `IRulesetInfo` 2021-11-15 19:16:48 +09:00
Dean Herbert 62d670a3ca Update `DifficultyCalculator` to take an `IWorkingBeatmap` 2021-11-15 19:16:48 +09:00
Dan Balasescu c8a01c35f7 Remove extra members from FromDatabaseAttributes 2021-11-15 18:11:07 +09:00
Dan Balasescu 0cfd6fdf04 Add to/from database mapping functions to difficulty attributes 2021-11-15 16:06:50 +09:00
Dan Balasescu 907499f73a Add json properties to difficulty attributes 2021-11-15 16:06:29 +09:00
Darius Wattimena 2c4f1817d3 Fixed an issue where banana showers don't clear the plate when missing the last banana 2021-11-14 20:43:31 +01:00
ekrctb dca2cd6c44
Merge branch 'master' into catch-spinner-checks 2021-11-11 11:32:58 +09:00
Darius Wattimena d370f64ac3 Changed finding the spinner gaps via a dictionary instead of getting the thresholds via an array 2021-11-10 19:58:36 +01:00
ekrctb 116b857cea
Merge branch 'master' into no-scope-catch 2021-11-10 20:50:31 +09:00
Bartłomiej Dach 6d04823b05
Remove unnecessary `virtual` specs 2021-11-10 12:00:36 +01:00
Semyon Rozhkov 577bdade5b Hide catcher during banana shower 2021-11-10 04:10:05 +03:00
Semyon Rozhkov 41f4f0ab5e Different setting slider description in each mod 2021-11-10 03:57:22 +03:00
Semyon Rozhkov ce0eb0b26f Using IUpdatableByPlayfield 2021-11-10 03:53:30 +03:00
Darius Wattimena bd5caceeb1 Fixed typo in banana shower gap check message 2021-11-10 00:23:14 +01:00
Darius Wattimena 5d8f35f3c9 Code cleanup and added tests for the spinner check 2021-11-10 00:16:29 +01:00
Darius Wattimena fbfed16756 Started on implementing a spinner gap check for catch 2021-11-09 23:05:25 +01:00
Semyon Rozhkov 64bc8da14c Add "No Scope" mod implementation for Catch 2021-11-09 17:11:19 +03:00
Dean Herbert 0ecf5f201c Rename `User` to `APIUser` and move to correct namespace 2021-11-07 11:26:01 +09:00
Dean Herbert 9b705460db Remove trailing exclamation marks from autoplay character names
As mentioned in
https://github.com/ppy/osu/discussions/15401#discussioncomment-1573839.
2021-11-02 14:53:58 +09:00
Dean Herbert 5c7623e68e
Merge pull request #15255 from goodtrailer/node-samples-ilist
Change IHasRepeats.NodeSamples to IList from List
2021-10-28 14:24:26 +09:00
Dean Herbert add39fbd4f Merge branch 'master' into fix-skin-layout-editor-crash 2021-10-28 06:24:24 +09:00
Dan Balasescu cab254dc81
Merge branch 'master' into var-inspections-update 2021-10-27 14:02:49 +09:00
Dean Herbert 6944151486 Apply batch fixing of built-in types using `var` 2021-10-27 13:04:41 +09:00
ekrctb 393d118eef Fix compilation failure overlooked in merge 2021-10-26 20:20:43 +09:00
ekrctb e5050b90a5 Don't assume catcher dash speed is 2x the walk speed 2021-10-26 20:09:48 +09:00
ekrctb de7a908be2 Cut distance snap lines at playfield border in catch editor 2021-10-26 14:51:52 +09:00
ekrctb c5d765029c Don't compute source object for distance snap grid when it is not enabled 2021-10-26 11:17:04 +09:00
ekrctb b7a719de71 Rename method 2021-10-26 11:14:12 +09:00
ekrctb 068217557e Add doc comment on catch distance snap grid 2021-10-26 11:12:10 +09:00
ekrctb 9f49a1df8b Handle the case of cursor below the start time of distance snap 2021-10-26 11:00:55 +09:00
ekrctb 865be5a10b Fix distance snap grid rendering inverted when out of bounds 2021-10-26 11:00:44 +09:00
ekrctb 2c92f1a0b7 Use array for fixed-size list 2021-10-26 10:41:17 +09:00
ekrctb 6d1cd0a3a1 Add distance snapping to catch editor 2021-10-25 16:37:44 +09:00
ekrctb 60df0151c0 Add very basic distance snap grid for catch editor 2021-10-25 15:25:59 +09:00