Commit Graph

29622 Commits

Author SHA1 Message Date
Dean Herbert 416ee2447a Move archive filename helper method to extension method 2021-11-25 16:35:54 +09:00
Dean Herbert a0fa030f55 Rename base class to `LegacyModelImporter` 2021-11-25 16:33:04 +09:00
Dean Herbert 2df793ca22 Inline individual importers to avoid unnecessary construction for singular import types 2021-11-25 15:44:04 +09:00
Dean Herbert 9dcb20a821 Rename `Stable` to `Legacy` and add xmldoc 2021-11-25 15:39:05 +09:00
Dean Herbert 6cab7b877d Move stable import handling into its own class 2021-11-25 15:36:58 +09:00
Dean Herbert 2bfc473689 Split out `SkinModelManager` from `SkinManager` 2021-11-25 15:14:43 +09:00
Dean Herbert 1533e245de
Merge pull request #15767 from bdach/beatmap-card/track-preview
Add preview track playback function to beatmap card
2021-11-25 12:08:03 +09:00
Bartłomiej Dach 20f71da2c4
Merge branch 'master' into fix-mp-resuming 2021-11-24 20:17:58 +01:00
Dan Balasescu 1865227e08
Merge pull request #15773 from peppy/remove-model-file-list-inits
Initialise `IHasFiles<TFile>.Files` lists at construction time
2021-11-24 21:05:36 +09:00
Dan Balasescu 016684b52d Remove unreachable code 2021-11-24 20:29:47 +09:00
Dan Balasescu 132bb59203 Update working beatmap when returning to match 2021-11-24 19:56:02 +09:00
Dan Balasescu ce8500a732
Merge branch 'master' into remove-model-file-list-inits 2021-11-24 19:46:42 +09:00
Dean Herbert b739b6a725
Merge branch 'master' into beatmap-card/track-preview 2021-11-24 18:54:25 +09:00
Dean Herbert 61009013cc Give a more correct default value to beatmap and set statuses 2021-11-24 18:48:12 +09:00
Dean Herbert 052ed8f930 Add online status to `RealmBeatmapSet` 2021-11-24 18:48:02 +09:00
Dean Herbert 183b95cbc2 Rename `BeatmapSetOnlineStatus` to `BeatmapOnlineStatus`
This variable is used at more than just a set level.
2021-11-24 18:42:49 +09:00
Dean Herbert ddbd4f9473 Merge branch 'master' into remove-model-file-list-inits 2021-11-24 18:39:01 +09:00
Dan Balasescu 5ff62a8e04
Merge pull request #15779 from peppy/remaining-misc-fixes
Apply some various code quality fixes that don't fit elsewhere
2021-11-24 16:59:49 +09:00
Dan Balasescu 74b6c33fab
Merge pull request #15778 from peppy/ruleset-info-id-usage
Update usages of `RulesetInfo.ID` to use `OnlineID` instead
2021-11-24 16:55:28 +09:00
Dan Balasescu 834bdd8e5c
Merge pull request #15776 from peppy/non-null-beatmapset-metadata
Make `BeatmapSet.Metadata` non-null
2021-11-24 16:48:28 +09:00
Dan Balasescu 8ce5324c8b
Merge pull request #15772 from peppy/remove-model-list-inits
Initialise `BeatmapSet.Beatmaps` list at construction time
2021-11-24 16:41:19 +09:00
Dean Herbert 2dabedebff Remove unnecessary user assign in `HitObjectSampleTest` 2021-11-24 16:30:00 +09:00
Dean Herbert 3e0e01abdb Move bookmark parsing logic into `LegacyBeatmapDecoder` 2021-11-24 16:29:51 +09:00
Dean Herbert 9c61ec217b Remove unnecessary `mainTrackMixer` parameter from `BeatmapManager` 2021-11-24 16:27:17 +09:00
Dan Balasescu 2ec3fb2e9e
Merge pull request #15760 from peppy/realm-move-data-migration-to-context-factory
Move realm data migrations inside the `RealmContextFactory`
2021-11-24 16:23:56 +09:00
Dean Herbert bbd3ea5b77 Update all actual usages of `RulesetInfo.ID` to use `OnlineID` instead 2021-11-24 15:50:26 +09:00
Dean Herbert f283770f34 Update mock `RulesetInfo` usage to set `OnlineID` instead of `ID` 2021-11-24 15:50:26 +09:00
Dean Herbert e57c343531 Add helper setter to EF `RulesetInfo.OnlineID` to allow updating usages 2021-11-24 15:50:26 +09:00
Dan Balasescu 33d95fbb9c
Merge pull request #15771 from peppy/ruleset-config-cache-shortname
Update `RulesetConfigCache` to cache via `ShortName` instead of `ID`
2021-11-24 15:24:57 +09:00
Dan Balasescu 73e50af9cc
Merge pull request #15775 from peppy/update-framework
Update framework
2021-11-24 15:24:43 +09:00
Dean Herbert cb093e1e01 Remove reundant self-sets of metadata 2021-11-24 15:08:04 +09:00
Dean Herbert 3946a39b65 Make `BeatmapSet.Metadata` non-null 2021-11-24 15:03:34 +09:00
Dan Balasescu c4b5a07f4b
Merge branch 'master' into realm-move-data-migration-to-context-factory 2021-11-24 14:40:26 +09:00
Dean Herbert a7853fc9cc Fix cases of known-non-null 2021-11-24 14:26:25 +09:00
Dean Herbert ec89dfa043 Update framework 2021-11-24 14:09:25 +09:00
Dean Herbert 0aedbbe165 Fix incorrect fallback logic causing test failure 2021-11-24 14:04:55 +09:00
Dean Herbert c2f8d9f677 Update tests which set `Files` lists directly 2021-11-24 14:00:14 +09:00
Dean Herbert 99a139dc98 Initialise all file lists at construction time (and remove setter) 2021-11-24 13:56:21 +09:00
Dan Balasescu 5a0a95f9d4 Trim whitespace 2021-11-24 13:48:59 +09:00
Dan Balasescu 84268c3d85 Merge branch 'master' into realm-ruleset-keybinding-short-name 2021-11-24 13:48:48 +09:00
Dan Balasescu 6183d1cd46
Merge pull request #15769 from peppy/model-equality-consistency
Update cases where equality can be used instead of primary key equality
2021-11-24 13:45:57 +09:00
Dan Balasescu 6ffba8a546
Merge pull request #15768 from peppy/standardise-ruleset-create-instance
Remove nullability of `Ruleset.CreateInstance`
2021-11-24 13:43:23 +09:00
Dean Herbert a3fdab34d5 Avoid json serialisation of aggregate helper properties
Also avoids `throw`ing when there are no beatmaps available. Until now
this wasn't an issue due to the `Beatmaps` list being null instead of empty.
2021-11-24 13:36:34 +09:00
Dean Herbert 8c60f37508 Fix cases of dynamically assigning `Beatmap`s to `BeatmapSetInfo` using list assignment 2021-11-24 13:27:37 +09:00
Dean Herbert 49c2cb9125 Initialise `BeatmapSet.Beatmaps` list to line up with realm expectations 2021-11-24 13:25:55 +09:00
Dean Herbert ee22c24370 Update `RulesetConfigCache` to cache via `ShortName` instead of `ID` 2021-11-24 13:10:18 +09:00
Dean Herbert 729f681938 Update cases where equality can be used instead of primary key equality 2021-11-24 12:49:57 +09:00
Dean Herbert 6aed41eacc
Merge branch 'master' into realm-move-data-migration-to-context-factory 2021-11-24 12:38:44 +09:00
Dean Herbert 63b09b356f Rewrite commments to read better 2021-11-24 12:37:09 +09:00
Dean Herbert 6cd1bfd94f Remove outdated comment 2021-11-24 12:35:05 +09:00