Bartłomiej Dach
3f63fd7f4d
Reorder increment to make progress update less weird
2023-05-06 19:39:52 +02:00
Bartłomiej Dach
bb17b684b0
Rename flag
2023-05-06 19:38:41 +02:00
Bartłomiej Dach
a56a5d563c
Unify error message wording
2023-05-06 19:38:05 +02:00
Bartłomiej Dach
3afe198d1d
Remove weird single-use private method
2023-05-06 19:34:22 +02:00
Bartłomiej Dach
e0823ffd03
Move lower and xmldoc GetFilename(TModel)
2023-05-06 19:29:08 +02:00
Bartłomiej Dach
5e64d25b2a
Make UserFileStorage readonly again
2023-05-06 19:26:51 +02:00
Dean Herbert
64d7e0d896
Rename outputStream variable to match base class
2023-05-07 00:24:30 +09:00
Dean Herbert
d2591368a6
More xmldoc fixes
2023-05-06 23:53:35 +09:00
Dean Herbert
0d095c4bb7
Remove non-Live pathway
2023-05-06 23:10:18 +09:00
Dean Herbert
e75ff33d62
Remove redundant xmldoc and reword some remaining
2023-05-06 23:10:09 +09:00
cdwcgt
71864fbb93
remove meanless comment
2023-05-05 21:29:06 +09:00
cdwcgt
4393e53b43
ExportToStream should be public
2023-05-05 21:28:43 +09:00
Dean Herbert
747f912af5
Fix incorrect cancellation logic
2023-05-05 21:08:01 +09:00
Dean Herbert
5d78561aa3
Remove weird catch logic
2023-05-05 21:05:57 +09:00
Dean Herbert
2a3e03695c
Simplify ExportAsync, remove weird dedupe logic and unnecessary return success code
2023-05-05 21:05:52 +09:00
Dean Herbert
4ccfebc02b
Simplify ExportToStreamAsync implementation
2023-05-05 21:01:10 +09:00
Dean Herbert
fc2d2de34c
Fix notification text not including export filename
2023-05-05 16:53:27 +09:00
Dean Herbert
9cafb20fcb
Move file missing logging to a better location, and log actual filenames to logs
2023-05-05 16:53:16 +09:00
Dean Herbert
4ec98b0578
Improve xmldoc and fix silly progress text in LegacyArchiveExporter
2023-05-05 16:45:45 +09:00
Dean Herbert
f2dd457b3d
Remove unnecessary local variable
2023-05-05 16:31:48 +09:00
Dean Herbert
6a4933a31c
Remove need for TestRealmLive nonsense
2023-05-05 16:30:43 +09:00
Dean Herbert
0158102467
Rename class back to original name so I can read the diff
2023-05-05 16:19:10 +09:00
cdwcgt
4549a865d9
Merge branch 'master' into export
2023-05-04 00:18:01 +09:00
Bartłomiej Dach
0ba31c5709
Merge pull request #23388 from peppy/fix-song-select-drawable-carousel-beatmap-leak
...
Fix runaway memory usage at song select when opening many beatmaps many times
2023-05-03 14:32:13 +02:00
Dean Herbert
444f66b0ee
Move to base class for added safety
2023-05-03 18:46:30 +09:00
Dean Herbert
cd31cff8cd
Fix event subscriptions not being cleaned up in DrawableCarouselBeatmap
...
The handling of cleanup is performed only the `Item_Set` method. This
was already correctly called for `DrawableCarouselBeatmapSet`, but not
for the class in question here.
This would cause runaway memory usage at song select when opening many
beatmaps to show their difficulties. For simplicity, we don't yet pool
these (and generate the drawables each time a set is opened) which isn't
great but likely will be improved upon when we update the visual /
filtering of the carousel. But this simplicity caused the memory usage
to blow out until exiting back to the main menu when cleanup would
finally occur.
2023-05-03 18:41:30 +09:00
Bartłomiej Dach
88135a3be8
Merge pull request #23384 from peppy/fix-incorrect-transform-thread
...
Fix potentially incorrect thread access in `OsuTabControlCheckbox`
2023-05-03 10:37:27 +02:00
Dean Herbert
ff28d941b3
Merge pull request #23385 from Joehuu/scroll-back-button-block-hover
...
Fix overlay scroll back button not absorbing hover from behind
2023-05-03 16:28:05 +09:00
Bartłomiej Dach
de1b28bcb2
Fix incorrect initial state of checkbox
...
This only ever barely used to work without the `(..., true)`
in `master` because of haphazard operation ordering.
2023-05-03 09:27:23 +02:00
Bartłomiej Dach
5f781bd6de
Move callback to LoadComplete()
...
Is the more correct place for `BindValueChanged()` callbacks.
2023-05-03 09:26:54 +02:00
Bartłomiej Dach
29a943d514
Merge pull request #23383 from peppy/fix-multi-freemod-overlays-test-failure
...
Fix test failure in `MultiplayerMatchSongSelect` due to multiple overlays present
2023-05-03 09:09:41 +02:00
Bartłomiej Dach
2add8e119f
Merge pull request #23379 from peppy/legacy-skin-reverse-arrow-colour-flip
...
Add support for flipping colour of reverse arrow on legacy default skin when combo colour is too bright
2023-05-03 08:48:32 +02:00
Joseph Madamba
1c74f6e8ea
Fix regressed button hover fade in
2023-05-02 22:54:42 -07:00
Joseph Madamba
bede1292de
Fix overlay scroll back button not absorbing hover from behind
2023-05-02 22:40:37 -07:00
Dean Herbert
a3efae3690
Fix potentially incorrect thread access in OsuTabControlCheckbox
...
https://github.com/ppy/osu/actions/runs/4868337922/jobs/8681736829 .
2023-05-03 14:33:32 +09:00
Dean Herbert
384693a431
Fix test failure in MultiplayerMatchSongSelect due to multiple overlays present
...
https://github.com/ppy/osu/actions/runs/4868337922/jobs/8681736995?pr=23308 .
2023-05-03 14:30:58 +09:00
Dean Herbert
6b017ac05f
Merge pull request #23308 from OliBomby/sample-control-points
...
Remove SampleControlPoint and DifficultyControlPoint from HitObject
2023-05-03 14:21:51 +09:00
Dean Herbert
f930c4bd0a
Move struct to bottom of file
2023-05-03 13:33:31 +09:00
Dean Herbert
48fd99818e
Split out default and sample application
2023-05-03 13:30:45 +09:00
Dean Herbert
cca15f930c
Refactor applyLegacyInfoAndDefaults for legibility
2023-05-03 13:26:50 +09:00
Dean Herbert
588a4e6196
Move pragma disable to top of LegacyBeatmapDecoder
...
Makes more sense as it's used multiple times in the class.
2023-05-03 13:19:14 +09:00
Dean Herbert
16c624fb61
Ensure static banana samples are not mutated
2023-05-03 13:02:37 +09:00
Dean Herbert
9c4312b407
Add support for flipping colour of reverse arrow on legacy default skin when combo colour is too bright
2023-05-03 12:37:07 +09:00
Dean Herbert
e42b0cc5b1
Merge pull request #23370 from peppy/fix-editor-playfield-padding
...
Add more padding around playfield in editor to avoid overlap with tool areas
2023-05-03 11:44:55 +09:00
Bartłomiej Dach
03459a4f19
Merge pull request #23371 from peppy/argon-slider-ball-fade-faster
...
Increase the rate of slider ball fade on argon skins to match other implementations
2023-05-02 19:03:47 +02:00
Bartłomiej Dach
95badb9455
Adjust composer tests to new screen layout
...
`TestSceneHitObjectComposer.TestPlacementFailsWhenClickingButton()` was
attempting to cover the case of the user clicking a toolbox button which
was in front of the playfield, and ensure that the click did not result
in a placement. However, since the paddings in
67f83f246b1c65c62416a24375ef580139d046dc were added, it is impossible
for a toolbox button to be in front of the playfield in the collapsed
state, which the test was relying on.
The test scenario is still however relevant in the case of the toolbox
being expanded, as in that state the toolbux buttons may very well end
up being in front of the playfield, and they still should not result in
a hitobject being placed. To ensure that this is the case, add a few
extra test steps ensuring that the toolbox is expanded first before
trying to retrieve an overlapping button.
2023-05-02 18:45:45 +02:00
Bartłomiej Dach
ec8362c6fc
Merge pull request #23367 from peppy/fix-uo-tooltip
...
Fix slider bar tooltips potentially showing negative zero
2023-05-02 18:03:09 +02:00
Bartłomiej Dach
48dd42407b
Merge pull request #23369 from peppy/beatmap-attribute-text-unicode-preference
...
Fix `BeatmapAttributeText` not supporting unicode artist/title
2023-05-02 17:32:55 +02:00
Dean Herbert
94ae9d7664
Merge pull request #23357 from OliBomby/fix-reverse-crash
...
Prevent infinite repeat count when adjusting repeats of 0 length slider
2023-05-02 19:53:26 +09:00
Dean Herbert
1b565ab9e8
Merge pull request #21789 from mk56-spn/bubble_mod_implementation_clean
...
Add "bubble" mod to osu! ruleset
2023-05-02 19:52:32 +09:00
