RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
42,379 Commits 3 Branches 658 Tags 358 MiB
Commit Graph

41 Commits

Author SHA1 Message Date
Dean Herbert cd4885e450 Add xmldoc and remove any question of how the intitial flow is being run 2021-07-06 17:18:45 +09:00
Dean Herbert 935fbe7cc6 Remove double fetch/binding of parent source 2021-07-06 16:51:29 +09:00
Dean Herbert 93ef783339 Remove BindableList usage 2021-07-06 16:40:23 +09:00
Salman Ahmed 66fc95c111 Use `LastOrDefault` instead 2021-06-28 12:43:58 +03:00
Salman Ahmed 7197998a10 Remove resolution to `SkinManager` and use pattern matching instead 2021-06-28 12:43:13 +03:00
Salman Ahmed 177bfe1234 Merge branch 'master' into ruleset-resources-skin 2021-06-28 11:16:37 +03:00
Salman Ahmed 779a1b322c
Add comment explaining insertion of ruleset skin before default skin 
Co-authored-by: Dean Herbert <pe@ppy.sh>
 2021-06-28 09:38:42 +03:00
Salman Ahmed f598de4cdb ResourcesSkin -> ResourceStoreBackedSkin 2021-06-28 09:18:29 +03:00
Salman Ahmed 692f24437e Maintain ruleset resources skin across multiple source changes 2021-06-28 09:11:28 +03:00
Dean Herbert f777741ca7 Simplify instantiation 2021-06-28 14:51:27 +09:00
Dean Herbert e387feb1d6 Add inline comment mentioning why `CreateChildDependencies` is being used in this instance 2021-06-28 14:39:55 +09:00
Salman Ahmed e8e9fdd533 Dispose `ResourcesSkin` before clearing skin sources 2021-06-26 12:34:30 +03:00
Salman Ahmed f07008a0a2 Fix `RulesetSkinProvidingContainer` potentially late in setting up skin sources 2021-06-25 10:05:51 +03:00
Salman Ahmed a98b5618b8 Convert `RulesetResourcesSkin` to plain `ResourcesSkin` and pass non-null resources 2021-06-24 10:07:38 +03:00
Salman Ahmed d484469906 Handle case where `SkinManager` sources aren't part of `AllSources` 
In tests.
 2021-06-23 10:44:23 +03:00
Salman Ahmed 53fa229880 Add ruleset resources skin before `SkinManager.DefaultSkin` 2021-06-23 10:09:25 +03:00
Salman Ahmed ee84364d7c Resolve conflict issues 2021-06-22 20:38:24 +03:00
Salman Ahmed 896c1dc202 Merge branch 'master' into ruleset-resources-skin 2021-06-22 20:36:49 +03:00
Salman Ahmed 71e2815e7e
Update and improve code documentation 
Co-authored-by: Dean Herbert <pe@ppy.sh>
 2021-06-22 12:05:17 +03:00
Dean Herbert 14bdcef26b Add missing newline 2021-06-22 16:20:09 +09:00
Dean Herbert 0ad189e357 Expose skin sources via `ISkinSource` and revert to consuming based on hierarchy 2021-06-22 16:19:55 +09:00
Salman Ahmed ec040ff3fc Fix leak due to not properly unbinding `SourceChanged` event on disposal 2021-06-22 05:05:41 +03:00
Salman Ahmed caa90bccc6 Fix default skin potentially added twice in `RulesetSkinProvidingContainer` 2021-06-22 03:45:43 +03:00
Salman Ahmed 627c857da8 Propagate `SourceChanged` events from `SkinManager` down in the ruleset skin container 2021-06-22 03:45:24 +03:00
Salman Ahmed 97dbc7f20e Add back `SkinManager.DefaultSkin` to the ruleset skin lookup sources 2021-06-22 02:54:34 +03:00
Salman Ahmed d53a43cf3c Isolate `RulesetSkinProvidingContainer` from falling back to parent skin sources 
For simplicity of lookup order, and which sources are used for the lookup.
 2021-06-22 02:53:22 +03:00
Salman Ahmed 5cfd0e3223 Remove implicit `LegacySkin` check and refactor anything using it 2021-06-21 04:16:58 +03:00
Salman Ahmed 780388d174 Fix incorrect return value 2021-06-17 03:48:29 +03:00
Salman Ahmed 74ad6f9117 Remove default skin from the ruleset skin sources 
That one doesn't need any changes to it, can be fetched from the `SkinManager` instead.
 2021-06-16 17:24:31 +03:00
Salman Ahmed 52ddf08532 Consider not adding legacy skin transformers to non-legacy skins 2021-06-16 17:24:16 +03:00
Salman Ahmed 5ebf570ec4 Revert `GetRulesetTransformedSkin` accessibility change 
This reverts commit 521077b714.

Forgot to do it when I made this `protected`, but subclasses in test scenes require this.
 2021-06-16 16:49:38 +03:00
Dean Herbert 521077b714 Make `getRulesetTransformedSkin` private 2021-06-16 17:44:18 +09:00
Salman Ahmed b6947c25ec Fix potentially adding the same skin multiple times 2021-06-11 17:55:07 +03:00
Salman Ahmed 108a3deb27 Also handle null `Ruleset.CreateLegacySkinProvider` values 
Let's just go this way for now, maybe it's a better choice to always create transformers and disallow null, but it's too much work and out of scope at this point
 2021-06-11 16:26:54 +03:00
Salman Ahmed 2e01e61177 Move TODO comment to correct location 2021-06-11 11:46:30 +03:00
Salman Ahmed 169c98f963 Add skin providing ruleset resources in `RulesetSkinProvidingContainer` 2021-06-11 00:25:22 +03:00
Salman Ahmed ef2c4fd0d8 Make `RulesetSkinProvidingContainer` able to be overriden for testing purposes 2021-06-10 16:36:46 +03:00
Salman Ahmed 09a2d008d2 Refrain from attempting to transform null skins 2021-06-10 16:36:45 +03:00
Salman Ahmed c3a2f2c2a4 Expose default `SkinManager` providers for use in `RulesetSkinProvidingContainer` 2021-06-10 13:07:32 +03:00
Salman Ahmed 18edbdd135 Remove mentioning of "layer" in skin providers 
`SkinSources` sounds better.
 2021-06-10 11:55:26 +03:00
Salman Ahmed 33a9cac398 Add special `RulesetSkinProvidingContainer` managing ruleset-compatible skin setup 2021-06-09 22:49:31 +03:00