Commit Graph

3140 Commits

Author SHA1 Message Date
Andrei Zavatski 54d83eff94 Use OverlayColourProfider for VotePill component 2020-02-26 19:35:20 +03:00
Dan Balasescu 37e9c2a683
Merge branch 'master' into user-list-toolbar 2020-02-26 10:11:21 +09:00
Dan Balasescu ff063b229b
Merge pull request #7973 from peppy/fix-dho-lifetimes-via-judgements
Fix hitobjects with unknown lifetimes by enforcing non-null judgement
2020-02-25 20:38:29 +09:00
Dean Herbert 61af80c1af
Merge pull request #7982 from EVAST9919/comments-crash-fix
Fix potential crash when clicking on show more button in comments
2020-02-25 20:14:58 +09:00
Dean Herbert 29e2e17144 Merge branch 'master' into fix-dho-lifetimes-via-judgements 2020-02-25 19:07:57 +09:00
Dean Herbert a047456354 Revert changes to make HitObject abstract 2020-02-25 19:07:15 +09:00
Andrei Zavatski c1455be855 Add tests 2020-02-25 10:29:03 +03:00
Andrei Zavatski 7bc9a9b3d8 Implement OverlayPanelDisplayStyleControl and UserListToolbar components 2020-02-24 07:28:33 +03:00
Andrei Zavatski 0cfe1ac823 Implement UserSortTabControl component 2020-02-24 05:47:21 +03:00
Dean Herbert ffc7eaa3f2 Fix hitobjects with unknown lifetimes by enforcing non-null judgement
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.

This fixes BananaShower and JuiceStreams in osu!catch.

This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
Dean Herbert e8ebb31517 Expire old judgement lines if too many exist 2020-02-23 03:53:51 +09:00
Bartłomiej Dach a512226036 Use attribute instead of CreateChildDependencies 2020-02-22 13:47:42 +01:00
Bartłomiej Dach f248c0a98e Fix regressed direct panel test scene
Due to unnoticed past changes TestSceneDirectPanel has regressed in that
clicking the preview track button would crash due to an unregistered
IPreviewTrackOwner dependency.

Make the test scene itself implement that empty interface and cache
itself as IPreviewTrackOwner so that preview tracks lower down can
resolve the dependency.

As the test is purely visual and has no assertions, and the important
logic in that area (preview track playing logic) is already well-covered
enough elsewhere, no further changes were made.
2020-02-22 00:58:33 +01:00
Dean Herbert db1e5abad7
Merge pull request #7786 from EVAST9919/subcomments-alter-new
Add ability to load long comment trees in CommentsContainer
2020-02-21 21:18:33 +09:00
smoogipoo 41c6d2f2e7 Merge remote-tracking branch 'origin/master' into subcomments-alter-new 2020-02-21 17:02:58 +09:00
Dean Herbert 7d145a7470 Add test for loading spinner with box 2020-02-21 16:21:44 +09:00
Dean Herbert bbac95958c Fix incorrect test scene name 2020-02-21 16:20:55 +09:00
Dean Herbert 38d9a46ffb Add test for relative sizing scenarios 2020-02-21 16:20:17 +09:00
Dean Herbert 92f6f0207c Rename LoadingAnimation to LoadingSpinner 2020-02-21 15:33:31 +09:00
Dean Herbert 623b78d675 Combine all loading animation implementations 2020-02-21 15:32:46 +09:00
smoogipoo 2cb218c9c4 Merge remote-tracking branch 'origin/master' into comment-editor 2020-02-21 12:27:34 +09:00
Dean Herbert cd666166d5
Merge pull request #7809 from voidedWarranties/proposal-difficulty-icon-select
Allow selecting/playing a specific difficulty using the beatmapset difficulty icons
2020-02-21 10:24:12 +09:00
Dean Herbert 3380dbbd71 Improve visual appearance of ProcessingOverlay 2020-02-20 19:49:22 +09:00
Dean Herbert 927115a085
Merge branch 'master' into room-inspector-redesign 2020-02-20 17:41:16 +09:00
Dean Herbert e48166858c
Merge branch 'master' into overlined-display-refactor 2020-02-20 17:38:04 +09:00
Dean Herbert 5c16dbbea9
Merge pull request #7919 from smoogipoo/null-leaderboard-position
Support null leaderboard position
2020-02-20 16:27:24 +09:00
smoogipoo d79ca97fe9 Make beatmap scores also support null position 2020-02-20 15:04:12 +09:00
Dan Balasescu eb8a56055f
Merge pull request #7910 from EVAST9919/rankings-clickable-countries
Make country names in RankingsOverlay clickable
2020-02-20 15:00:01 +09:00
smoogipoo 1a689231c2 Support null leaderboard position 2020-02-20 14:51:25 +09:00
smoogipoo 177935d644 Remove unused using 2020-02-20 14:45:35 +09:00
Dean Herbert 0cf0099fd5
Merge pull request #7917 from smoogipoo/fix-drawableroom-async-test
Fix possible test failures due to async loads
2020-02-20 14:37:51 +09:00
smoogipoo c5fd969568 Fix 0 size in test scene 2020-02-20 14:33:13 +09:00
Dan Balasescu bf5c34a014
Merge branch 'master' into rankings-clickable-countries 2020-02-20 14:21:44 +09:00
smoogipoo b2d9004212 Fix possible test failures due to async loads 2020-02-20 08:37:23 +09:00
Andrei Zavatski 8fcfb73d72 Implement BeatmapListingOverlay 2020-02-19 17:40:54 +03:00
Andrei Zavatski 1417c90173 Remove redundant blank line 2020-02-19 17:24:44 +03:00
Andrei Zavatski a79398ddbd Fix incorrect caching in TestSceneRankingsOverlay 2020-02-19 17:09:22 +03:00
smoogipoo ac416ae743 Implement new room inspector redesign 2020-02-19 17:47:59 +09:00
smoogipoo ec73e8f0c7 Allow different sizing modes for OverlinedParticipants 2020-02-19 17:40:38 +09:00
smoogipoo e3d37b808d Move overlined displays to a higher namespace 2020-02-19 17:33:09 +09:00
Andrei Zavatski 37003e11b9 Make fields readonly 2020-02-18 18:04:39 +03:00
Andrei Zavatski bb22243903 TestScene improvements 2020-02-18 17:47:44 +03:00
Andrei Zavatski 7228900361 Implement BeatmapListingSearchSection component 2020-02-18 17:25:12 +03:00
Andrei Zavatski 3bf3becdd6 Merge remote-tracking branch 'refs/remotes/ppy/master' into subcomments-alter-new 2020-02-18 13:27:08 +03:00
Dean Herbert b18f9e195e Merge branch 'master' into bindable-list-events 2020-02-18 18:47:06 +09:00
smoogipoo ee13632375 Fix ogg beatmap/skin samples not loading 2020-02-18 13:21:55 +09:00
Dan Balasescu 75e0668b4e
Merge branch 'master' into new-direct-sort 2020-02-18 10:17:26 +09:00
Andrei Zavatski 410686c8b9 Use dropdown in BeatmapSearchFilterRow 2020-02-18 01:04:25 +03:00
Andrei Zavatski c69818925b Merge remote-tracking branch 'refs/remotes/ppy/master' into new-betmap-search-filter 2020-02-17 23:35:12 +03:00
Andrei Zavatski 19872d9e24 Simplify test scene 2020-02-17 22:05:10 +03:00