Commit Graph

117 Commits

Author SHA1 Message Date
Salman Ahmed 61078910a6 Handle all skin component types explicitly 2022-04-23 03:34:05 +03:00
Dean Herbert 2d020e756d
Merge pull request #17621 from frenzibyte/taiko-target-size
Adjust osu!taiko legacy hit target size to match osu!(stable)
2022-04-05 12:37:40 +09:00
Salman Ahmed 534cc18ff9 Adjust osu!taiko legacy hit target size to match osu!(stable) 2022-04-03 01:21:48 +03:00
Salman Ahmed 4ce69890d4 Use `TaikoHitObject.DEFAULT_SIZE` for default circle piece symbol size 2022-04-03 00:21:23 +03:00
Bartłomiej Dach 735414bc49
Replace `TimeSignatures` enum with struct for storage of arbitrary meter 2022-01-22 20:50:31 +01:00
Susko3 19467e58c1 Remove unused params from BDL methods 2022-01-15 01:06:39 +01:00
Dean Herbert add39fbd4f Merge branch 'master' into fix-skin-layout-editor-crash 2021-10-28 06:24:24 +09:00
Dean Herbert 6944151486 Apply batch fixing of built-in types using `var` 2021-10-27 13:04:41 +09:00
Dean Herbert 93482414d6 Remove `SkinConfiguration` subclasses and allow configuration parsing for all skin types 2021-10-22 14:42:23 +09:00
Dean Herbert 32afd3f426 Replace all basic usages 2021-10-02 02:22:23 +09:00
smoogipoo f9d5abff8a Update with keybinding changes 2021-09-16 18:26:12 +09:00
Dean Herbert 90e81a595d Move `DrumSampleTriggerSource` into its own class to avoid nested references 2021-08-26 17:19:46 +09:00
Dean Herbert 8e0a04c4e5 Update taiko `InputDrum` to use new trigger logic 2021-08-25 16:56:44 +09:00
Dean Herbert 4b45d8318e
Merge branch 'master' into transformers-per-skin 2021-06-16 16:37:28 +09:00
Salman Ahmed fbb856d84b Call `base` when overriding lookup methods
Rather than arbitrarily accessing `Skin` here and there.
2021-06-11 12:44:44 +03:00
Dean Herbert 9c34cb0777 Share colour constants with default drawable piece implementations 2021-06-11 14:20:08 +09:00
Salman Ahmed cf40282f1f Convert `LegacySkinTransformer`s to accept raw `ISkin`s rather than a full `ISkinSource` 2021-06-09 22:49:31 +03:00
Dean Herbert 2e2281c7d2 Revert disabling taiko sample tests and fix logic 2021-06-01 18:57:19 +09:00
Dean Herbert 17574833fb Update other transformers with similar refactored logic 2021-05-30 19:15:59 +09:00
Salman Ahmed fbc316ea1d Fix legacy skin transformers potentially ignoring source implementations 2021-05-29 21:23:22 +03:00
Bartłomiej Dach f716fb0968 Remove bogus `InternalChildren` null-check
`InternalChildren` can't viably be `null`, and if it were, we have
bigger problems. The removed null-check was triggering false-positive
inspections further down.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach aec859b4d1 Merge branch 'master' into fix-unsafe-skinnable-sample-play 2021-03-18 19:51:46 +01:00
smoogipoo 0c3c8141da Remove Expires and RemoveWhenNotAlive override 2021-03-18 19:39:42 +09:00
Bartłomiej Dach 3bfde7341f Revert "Remove unnecessary overrides"
This reverts commit f4e508b570.
2021-03-17 17:14:53 +01:00
Bartłomiej Dach f4e508b570 Remove unnecessary overrides 2021-03-15 20:43:30 +01:00
Bartłomiej Dach 58220481db Rename `I{-> Animatable}HitExplosion` 2021-03-15 20:39:02 +01:00
Bartłomiej Dach 8b74666cc3 Add support for pooling explosions in taiko 2021-03-14 16:15:33 +01:00
Bartłomiej Dach ad1b86e33a Change `LifetimeEnd` idiom to `Expire()` for readability 2021-03-06 18:54:25 +01:00
Bartłomiej Dach 06e42b4b4c Fix taiko leaving behind empty judgements on legacy skins 2021-03-06 16:02:20 +01:00
Dean Herbert 00574a5288 Use ISample everywhere in Skin GetSample lookup path 2021-02-18 18:32:28 +09:00
smoogipoo de9d075f94 Initial sample + samplechannel rework 2021-01-19 17:11:40 +09:00
Bartłomiej Dach 5af1ac1b53 Rename TaikoStrong{-> able}HitObject 2020-12-14 21:46:02 +01:00
Bartłomiej Dach b1635ecd16 Reflect can-be-strong split in DHO structure 2020-12-13 13:08:30 +01:00
ekrctb c70b13ecc2 Adjust namespace 2020-12-07 12:30:25 +09:00
ekrctb f78bd7c739 Move piece files of Taiko ruleset 2020-12-07 12:29:14 +09:00
Bartłomiej Dach 891218ec6b Inline empty explosion in legacy transformer 2020-11-11 09:11:33 +01:00
Bartłomiej Dach be4735cd2b Explicitly set lifetime to ensure empty drawables are cleaned up 2020-11-10 14:57:51 +01:00
Bartłomiej Dach 0387d994bd Do not lookup default kiai explosion if skin has own 2020-11-10 14:18:43 +01:00
Dean Herbert 2ec2749cb4 Fix taiko lookup logic 2020-10-30 11:59:41 +09:00
Dean Herbert 8c528c8910 Fix legacy taiko skins showing double judgements 2020-10-07 18:36:40 +09:00
Bartłomiej Dach 2b1ef16f89 Replace comparison references to HitResult.Miss with IsHit 2020-10-02 23:31:24 +02:00
smoogipoo 7890319802 Merge branch 'master' into adjust-hit-result-types 2020-10-01 16:19:07 +09:00
smoogipoo cb6b35116a Merge branch 'master' into scoring-standardisation 2020-10-01 12:28:51 +09:00
smoogipoo f439c1afbc Make osu/taiko/catch use Ok+Great 2020-09-29 17:16:55 +09:00
smoogipoo c45b5690cf Use new hit results in taiko 2020-09-29 16:33:38 +09:00
Bartłomiej Dach 2fb9a5d734 Remove no longer required field 2020-09-28 17:53:32 +02:00
Bartłomiej Dach f6f267a43a Switch to strong sprite exactly once 2020-09-28 17:53:12 +02:00
Bartłomiej Dach 0900661b23 Use IsHit for strong hit instead of checking result type 2020-09-28 16:34:04 +02:00
Bartłomiej Dach 4944128631 Ensure both sprites are centered 2020-09-27 18:11:12 +02:00
Bartłomiej Dach 2f7c0b4934 Allow switching between legacy sprites 2020-09-27 16:07:19 +02:00