Commit Graph

64753 Commits

Author SHA1 Message Date
Dan Balasescu 17a531209c
Use SliderTailHit result for slider tails (non-classic-mod) 2023-12-30 10:38:47 +09:00
Dan Balasescu 807443b648
Add HitResult.SliderTailHit 2023-12-30 10:38:47 +09:00
Dean Herbert 0fa4cd5dfe
Merge pull request #26225 from peppy/new-menu-tips
Add some new menu tips (and reword some others)
2023-12-29 22:27:47 +09:00
Dean Herbert 61c46b78bd
Update MenuTip.cs
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2023-12-29 22:24:16 +09:00
Dean Herbert 9f0fe6c6ca
Fix common typos
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-12-29 22:20:29 +09:00
Dean Herbert d00b7c9cdf
Add some new menu tips (and reword some others) 2023-12-29 22:14:51 +09:00
Bartłomiej Dach f80f6a8c5b
Merge pull request #26207 from frenzibyte/fix-dropdown-colour
Fix dropdown colour not updating correctly on enabled state changes
2023-12-29 14:07:09 +01:00
Dean Herbert 4437e2198a
Merge pull request #26224 from bdach/delete-toolbar-user-button-background
Remove opaque background from toolbar user button
2023-12-29 22:01:45 +09:00
Bartłomiej Dach 17753b8235
Remove opaque background from toolbar user button
Would close https://github.com/ppy/osu/issues/26223, and generally seems
more consistent with the rest of toolbar anyhow?
2023-12-29 13:49:11 +01:00
Dean Herbert 490c584982
Merge pull request #26222 from bdach/i-cannot-into-offsets
Fix global audio offset suggestion feature not taking previous offset value into account
2023-12-29 21:14:52 +09:00
Dean Herbert 2b81f4f557
Merge pull request #26221 from bdach/system-title-only-on-top-level-menu
Do not display system title in inital menu state
2023-12-29 21:13:40 +09:00
Bartłomiej Dach cdcb3ef4aa
Fix global audio offset suggestion feature not taking previous offset value into account
See https://osu.ppy.sh/comments/2989193 etc.
2023-12-29 12:20:58 +01:00
Dan Balasescu 9548818a1b
Merge pull request #26220 from bdach/no-version-manager-on-deployed-builds
Do not show main menu version display on deployed builds
2023-12-29 19:54:30 +09:00
Bartłomiej Dach db78d73fa5
Do not display system title in inital menu state
Addresses https://github.com/ppy/osu/discussions/26199.
2023-12-29 11:50:30 +01:00
Bartłomiej Dach a9cf909937
Merge pull request #26219 from bdach/editor-timeline-crash
Fix crash after changing audio track in editor
2023-12-29 11:41:45 +01:00
Bartłomiej Dach 25fa76a1b2
Do not show main menu version display on deployed builds
See https://discord.com/channels/188630481301012481/188630652340404224/1190028102525530202.
2023-12-29 11:14:28 +01:00
Bartłomiej Dach 99cddb6317
Use alternative workaround 2023-12-29 11:07:45 +01:00
Bartłomiej Dach cd1f6b46c4
Fix crash after changing audio track in editor
Closes https://github.com/ppy/osu/issues/26213.

Reproduction scenario: switch audio track in editor after timeline
loads.

Happens because `beatmap.Value.Track.Length` is 0 immediately after a
track switch, until BASS computes the actual track length on the audio
thread.

Yes this is a hack. No I have no better immediate ideas how to address
this otherwise.
2023-12-29 10:37:36 +01:00
Bartłomiej Dach 9bb0663b3b
Add test coverage of failure case 2023-12-29 10:36:53 +01:00
Dean Herbert f7a4a2b098
Merge pull request #26216 from smoogipoo/expose-mod-property
Expose `Mod.UsesDefaultConfiguration`
2023-12-29 18:03:25 +09:00
Dan Balasescu a6313c4ee8
Expose `Mod.UsesDefaultConfiguration` 2023-12-29 17:16:16 +09:00
Dean Herbert b163df42c2
Merge pull request #26203 from LeNitrous/fix/menu-tip-mod-select
Make the menu tip about mod select's fun mods more up to date.
2023-12-29 13:41:58 +09:00
Salman Ahmed c147ec0a98 Update dropdown disabled state to match with other components 2023-12-29 05:31:13 +03:00
Salman Ahmed 150bf67064 Fix dropdown colour not updating correctly on enabled state changes 2023-12-29 05:30:50 +03:00
Nitrous c68a850325
Make menu tip about mod select more up to date. 2023-12-29 08:51:54 +08:00
Dean Herbert 91f0603507
Merge pull request #26196 from bdach/fix-system-title-crash
Fix crash when retrieval of system title image fails
2023-12-29 05:07:13 +09:00
Bartłomiej Dach 7a10e132ea
Fix crash when retrieval of system title image fails
Closes https://github.com/ppy/osu/issues/26194.
2023-12-28 20:39:13 +01:00
Bartłomiej Dach 68402bfd11
Add test coverage of failure scenario 2023-12-28 20:39:11 +01:00
Dean Herbert 8e3fe090f3
Merge pull request #26169 from bdach/universal-offset-from-session-plays
Implement automatic suggestion of global audio offset based on last plays
2023-12-28 22:57:30 +09:00
Dean Herbert 1de3e3771f
Merge pull request #26187 from peppy/dialog-overlay-design-update
Update popup dialog design
2023-12-28 22:39:42 +09:00
Bartłomiej Dach 93c7ebdae3
Remove unused using 2023-12-28 14:30:11 +01:00
Bartłomiej Dach 6d124513e7
Fix test failures due to player bailing early after failing to load beatmap 2023-12-28 14:15:15 +01:00
Bartłomiej Dach 619b0cc69b
Fix code quality inspection 2023-12-28 14:12:28 +01:00
Bartłomiej Dach 6718de01ec
Suggest audio adjust after one play 2023-12-28 14:11:08 +01:00
Bartłomiej Dach e6f1d7db44
Move `SessionAverageHitErrorTracker` to more general namespace 2023-12-28 14:10:03 +01:00
Bartłomiej Dach 24a80da83f
Merge branch 'master' into universal-offset-from-session-plays 2023-12-28 14:07:46 +01:00
Bartłomiej Dach bb0737837b
Fix test failing due to querying button position during transform 2023-12-28 13:58:00 +01:00
Bartłomiej Dach e0279920b6
Merge pull request #26189 from peppy/fix-escape-key-spectator-fail
Fix using "Back" binding at spectator fail screen not working
2023-12-28 13:23:38 +01:00
Dean Herbert 6bc0f02e2d
Fix test initialising dialogs without cleaning up 2023-12-28 20:40:51 +09:00
Dean Herbert f8347288c1
Add padding around text in dialogs 2023-12-28 20:29:56 +09:00
Bartłomiej Dach a9c7131d47
Merge pull request #26184 from peppy/spectate-from-context-menu
Allow entering spectator mode from context menu on user panels
2023-12-28 12:24:29 +01:00
Dean Herbert e1a376c0a7
Fix using "Back" binding at spectator fail screen not working 2023-12-28 20:14:18 +09:00
Bartłomiej Dach 0fc86a07cb
Merge pull request #26177 from peppy/fix-leaderboard-tab-ordering
Fix song select leaderboard tab ordering not matching stable
2023-12-28 12:02:46 +01:00
Dean Herbert 91af94086c
Remove offset wizard button for now 2023-12-28 20:02:08 +09:00
Dean Herbert b7f3c83514
Expose the ability to update global offset from the player loader screen 2023-12-28 20:01:34 +09:00
Dean Herbert c7f10dbc74
Merge pull request #26148 from rushiiMachine/resumeoverlay-min-cursor-size
Force minimum cursor size for `OsuResumeOverlay`
2023-12-28 19:23:57 +09:00
Dean Herbert 28e220ca50
Update popup dialog design
Had to be done. I hated the old ones so much.

As usual, disclaimer that this is an iterative design and will probably
be replaced in the future.
2023-12-28 19:04:35 +09:00
Bartłomiej Dach f5a3124e20
Merge pull request #26183 from peppy/menu-supporter-display
Show supporter love message at main menu and remove the disclaimer screen
2023-12-28 11:03:04 +01:00
Bartłomiej Dach a717ad5527
Merge branch 'master' into menu-supporter-display 2023-12-28 10:55:10 +01:00
Bartłomiej Dach 17325ff35b
Merge pull request #26182 from peppy/menu-tips
Move menu tips to main menu
2023-12-28 10:40:11 +01:00