Commit Graph

2390 Commits

Author SHA1 Message Date
Bartłomiej Dach 998d709331
Merge branch 'master' into mania-key-expand-mobile 2023-11-02 11:59:01 +01:00
Dean Herbert 704f5a6de3
Adjust sizing slightly to ensure we stay within 1366 limits 2023-11-02 11:44:36 +01:00
Dean Herbert c83589cb74
Change osu!mania conversion mod ordering to be more appeasing 2023-11-02 15:49:10 +09:00
Dean Herbert 6dab5ee4cf
Add support for "argon" default skin to expand columns when on mobile device
Should ease those looking to play the game on mobile until we
(potentially) have a better solution in the future.

If this works out well, we can consider rolling it out to other skins.

Closes https://github.com/ppy/osu/issues/23377.
2023-11-02 15:13:44 +09:00
Dean Herbert fbba3787d1
Merge pull request #25190 from frenzibyte/match-skin-element-animation-support
Match capability of animating legacy skin elements with osu!(stable)
2023-10-30 18:25:06 +09:00
Salman Ahmed 976ae62214 Fix incorrect nullability specification 2023-10-21 01:10:06 +03:00
Salman Ahmed 491f119988 Add animation support for legacy osu!mania column lights 2023-10-21 00:22:34 +03:00
Salman Ahmed 517d0f65b6 Adjust frame length of osu!mania hold-note body animation 2023-10-21 00:22:31 +03:00
Salman Ahmed badb1310a3 Adjust frame length of osu!mania judgement animation 2023-10-20 23:59:03 +03:00
Bartłomiej Dach b321d556b6
Enforce minimum gameplay sample volume of 5% 2023-10-20 15:50:13 +02:00
Dean Herbert 52c2eb93de
Merge branch 'master' into taiko-beat-snap-grid 2023-10-19 23:53:01 +09:00
Dean Herbert 5341a335a6
Bypass `Parent` nullability checks for now 2023-10-17 17:48:45 +09:00
Bartłomiej Dach 2192c9f2c2
Remove unused using directive 2023-10-17 10:30:01 +02:00
Bartłomiej Dach 22c1a963e7
Remove unused field 2023-10-17 10:27:16 +02:00
Dean Herbert 4381169a3f
Combine selection and input handling logic for beat snap grids across all rulesets 2023-10-17 17:09:42 +09:00
Dean Herbert 1b9acdf55c
Abstract out common implementation of `BeatSnapGrid` 2023-10-17 16:42:52 +09:00
Dean Herbert d26d4b8b79
Cache `IScrollingInfo` at a `HitObjectComposer` level automatically 2023-10-17 16:42:22 +09:00
Bartłomiej Dach b9a84127ac
Remove mention of "any tick"
They're very dead now.
2023-10-16 08:57:35 +02:00
Dean Herbert 4f1546c474
Rename `PerfectBonusNote` to `NotePerfectBonus` 2023-10-16 15:14:28 +09:00
Dean Herbert 3f09ed396f
Fix legacy skin body piece dimming when it shouldn't 2023-10-16 15:11:33 +09:00
Dean Herbert 1a957364ae
Add empty hit windows on `PefectBonusNote` 2023-10-16 14:58:49 +09:00
Dean Herbert 43f619f92a
Add `DisplayResult` flag and remove unnecessary `AlwaysPresent` 2023-10-16 14:57:58 +09:00
Dean Herbert 14fedffcc1
Fix `MissForcefully` not considering the bonus object 2023-10-16 14:53:36 +09:00
Dean Herbert e85c039722
Adjust method flow to hopefully be more legible 2023-10-16 13:31:14 +09:00
Dean Herbert ddbda69751
Remove nullability of `bonusNote` 2023-10-16 13:14:58 +09:00
Dean Herbert 850950ba61
Add note about why `SmallBonus` is not listed in `GetValidHitResults` 2023-10-13 17:36:30 +09:00
Dean Herbert 125f28219d
Fix hodl tail notes not correctly handling nested bonus judgement 2023-10-13 17:36:19 +09:00
Dean Herbert 94b64044e0
Add nested bonus judgement to `DrawableNote` for perfect bonus score 2023-10-13 17:01:48 +09:00
Bartłomiej Dach a42e75452e
Remove remaining usages of `LargeTickHit` in mania 2023-10-12 11:16:51 +02:00
Bartłomiej Dach 063623b4e6
Merge branch 'master' into remove-hold-note-ticks 2023-10-11 19:47:51 +02:00
Bartłomiej Dach 3f29f27cd4
Assign empty hit windows to `HoldNoteBody`
It's not a timed object, so following precedent, it should have empty
hitwindows.

This is not actually just aesthetics; several components check whether a
hitobject has empty hitwindows to determine whether to include it on
various HUD displays and results screen components where timed objects
are explicitly involved.
2023-10-11 19:40:55 +02:00
Dean Herbert 8dc9453d8d
Apply some xmldoc and structural changes 2023-10-10 16:59:25 +09:00
Dean Herbert 1a60d6ade5
Use a `DrawablePool` for mania's beat snap grid
I'm not sure what the cause of the issue is, but I'm also not sure why
it wasn't using `DrawablePool` (was it not around back then?).

Either way, switching to a proper pool fixes things just fine.

Resolves https://github.com/ppy/osu/issues/25009.
2023-10-10 13:36:31 +09:00
Bartłomiej Dach 71c4b138fb
Merge branch 'master' into fix-legacy-score-multipliers-2 2023-10-09 10:53:14 +02:00
Dan Balasescu e874ec81c9
Remove unused usings 2023-10-09 12:22:08 +09:00
Dan Balasescu f0da7f016d
Actually use the judgement 2023-10-09 11:49:54 +09:00
Dan Balasescu d988ef9b22
Revert functional change 2023-10-09 10:50:39 +09:00
Dan Balasescu 9415fe4446
Add mania hold note body + combo break judgement 2023-10-09 09:47:00 +09:00
Dan Balasescu b2d9c95441
Remove HoldNoteTickJudgement 2023-10-09 09:31:45 +09:00
Dan Balasescu 5362902c87
Merge branch 'master' into remove-hold-note-ticks 2023-10-09 08:15:10 +09:00
Dean Herbert f2e56bbb65
Fix publicly-settable bindables 2023-10-06 16:51:24 +09:00
Dan Balasescu da2a4681d9 Add method to retrieve legacy score multiplier 2023-10-02 16:52:01 +09:00
Dan Balasescu b4b7a7ea5e Add LegacyBeatmapConversionDifficultyInfo abstraction 2023-10-02 16:52:01 +09:00
NiceAesth 83bf1efc1c Add `color` search alias for `colour` settings 2023-09-27 16:29:29 +03:00
Bartłomiej Dach e1d52134ae
Merge pull request #24930 from peppy/adjust-mania-barlines
Adjust osu!mania "major" barlines to be less visually distracting
2023-09-26 19:39:22 +02:00
Dean Herbert 9949480ccd Add minor edge smoothing to fix flickering of barlines
In most cases.

Closes https://github.com/ppy/osu/issues/15184.
2023-09-26 17:06:52 +09:00
Dean Herbert 5150c5a643 Adjust osu!mania "major" barlines to be less visually distracting
Applies to both "triangles" and "argon" skins.
2023-09-26 17:06:27 +09:00
Dean Herbert 0dcf7a2fa9
Merge branch 'master' into split-legacy-scoring-attribs 2023-09-26 15:52:27 +09:00
Dean Herbert cb0226f843 Implement new interface-based speed change visualisation support on mania/taiko 2023-09-20 15:28:13 +09:00
Dean Herbert 41a8239e49 Remvoe null default for mods which can't be null 2023-09-20 15:27:50 +09:00