RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
53,230 Commits 3 Branches 658 Tags 352 MiB
Commit Graph

386 Commits

Author SHA1 Message Date
Salman Ahmed 4f009419b8 Simplify population logic and match code style 2022-07-11 21:51:09 +03:00
Andrew Hong 10d6027c89 Assign missing UserID to RealmUser 2022-07-11 02:36:51 -04:00
andy840119 8c2f4b48fc Use debug.assert for better readable. 2022-07-03 19:27:56 +08:00
andy840119 0a1543c6e8 Use `AsNonNull()` instead. 2022-07-02 19:48:32 +08:00
andy840119 c6d0f0f81b pretend that the beatmap property will not be null. 
Not really throw exception will be the better way?
 2022-07-02 13:20:46 +08:00
Bartłomiej Dach 577a87bcad
Merge branch 'master' into importer-post-import-rename 2022-06-20 13:37:16 +02:00
Dean Herbert dbae4c6f5a `PostImport` -> `PresentImport` 2022-06-20 18:36:29 +09:00
Dean Herbert ebcee21f6f Remove necessity to provide `BeatmapDifficultyCache` as a function to `ScoreManager` 2022-06-20 17:52:42 +09:00
Dean Herbert 92f1a2958c Rename `Import(TModel)` to `ImportModel` to differentiate from other import methods 2022-06-20 15:18:07 +09:00
Dan Balasescu f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Dean Herbert e66ccfd980 Add back missing notification flow 2022-06-16 19:48:18 +09:00
Dean Herbert ce3d3a967c Reimplement missing methods 2022-06-16 19:05:25 +09:00
Dean Herbert 72c5b9009d Remove local `realm` fields in manager classes 2022-06-16 18:56:53 +09:00
Dean Herbert f3984d98e6 Remove `RealmArchiveModelManager` from hierarchy 2022-06-16 18:53:13 +09:00
Dean Herbert 4d9e3d1982 Rename Score/Skin `ModelManager` classes to `Importer` for now 2022-06-16 18:11:50 +09:00
Dean Herbert f23ddfe6cc Move remaining realm classes out of `Stores` namespace 2022-06-15 21:56:00 +09:00
Dean Herbert 88d5e074a8 Rename `lowPriority` to `batchImport` 2022-06-15 00:46:00 +09:00
Dean Herbert 2f8290831a Skip quick import clause when importing a single item 
Closes https://github.com/ppy/osu/issues/18600.
 2022-06-15 00:26:34 +09:00
Dean Herbert 9f599a5ab4 Remove unused `lowPriority` flag from one `Import` method 2022-06-14 19:52:30 +09:00
Dean Herbert ca0765a932 Tidy up various delegation implementations 2022-06-14 19:46:59 +09:00
Dan Balasescu 773ba97117 Add xmldoc to ScoringValues 2022-06-02 16:39:51 +09:00
Dan Balasescu a638392e81 Rename member 2022-06-02 16:35:50 +09:00
Dan Balasescu af0f934e1a Move raw ScoreProcessor values into ScoringValues struct 2022-05-31 19:39:38 +09:00
Dan Balasescu 4df63a4900 Prevent scores being calculated twice 2022-03-30 13:15:41 +09:00
Dan Balasescu bd9c0076df Fix scores sometimes shown with incorrect scoring mode 2022-03-30 13:03:12 +09:00
Dean Herbert a7554dcdf7 Use a constant for the early version timing offset 2022-03-24 16:43:41 +09:00
Dean Herbert a7d5f2281c Apply beatmap offsets to legacy replay frame handling 2022-03-24 16:16:40 +09:00
Salman Ahmed b9859f9f21 Obsolete `BeatmapInfo.MaxCombo` and suppress in usages 2022-03-20 16:30:29 +03:00
Salman Ahmed aef40da8d4 Add note about null return value 2022-03-20 16:24:30 +03:00
Salman Ahmed 2a78042038 `GetBeatmapMaximumComboAsync` -> `GetMaximumAchievableComboAsync` 2022-03-20 16:18:53 +03:00
Salman Ahmed d36f32a9c9 Introduce method for computing maximum achievable combo properly 2022-03-20 05:38:14 +03:00
Dan Balasescu 4a3e3aba65 Restructure PerformanceCalculator to not require ScoreInfo argument 2022-03-14 14:25:28 +09:00
Dean Herbert 94ff6a338f
Merge branch 'master' into scoreprocessor-rework 2022-03-09 23:04:18 +09:00
Dan Balasescu f1c40bd9ed Rework GetScore() method signatures + implementations 
Rename legacy-facing overload to mention as much
 2022-03-08 22:30:44 +09:00
Dan Balasescu f5cd967635 Fix scores not being recalculated in beatmap listing 2022-03-08 19:07:39 +09:00
Bartłomiej Dach 36263b4dbf
Replace remaining manual online ID check with extension method 2022-03-03 23:09:56 +01:00
Dean Herbert eb75a29b20 Use constant for maximum legacy ruleset id 2022-03-01 12:07:03 +09:00
Dean Herbert 52e50db6b9 Enable `nullable` for `LegacyScoreEncoder` 2022-02-28 18:42:23 +09:00
Dean Herbert 723e96309a Only convert non-legacy frames (and throw on conversion failure) 2022-02-28 18:42:23 +09:00
Dean Herbert 2e96f74c94 Allow `LegacyScoreEncoder` to be used without a beatmap if frames are already legacy frames 2022-02-28 18:42:23 +09:00
Dan Balasescu c3b365cf6b Scale classic score by hitobject count 2022-02-21 13:31:03 +09:00
Henry Lin f29301cd1e
Merge branch 'master' into display-performance-attributes 2022-02-05 16:59:46 +08:00
Bartłomiej Dach 16e0cc6a2b
Remove `IIpcHost` param from `ScoreManager` 
No longer used since 3e3b9bc963.
 2022-02-01 21:35:40 +01:00
Dean Herbert 0d3ac4fd9c Fix delete local scores crashing the game 2022-01-28 15:54:53 +09:00
Dean Herbert 5288eedd31 Update all usages of `RulesetID` and `Ruleset.ID` to use `Ruleset.OnlineID` 2022-01-27 15:38:03 +09:00
Dean Herbert 378173cc66 Fix some score imports failing due to null string attempted to be parsed as json 2022-01-26 22:46:29 +09:00
Dan Balasescu 4a51bab9ac
Merge pull request #16622 from peppy/fix-results-score-switch-crash 
Fix crash at results screen when viewing another score panel after playing
 2022-01-26 16:59:39 +09:00
Dean Herbert 3491b77c8c Fix `ScoreInfo.RealmUser` not getting deep cloned correctly 
I'm still not at all happy with the play-to-results flow (with multiple
clones), but this will have to do for now.
 2022-01-26 14:27:48 +09:00
Dean Herbert cd71ec0edd Remove `ILive<>` interface (and use `abstract Live<>` instead) 2022-01-26 13:38:56 +09:00
Dean Herbert 778d2a71b4 Remove `Task` from the inner-most `Import` method in `RealmArchiveModelImporter` 
One of my pending work items for post-realm merge.

The lowest-level import task is no longer asynchronous, as we don't want
it to span multiple threads to allow easier interaction with realm.
Removing the `Task` spec simplifies a heap of usages.

Individual usages should decide whether they want to run the import
asynchronously, by either using an alternative override or spooling up a
thread themselves.
 2022-01-25 15:30:29 +09:00