osu/osu.Game.Rulesets.Osu.Tests/TestSceneOutOfOrderHits.cs

448 lines
18 KiB
C#
Raw Normal View History

2020-03-18 08:00:48 +00:00
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.
2020-03-30 07:15:07 +00:00
using System;
2020-03-18 08:00:48 +00:00
using System.Collections.Generic;
using System.Linq;
using NUnit.Framework;
using osu.Framework.Extensions.TypeExtensions;
2020-03-18 08:00:48 +00:00
using osu.Framework.Screens;
using osu.Framework.Utils;
2020-03-18 08:00:48 +00:00
using osu.Game.Beatmaps;
using osu.Game.Beatmaps.ControlPoints;
using osu.Game.Replays;
using osu.Game.Rulesets.Judgements;
2020-03-30 07:15:07 +00:00
using osu.Game.Rulesets.Objects;
using osu.Game.Rulesets.Objects.Types;
2020-03-18 08:00:48 +00:00
using osu.Game.Rulesets.Osu.Objects;
using osu.Game.Rulesets.Osu.Replays;
using osu.Game.Rulesets.Replays;
using osu.Game.Rulesets.Scoring;
using osu.Game.Scoring;
using osu.Game.Screens.Play;
using osu.Game.Tests.Visual;
using osuTK;
namespace osu.Game.Rulesets.Osu.Tests
{
2020-04-09 17:57:35 +00:00
public class TestSceneOutOfOrderHits : RateAdjustedBeatmapTestScene
2020-03-18 08:00:48 +00:00
{
private const double early_miss_window = 1000; // time after -1000 to -500 is considered a miss
private const double late_miss_window = 500; // time after +500 is considered a miss
2020-03-18 08:00:48 +00:00
/// <summary>
2020-03-30 08:01:29 +00:00
/// Tests clicking a future circle before the first circle's start time, while the first circle HAS NOT been judged.
2020-03-18 08:00:48 +00:00
/// </summary>
[Test]
public void TestClickSecondCircleBeforeFirstCircleTime()
{
const double time_first_circle = 1500;
const double time_second_circle = 1600;
2020-03-30 07:15:07 +00:00
Vector2 positionFirstCircle = Vector2.Zero;
Vector2 positionSecondCircle = new Vector2(80);
var hitObjects = new List<OsuHitObject>
{
new TestHitCircle
{
StartTime = time_first_circle,
2020-03-30 07:15:07 +00:00
Position = positionFirstCircle
},
new TestHitCircle
{
StartTime = time_second_circle,
2020-03-30 07:15:07 +00:00
Position = positionSecondCircle
}
};
performTest(hitObjects, new List<ReplayFrame>
2020-03-18 08:00:48 +00:00
{
2020-03-30 07:15:07 +00:00
new OsuReplayFrame { Time = time_first_circle - 100, Position = positionSecondCircle, Actions = { OsuAction.LeftButton } }
2020-03-18 08:00:48 +00:00
});
addJudgementAssert(hitObjects[0], HitResult.Miss);
addJudgementAssert(hitObjects[1], HitResult.Miss);
addJudgementOffsetAssert(hitObjects[0], late_miss_window);
2020-03-18 08:00:48 +00:00
}
/// <summary>
2020-03-30 08:01:29 +00:00
/// Tests clicking a future circle at the first circle's start time, while the first circle HAS NOT been judged.
2020-03-18 08:00:48 +00:00
/// </summary>
[Test]
public void TestClickSecondCircleAtFirstCircleTime()
{
const double time_first_circle = 1500;
const double time_second_circle = 1600;
2020-03-30 07:15:07 +00:00
Vector2 positionFirstCircle = Vector2.Zero;
Vector2 positionSecondCircle = new Vector2(80);
var hitObjects = new List<OsuHitObject>
{
new TestHitCircle
{
StartTime = time_first_circle,
2020-03-30 07:15:07 +00:00
Position = positionFirstCircle
},
new TestHitCircle
{
StartTime = time_second_circle,
2020-03-30 07:15:07 +00:00
Position = positionSecondCircle
}
};
performTest(hitObjects, new List<ReplayFrame>
2020-03-18 08:00:48 +00:00
{
2020-03-30 07:15:07 +00:00
new OsuReplayFrame { Time = time_first_circle, Position = positionSecondCircle, Actions = { OsuAction.LeftButton } }
2020-03-18 08:00:48 +00:00
});
addJudgementAssert(hitObjects[0], HitResult.Miss);
addJudgementAssert(hitObjects[1], HitResult.Great);
addJudgementOffsetAssert(hitObjects[0], 0);
2020-03-18 08:00:48 +00:00
}
/// <summary>
2020-03-30 08:01:29 +00:00
/// Tests clicking a future circle after the first circle's start time, while the first circle HAS NOT been judged.
2020-03-18 08:00:48 +00:00
/// </summary>
[Test]
public void TestClickSecondCircleAfterFirstCircleTime()
{
const double time_first_circle = 1500;
const double time_second_circle = 1600;
2020-03-30 07:15:07 +00:00
Vector2 positionFirstCircle = Vector2.Zero;
Vector2 positionSecondCircle = new Vector2(80);
var hitObjects = new List<OsuHitObject>
{
new TestHitCircle
{
StartTime = time_first_circle,
2020-03-30 07:15:07 +00:00
Position = positionFirstCircle
},
new TestHitCircle
{
StartTime = time_second_circle,
2020-03-30 07:15:07 +00:00
Position = positionSecondCircle
}
};
performTest(hitObjects, new List<ReplayFrame>
2020-03-18 08:00:48 +00:00
{
2020-03-30 07:15:07 +00:00
new OsuReplayFrame { Time = time_first_circle + 100, Position = positionSecondCircle, Actions = { OsuAction.LeftButton } }
2020-03-18 08:00:48 +00:00
});
addJudgementAssert(hitObjects[0], HitResult.Miss);
addJudgementAssert(hitObjects[1], HitResult.Great);
addJudgementOffsetAssert(hitObjects[0], 100);
2020-03-18 08:00:48 +00:00
}
/// <summary>
2020-03-30 08:01:29 +00:00
/// Tests clicking a future circle before the first circle's start time, while the first circle HAS been judged.
2020-03-18 08:00:48 +00:00
/// </summary>
[Test]
public void TestClickSecondCircleBeforeFirstCircleTimeWithFirstCircleJudged()
{
const double time_first_circle = 1500;
const double time_second_circle = 1600;
2020-03-30 07:15:07 +00:00
Vector2 positionFirstCircle = Vector2.Zero;
Vector2 positionSecondCircle = new Vector2(80);
var hitObjects = new List<OsuHitObject>
{
new TestHitCircle
{
StartTime = time_first_circle,
2020-03-30 07:15:07 +00:00
Position = positionFirstCircle
},
new TestHitCircle
{
StartTime = time_second_circle,
2020-03-30 07:15:07 +00:00
Position = positionSecondCircle
}
};
performTest(hitObjects, new List<ReplayFrame>
2020-03-18 08:00:48 +00:00
{
2020-03-30 07:15:07 +00:00
new OsuReplayFrame { Time = time_first_circle - 200, Position = positionFirstCircle, Actions = { OsuAction.LeftButton } },
new OsuReplayFrame { Time = time_first_circle - 100, Position = positionSecondCircle, Actions = { OsuAction.RightButton } }
2020-03-18 08:00:48 +00:00
});
addJudgementAssert(hitObjects[0], HitResult.Great);
addJudgementAssert(hitObjects[1], HitResult.Great);
addJudgementOffsetAssert(hitObjects[0], -200); // time_first_circle - 200
addJudgementOffsetAssert(hitObjects[0], -200); // time_second_circle - first_circle_time - 100
2020-03-18 08:00:48 +00:00
}
2020-03-30 08:01:29 +00:00
/// <summary>
/// Tests clicking a future circle after a slider's start time, but hitting all slider ticks.
/// </summary>
2020-03-30 07:15:07 +00:00
[Test]
public void TestMissSliderHeadAndHitAllSliderTicks()
{
const double time_slider = 1500;
const double time_circle = 1510;
Vector2 positionCircle = Vector2.Zero;
Vector2 positionSlider = new Vector2(80);
var hitObjects = new List<OsuHitObject>
{
new TestHitCircle
{
StartTime = time_circle,
Position = positionCircle
},
new TestSlider
{
StartTime = time_slider,
Position = positionSlider,
Path = new SliderPath(PathType.Linear, new[]
{
Vector2.Zero,
new Vector2(25, 0),
})
}
};
performTest(hitObjects, new List<ReplayFrame>
{
new OsuReplayFrame { Time = time_slider, Position = positionCircle, Actions = { OsuAction.LeftButton } },
new OsuReplayFrame { Time = time_slider + 10, Position = positionSlider, Actions = { OsuAction.RightButton } }
});
addJudgementAssert(hitObjects[0], HitResult.Great);
2020-09-29 09:29:50 +00:00
addJudgementAssert(hitObjects[1], HitResult.IgnoreHit);
2020-03-30 07:15:07 +00:00
addJudgementAssert("slider head", () => ((Slider)hitObjects[1]).HeadCircle, HitResult.Miss);
2020-09-29 09:29:50 +00:00
addJudgementAssert("slider tick", () => ((Slider)hitObjects[1]).NestedHitObjects[1] as SliderTick, HitResult.LargeTickHit);
2020-03-30 07:15:07 +00:00
}
2020-03-30 08:01:29 +00:00
/// <summary>
/// Tests clicking hitting future slider ticks before a circle.
/// </summary>
2020-03-30 07:15:07 +00:00
[Test]
public void TestHitSliderTicksBeforeCircle()
{
const double time_slider = 1500;
const double time_circle = 1510;
Vector2 positionCircle = Vector2.Zero;
Vector2 positionSlider = new Vector2(30);
2020-03-30 07:15:07 +00:00
var hitObjects = new List<OsuHitObject>
{
new TestHitCircle
{
StartTime = time_circle,
Position = positionCircle
},
new TestSlider
{
StartTime = time_slider,
Position = positionSlider,
Path = new SliderPath(PathType.Linear, new[]
{
Vector2.Zero,
new Vector2(25, 0),
})
}
};
performTest(hitObjects, new List<ReplayFrame>
{
new OsuReplayFrame { Time = time_slider, Position = positionSlider, Actions = { OsuAction.LeftButton } },
new OsuReplayFrame { Time = time_circle + late_miss_window - 100, Position = positionCircle, Actions = { OsuAction.RightButton } },
new OsuReplayFrame { Time = time_circle + late_miss_window - 90, Position = positionSlider, Actions = { OsuAction.LeftButton } },
});
addJudgementAssert(hitObjects[0], HitResult.Great);
2020-09-29 09:29:50 +00:00
addJudgementAssert(hitObjects[1], HitResult.IgnoreHit);
2020-03-30 07:15:07 +00:00
addJudgementAssert("slider head", () => ((Slider)hitObjects[1]).HeadCircle, HitResult.Great);
2020-09-29 09:29:50 +00:00
addJudgementAssert("slider tick", () => ((Slider)hitObjects[1]).NestedHitObjects[1] as SliderTick, HitResult.LargeTickHit);
2020-03-30 07:15:07 +00:00
}
2020-03-30 08:01:29 +00:00
/// <summary>
/// Tests clicking a future circle before a spinner.
/// </summary>
2020-03-30 07:15:07 +00:00
[Test]
public void TestHitCircleBeforeSpinner()
{
const double time_spinner = 1500;
2020-03-30 08:01:29 +00:00
const double time_circle = 1800;
2020-03-30 07:15:07 +00:00
Vector2 positionCircle = Vector2.Zero;
var hitObjects = new List<OsuHitObject>
{
new TestSpinner
{
StartTime = time_spinner,
Position = new Vector2(256, 192),
EndTime = time_spinner + 1000,
},
new TestHitCircle
{
StartTime = time_circle,
Position = positionCircle
},
};
performTest(hitObjects, new List<ReplayFrame>
{
2020-03-30 08:01:29 +00:00
new OsuReplayFrame { Time = time_spinner - 100, Position = positionCircle, Actions = { OsuAction.LeftButton } },
2020-03-30 07:15:07 +00:00
new OsuReplayFrame { Time = time_spinner + 10, Position = new Vector2(236, 192), Actions = { OsuAction.RightButton } },
new OsuReplayFrame { Time = time_spinner + 20, Position = new Vector2(256, 172), Actions = { OsuAction.RightButton } },
new OsuReplayFrame { Time = time_spinner + 30, Position = new Vector2(276, 192), Actions = { OsuAction.RightButton } },
new OsuReplayFrame { Time = time_spinner + 40, Position = new Vector2(256, 212), Actions = { OsuAction.RightButton } },
new OsuReplayFrame { Time = time_spinner + 50, Position = new Vector2(236, 192), Actions = { OsuAction.RightButton } },
});
addJudgementAssert(hitObjects[0], HitResult.Great);
addJudgementAssert(hitObjects[1], HitResult.Great);
}
2020-04-17 05:12:43 +00:00
[Test]
public void TestHitSliderHeadBeforeHitCircle()
{
const double time_circle = 1000;
const double time_slider = 1200;
Vector2 positionCircle = Vector2.Zero;
Vector2 positionSlider = new Vector2(80);
var hitObjects = new List<OsuHitObject>
{
new TestHitCircle
{
StartTime = time_circle,
Position = positionCircle
},
new TestSlider
{
StartTime = time_slider,
Position = positionSlider,
Path = new SliderPath(PathType.Linear, new[]
{
Vector2.Zero,
new Vector2(25, 0),
})
}
};
performTest(hitObjects, new List<ReplayFrame>
{
new OsuReplayFrame { Time = time_circle - 100, Position = positionSlider, Actions = { OsuAction.LeftButton } },
new OsuReplayFrame { Time = time_circle, Position = positionCircle, Actions = { OsuAction.RightButton } },
new OsuReplayFrame { Time = time_slider, Position = positionSlider, Actions = { OsuAction.LeftButton } },
});
addJudgementAssert(hitObjects[0], HitResult.Great);
2020-09-29 09:29:50 +00:00
addJudgementAssert(hitObjects[1], HitResult.IgnoreHit);
2020-04-17 05:12:43 +00:00
}
private void addJudgementAssert(OsuHitObject hitObject, HitResult result)
2020-03-18 08:00:48 +00:00
{
AddAssert($"({hitObject.GetType().ReadableName()} @ {hitObject.StartTime}) judgement is {result}",
() => judgementResults.Single(r => r.HitObject == hitObject).Type == result);
2020-03-18 08:00:48 +00:00
}
2020-03-30 07:15:07 +00:00
private void addJudgementAssert(string name, Func<OsuHitObject> hitObject, HitResult result)
{
AddAssert($"{name} judgement is {result}",
() => judgementResults.Single(r => r.HitObject == hitObject()).Type == result);
}
private void addJudgementOffsetAssert(OsuHitObject hitObject, double offset)
{
AddAssert($"({hitObject.GetType().ReadableName()} @ {hitObject.StartTime}) judged at {offset}",
() => Precision.AlmostEquals(judgementResults.Single(r => r.HitObject == hitObject).TimeOffset, offset, 100));
}
2020-03-18 08:00:48 +00:00
private ScoreAccessibleReplayPlayer currentPlayer;
private List<JudgementResult> judgementResults;
private void performTest(List<OsuHitObject> hitObjects, List<ReplayFrame> frames)
2020-03-18 08:00:48 +00:00
{
AddStep("load player", () =>
{
Beatmap.Value = CreateWorkingBeatmap(new Beatmap<OsuHitObject>
{
HitObjects = hitObjects,
2020-03-18 08:00:48 +00:00
BeatmapInfo =
{
BaseDifficulty = new BeatmapDifficulty { SliderTickRate = 3 },
Ruleset = new OsuRuleset().RulesetInfo
},
});
Beatmap.Value.Beatmap.ControlPointInfo.Add(0, new DifficultyControlPoint { SpeedMultiplier = 0.1f });
var p = new ScoreAccessibleReplayPlayer(new Score { Replay = new Replay { Frames = frames } });
p.OnLoadComplete += _ =>
{
p.ScoreProcessor.NewJudgement += result =>
{
if (currentPlayer == p) judgementResults.Add(result);
};
};
LoadScreen(currentPlayer = p);
judgementResults = new List<JudgementResult>();
});
AddUntilStep("Beatmap at 0", () => Beatmap.Value.Track.CurrentTime == 0);
AddUntilStep("Wait until player is loaded", () => currentPlayer.IsCurrentScreen());
AddUntilStep("Wait for completion", () => currentPlayer.ScoreProcessor.HasCompleted.Value);
2020-03-18 08:00:48 +00:00
}
private class TestHitCircle : HitCircle
{
protected override HitWindows CreateHitWindows() => new TestHitWindows();
}
2020-03-30 07:15:07 +00:00
private class TestSlider : Slider
{
public TestSlider()
{
2020-05-08 09:49:19 +00:00
DefaultsApplied += _ =>
2020-03-30 07:15:07 +00:00
{
HeadCircle.HitWindows = new TestHitWindows();
TailCircle.HitWindows = new TestHitWindows();
HeadCircle.HitWindows.SetDifficulty(0);
TailCircle.HitWindows.SetDifficulty(0);
2020-03-30 07:15:07 +00:00
};
}
}
private class TestSpinner : Spinner
{
protected override void ApplyDefaultsToSelf(ControlPointInfo controlPointInfo, BeatmapDifficulty difficulty)
{
base.ApplyDefaultsToSelf(controlPointInfo, difficulty);
SpinsRequired = 1;
}
}
2020-03-18 08:00:48 +00:00
private class TestHitWindows : HitWindows
{
private static readonly DifficultyRange[] ranges =
{
new DifficultyRange(HitResult.Great, 500, 500, 500),
new DifficultyRange(HitResult.Miss, early_miss_window, early_miss_window, early_miss_window),
2020-03-18 08:00:48 +00:00
};
public override bool IsHitResultAllowed(HitResult result) => result == HitResult.Great || result == HitResult.Miss;
protected override DifficultyRange[] GetRanges() => ranges;
}
private class ScoreAccessibleReplayPlayer : ReplayPlayer
{
public new ScoreProcessor ScoreProcessor => base.ScoreProcessor;
protected override bool PauseOnFocusLost => false;
public ScoreAccessibleReplayPlayer(Score score)
: base(score, false, false)
{
}
}
}
}