RepoMirrors/openssh
1
0
Fork 0
mirror of git://anongit.mindrot.org/openssh.git synced 2025-01-13 05:01:01 +00:00
Code Issues Packages Projects Releases Wiki Activity
9,826 Commits 69 Branches 157 Tags 27 MiB
c4ffb72593
Commit Graph

9826 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
djm@openbsd.org
c4ffb72593 upstream: fix some memleaks in test_helper code 
bz#3037 from Jitendra Sharma

OpenBSD-Regress-ID: 71440fa9186f5842a65ce9a27159385c6cb6f751
 2019-08-02 11:42:26 +10:00
djm@openbsd.org
6e76e69dc0 upstream: typo; from Christian Hesse 
OpenBSD-Commit-ID: 82f6de7438ea7ee5a14f44fdf5058ed57688fdc3
 2019-08-02 11:25:46 +10:00
djm@openbsd.org
49fa065a1b upstream: let sshbuf_find/cmp take a void* for the 
search/comparison argument, instead of a u_char*. Saves callers needing to
cast.

OpenBSD-Commit-ID: d63b69b7c5dd570963e682f758f5a47b825605ed
 2019-07-30 15:06:27 +10:00
mestre@openbsd.org
7adf6c430d upstream: When using a combination of a Yubikey+GnuPG+remote 
forwarding the gpg-agent (and options ControlMaster+RemoteForward in
ssh_config(5)) then the codepath taken will call mux_client_request_session
-> mm_send_fd -> sendmsg(2). Since sendmsg(2) is not allowed in that codepath
then pledge(2) kills the process.

The solution is to add "sendfd" to pledge(2), which is not too bad considering
a little bit later we reduce pledge(2) to only "stdio proc tty" in that
codepath.

Problem reported and diff provided by Timothy Brown <tbrown at freeshell.org>

OK deraadt@

OpenBSD-Commit-ID: 7ce38b6542bbec00e441595d0a178e970a9472ac
 2019-07-30 15:06:27 +10:00
dtucker@openbsd.org
0e2fe18acc upstream: Fix typo in CASignatureAlgorithms wherein what should be 
a comma is a dot. Patch from hnj2 via github pr#141.

OpenBSD-Commit-ID: 01f5a460438ff1af09aab483c0a70065309445f0
 2019-07-30 15:06:27 +10:00
Darren Tucker
e93ffd1a19 Report success of individual tests as well as all. 
This puts the "all tests passed" message back at the end where the
test harnesses can find it.
 2019-07-29 16:34:19 +10:00
Damien Miller
2ad5b36b18 convert to UTF-8; from Mike Frysinger 2019-07-29 09:49:23 +10:00
dtucker@openbsd.org
d31e7c937b upstream: Restrict limit-keytype to types supported by build. This 
means we have to skip a couple tests when only one key type is supported.

OpenBSD-Regress-ID: 22d05befb9c7ce21ce8dc22acf1ffe9e2ef2e95e
 2019-07-26 14:51:25 +10:00
Darren Tucker
0967a233b8 Remove override disabling DH-GEX. 
The DH-GEX override doesn't work when build without OpenSSL, and
we'll prefer curve25519 these days, removing the need for it.
 2019-07-25 20:11:45 +10:00
dtucker@openbsd.org
061407efc1 upstream: Only use supported key types during KRL test, preferring 
ed25519 since it's supported by both OpenSSL and non-OpenSSL builds.

OpenBSD-Regress-ID: 9f2bb3eadd50fcc8245b1bd8fd6f0e53602f71aa
 2019-07-25 20:09:06 +10:00
dtucker@openbsd.org
47f8ff1fa5 upstream: Switch keys-command test from rsa to ed25519 since it's 
supported for both OpenSSL and non-OpenSSL builds.

OpenBSD-Regress-ID: 174be4be876edd493e4a5c851e5bc579885e7a0a
 2019-07-25 20:01:19 +10:00
dtucker@openbsd.org
1e94afdfa8 upstream: Make certificate tests work with the supported key 
algorithms.  Allows tests to pass when built without OpenSSL.

OpenBSD-Regress-ID: 617169a6dd9d06db3697a449d9a26c284eca20fc
 2019-07-25 20:01:19 +10:00
dtucker@openbsd.org
26bf693661 upstream: Construct list of key types to test based on the types 
supported by the binaries.

OpenBSD-Regress-ID: fcbd115efacec8ab0ecbdb3faef79ac696cb1d62
 2019-07-24 16:51:17 +10:00
dtucker@openbsd.org
773c55b3d1 upstream: Only use DSA key type in tests if binaries support it. 
OpenBSD-Regress-ID: 770e31fe61dc33ed8eea9c04ce839b33ddb4dc96
 2019-07-24 16:47:58 +10:00
Darren Tucker
159e987a54 Split test targets further. 
Splits test into file-tests, t-exec, unit and interop-tests and their
respective dependencies.  Should allow running any set individually
without having to build the other dependencies that are not needed
for that specific test.
 2019-07-24 14:21:19 +10:00
Darren Tucker
520d4550a2 Add lib dependencies for regress binary targets. 2019-07-24 11:20:18 +10:00
Darren Tucker
4e8d0dd78d Make "unit" a dependency of "test". 2019-07-24 00:12:51 +10:00
Darren Tucker
4317b2a048 upstream rev 1.28: fix comment typo. 2019-07-23 23:24:47 +10:00
Darren Tucker
e0055af2bd Split regress-binaries into two targets. 
Split the binaries for the unit tests out into a regress-unit-binaries
target, and add a dependency on it for only the unit tests.  This allows
us to run the integration tests only ("make t-exec") without building
the unit tests, which allows us to run a subset of the tests when
building --without-openssl without trying (and failing) to build the
unit tests.

This means there are two targets for "unit" which I *think* is valid
(it works in testing, and makedepend will generate Makefiles of this
form)a but I could be wrong.
 2019-07-23 23:18:17 +10:00
dtucker@openbsd.org
7cdf9fdcf1 upstream: Skip DH group generation test if binaries don't support 
DH-GEX.

OpenBSD-Regress-ID: 7c918230d969ecf7656babd6191a74526bffbffd
 2019-07-23 22:51:22 +10:00
dtucker@openbsd.org
3a3eab8bb0 upstream: Only test conversion of key types supported by the 
binaries.

OpenBSD-Regress-ID: e3f0938a0a7407e2dfbb90abc3ec979ab6e8eeea
 2019-07-23 22:51:22 +10:00
dtucker@openbsd.org
7e66b7d98c upstream: Only add ssh-dss to allowed key types if it's supported 
by the binary.

OpenBSD-Regress-ID: 395a54cab16e9e4ece9aec047ab257954eebd413
 2019-07-23 22:51:22 +10:00
Darren Tucker
fd0684b319 Remove sys/cdefs.h include. 
It's not needed on -portable (that's handled by includes.h) and not all
platforms have it.
 2019-07-23 22:36:39 +10:00
Darren Tucker
9634ffbf29 Add headers to prevent warnings w/out OpenSSL. 2019-07-23 22:26:20 +10:00
Darren Tucker
2ea60312e1 Include stdlib.h for free() and calloc(). 2019-07-23 22:11:50 +10:00
Darren Tucker
11cba2a452 Re-apply portability changes to current sha2.{c,h}. 
Rather than attempt to apply 14 years' worth of changes to OpenBSD's sha2
I imported the current versions directly then re-applied the portability
changes.  This also allowed re-syncing digest-libc.c against upstream.
 2019-07-23 22:06:24 +10:00
Darren Tucker
09159594a3 Import current sha2.c and sha2.h from OpenBSD. 
These are not changed from their original state, the next commit will
re-apply the portable changes.
 2019-07-23 22:06:24 +10:00
Darren Tucker
2e6035b900 Rename valgrind "errors" to "failures". 
When valgrind is enabled, test-exec.sh counts the number of invocations
that valgrind detects failures in, not the total number of errors detected.
This makes the name to be more accurate.
 2019-07-23 08:11:22 +10:00
Darren Tucker
e82c9bb9ff Skip running sftp-chroot under Valgrind. 2019-07-20 22:14:46 +10:00
dtucker@openbsd.org
41e22c2e05 upstream: Remove the sleeps and thus races from the forwarding 
test.  They were originally required to work with Protocol 1, but now we can
use ssh -N and the control socket without the sleeps. While there, suppress
output fro the control exit commands.

OpenBSD-Regress-ID: 4c51a1d651242f12c90074c18c61008a74c1c790
 2019-07-20 22:13:40 +10:00
dtucker@openbsd.org
0423043c5e upstream: Allow SLEEPTIME to be overridden. 
OpenBSD-Regress-ID: 1596ab168729954be3d219933b2d01cc93687e76
 2019-07-20 22:12:24 +10:00
dtucker@openbsd.org
d466b6a5cf upstream: Move sleep time into a variable so that we can increase 
it for platforms or configurations that are much slower then usual.

OpenBSD-Regress-ID: 88586cabc800062c260d0b876bdcd4ca3f58a872
 2019-07-20 22:11:00 +10:00
djm@openbsd.org
b4a7c9d2b5 upstream: add regression tests for scp for out-of-destination path file 
creation by Harry Sintonen via Jakub Jelen in bz3007

OpenBSD-Regress-ID: 01ae5fbc6ce400b2df5a84dc3152a9e31f354c07
 2019-07-19 13:53:27 +10:00
djm@openbsd.org
bca0582063 upstream: Accept the verbose flag when searching for host keys in known 
hosts (i.e. "ssh-keygen -vF host") to print the matching host's random- art
signature too. bz#3003 "amusing, pretty" deraadt@

OpenBSD-Commit-ID: 686221a5447d6507f40a2ffba5393984d889891f
 2019-07-19 13:53:27 +10:00
Darren Tucker
5299a09fa2 Revert one dependency per line change. 
It turns out that having such a large number of lines in the .depend
file will cause the memory usage of awk during AC_SUBST to blow up on at
least NetBSD's awk, causing configure to fail.
 2019-07-19 13:52:41 +10:00
Damien Miller
01dddb231f fix SIGWINCH delivery of Solaris for mux sessions 
Remove PRIV_PROC_SESSION which was limiting ability to send SIGWINCH
signals to other sessions.  bz#3030; report and fix from Darren Moffat
 2019-07-19 13:22:16 +10:00
Darren Tucker
05500af21d Force dependencies one per line. 
Force makedepend to output one dependency per line, which will make
reading diffs against it much easier.  ok djm@
 2019-07-19 13:20:03 +10:00
Darren Tucker
b5bc5d016b make depend. 2019-07-19 13:18:07 +10:00
Darren Tucker
65333f7454 Show when skipping valgrind for a test. 2019-07-19 13:16:11 +10:00
Darren Tucker
fccb7eb343 Enable connect-privsep test with valgrind. 
connect-privsep seems to work OK with valgrind now so don't skip
valgrind on it.
 2019-07-19 10:41:56 +10:00
Darren Tucker
d742301726 Show valgrind results and error counts. 2019-07-19 07:43:07 +10:00
Darren Tucker
22b9b3e944 Fix format string integer type in error message. 2019-07-19 07:23:26 +10:00
djm@openbsd.org
ed46a0c070 upstream: fix off-by-one in sshbuf_dtob64() base64 wrapping that could 
cause extra newlines to be appended at the end of the base64 text (ugly, but
harmless). Found and fixed by Sebastian Kinne

OpenBSD-Commit-ID: 9fe290bd68f706ed8f986a7704ca5a2bd32d7b68
 2019-07-18 23:27:09 +10:00
Darren Tucker
a192021fed Fail tests if Valgrind enabled and reports errors. 
Also dump the failing valgrind report to stdout (not the cleanest
solution, but better than nothing).
 2019-07-18 11:09:38 +10:00
Darren Tucker
d1c491ecb9 Allow low-priv tests to write to pipe dir. 
When running regression tests with Valgrind and SUDO, the low-priv agent
tests need to be able to create pipes in the appropriate directory.
 2019-07-18 10:17:54 +10:00
Darren Tucker
8a5bb3e781 Put valgrind vgdb files to a specific directory. 
Valgrind by default puts vgdb files and pipes under /tmp, however it
is not always able to clean them up, which can cause test failures when
there's a pid/file collision.  Using a specific directory ensures that
we can clean up and start clean.
 2019-07-17 21:24:55 +10:00
djm@openbsd.org
f8829fe57f upstream: adapt to sshbuf_dtob64() change 
OpenBSD-Regress-ID: 82374a83edf0955fd1477169eee3f5d6467405a6
 2019-07-17 11:04:25 +10:00
dtucker@openbsd.org
1254fcbb2f upstream: Remove ssh1 files from CLEANFILES since ssh1 no longer 
supported.

OpenBSD-Regress-ID: 5b9ae869dc669bac05939b4a2fdf44ee067acfa0
 2019-07-17 11:04:25 +10:00
dtucker@openbsd.org
9dc81a5ada upstream: Update names of host key files in CLEANFILES to match 
recent changes to the tests.

OpenBSD-Regress-ID: 28743052de3acf70b06f18333561497cd47c4ecf
 2019-07-17 11:02:42 +10:00
Damien Miller
e44e4ad119 depend 2019-07-16 23:26:53 +10:00