Commit Graph

369 Commits

Author SHA1 Message Date
Rich Felker 5d0965cb56 eliminate OOB array hacks in malloc 2011-06-26 16:12:43 -04:00
Rich Felker e22c2d3ee6 use .type directives for math asm (needed for dynamic linking to work) 2011-06-26 15:52:37 -04:00
Rich Felker 32de61e81a fix some symbol resolution issues in dynamic linker
1. search was wrongly beginning with lib itself rather than dso head
2. inconsistent resolution of function pointers for functions in plt
2011-06-25 22:36:21 -04:00
Rich Felker 6250c0be4b wordexp cannot use we_offs unless WRDE_DOOFFS flag is set
previously, a potentially-indeterminate value from we_offs was being
used, resulting in wrong we_wordc and subsequent crashes in the
caller.
2011-06-25 18:54:33 -04:00
Rich Felker febbd12d00 XSI search.h API implementation by Szabolcs Nagy 2011-06-25 18:18:57 -04:00
Rich Felker 49388f3b7b handle library paths better (ignore empty path components, etc.) 2011-06-25 17:49:16 -04:00
Rich Felker 59633c736d fix possible (questionable) strict aliasing violations and ptr arith 2011-06-25 12:26:08 -04:00
Rich Felker 4d95a58524 const correctness in mq_notify
why did gcc allow this invalid assignment to compile in the first place?
2011-06-25 09:23:36 -04:00
Rich Felker 568b8075a4 proper path searching for dynamic linker
first, use $LD_LIBRARY_PATH unless suid. if that fails, read path from
/etc/ld-musl-$ARCH.path and fallback to a builtin default.
2011-06-25 01:56:34 -04:00
Rich Felker f937031800 optimize opendir using O_CLOEXEC 2011-06-25 01:38:25 -04:00
Rich Felker e8dbf00a78 discard dso descriptors after performing relocations
eventually (once dlopen exists) this behavior will be conditional on
dlopen/dlsym not being reachable.
2011-06-25 00:47:28 -04:00
Rich Felker 368ba4a0a9 keep track of which dsos have been relocated 2011-06-25 00:18:19 -04:00
Rich Felker b7f6e0c6f8 prepare support for LD_LIBRARY_PATH (checking suid/sgid safety)
the use of this test will be much stricter than glibc and other
typical implementations; the environment will not be honored
whatsoever unless the program is confirmed non-suid/sgid by the aux
vector the kernel passed in. no fallback to slow syscall-based
checking is used if the kernel fails to provide the information; we
simply assume the worst (suid) in this case and refuse to honor
environment.
2011-06-23 22:04:06 -04:00
Rich Felker c7ce1b20d2 initial commit of prng implementation by Szabolcs Nagy 2011-06-23 18:02:23 -04:00
Rich Felker d19adeec52 make ldso asm more uniform with rest of codebase (no unnecessary suffixes) 2011-06-19 22:42:10 -04:00
Rich Felker 779165e6d4 x86_64: ensure that dtor pointer passed to app is 0 so it won't be used
leaving it uninitialized caused unpredictable crashes or worse due to
calling an indeterminate function pointer.
2011-06-19 08:33:27 -04:00
Rich Felker 596d60c565 dynamic linker 64bit fix: hash table entries are always 32bit 2011-06-18 22:52:01 -04:00
Rich Felker 51e2d83102 experimental dynamic linker!
some notes:
- library search path is hard coded
- x86_64 code is untested and may not work
- dlopen/dlsym is not yet implemented
- relocations in read-only memory won't work
2011-06-18 19:48:42 -04:00
Rich Felker d43ff110bc fix memory leak on failure in realpath 2011-06-18 07:41:14 -04:00
Rich Felker 32aea2087a duplicate re_nsub in LSB/glibc ABI compatible location 2011-06-16 16:53:11 -04:00
Rich Felker c7d19f9923 restore use of .type in asm, but use modern @function (vs %function)
this seems to be necessary to make the linker accept the functions in
a shared library (perhaps to generate PLT entries?)

strictly speaking libc-internal asm should not need it. i might clean
that up later.
2011-06-14 23:15:08 -04:00
Rich Felker 7779dbd266 fix race condition in pthread_kill
if thread id was reused by the kernel between the time pthread_kill
read it from the userspace pthread_t object and the time of the tgkill
syscall, a signal could be sent to the wrong thread. the tgkill
syscall was supposed to prevent this race (versus the old tkill
syscall) but it can't; it can only help in the case where the tid is
reused in a different process, but not when the tid is reused in the
same process.

the only solution i can see is an extra lock to prevent threads from
exiting while another thread is trying to pthread_kill them. it should
be very very cheap in the non-contended case.
2011-06-14 01:35:51 -04:00
Rich Felker f58c8a0f39 run dtors before taking the exit-lock in pthread exit
previously a long-running dtor could cause pthread_detach to block.
2011-06-14 01:25:17 -04:00
Rich Felker 6232b96f51 minor locking optimizations 2011-06-14 01:23:42 -04:00
Rich Felker 0e1762539c avoid 64bit warnings when using pointers as entropy for temp names 2011-06-13 20:52:01 -04:00
Rich Felker f09e78de98 fix sigset macro for 64-bit systems (<< was overflowing due to wrong type) 2011-06-13 20:37:52 -04:00
Rich Felker 1e4f1cf154 remove all .size and .type directives for functions from the asm
these are useless and have caused problems for users trying to build
with non-gnu tools like tcc's assembler.
2011-06-13 20:28:14 -04:00
Rich Felker 76100a724e remove old useless timezone.s file (unused) 2011-06-13 20:21:21 -04:00
Rich Felker 73d2fde119 fix wrong type for wcsrchr argument 2 2011-06-13 14:06:04 -04:00
Rich Felker 773b0fe447 x86_64 fenv support (untested; at least known to build successfully) 2011-06-13 13:37:43 -04:00
Rich Felker 52cf24a0f4 fix fesetround - it was writing to status word instead of control word 2011-06-13 13:37:16 -04:00
Rich Felker b09b78905b floating point environment, untested
at present the i386 code does not support sse floating point, which is
not part of the standard i386 abi. while it may be desirable to
support it later, doing so will reduce performance and require some
tricks to probe if sse support is present.

this first commit is i386-only, but it should be trivial to port the
asm to x86_64.
2011-06-12 15:58:15 -04:00
Rich Felker 2afebbbcd1 malloc: cast size down to int in bin_index functions
even if size_t was 32-bit already, the fact that the value was
unsigned and that gcc is too stupid to figure out it would be positive
as a signed quantity (due to the immediately-prior arithmetic and
conditionals) results in gcc compiling the integer-to-float conversion
as zero extension to 64 bits followed by an "fildll" (64 bit)
instruction rather than a simple "fildl" (32 bit) instruction on x86.
reportedly fildll is very slow on certain p4-class machines; even if
not, the new code is slightly smaller.
2011-06-12 10:53:42 -04:00
Rich Felker 3825847243 another return value fix for mktemp... 2011-06-12 10:25:29 -04:00
Rich Felker c19a6be5a1 it's called getgrgid_r, not getgruid_r... 2011-06-08 16:47:08 -04:00
Rich Felker ecc0f5138d implement psignal and psiginfo 2011-06-08 16:41:44 -04:00
Rich Felker e1d2a8e239 mq names without leading / have impl-def behavior; allowing them is easier 2011-06-07 15:07:54 -04:00
Rich Felker 2b0cedac8d define MQ_PRIO_MAX 2011-06-07 15:05:04 -04:00
Rich Felker 86f8c72bb1 mq send/recv functions are cancellation points 2011-06-07 11:14:39 -04:00
Rich Felker ede353d8e5 implement mq_notify 2011-06-07 02:42:55 -04:00
Rich Felker ab11386aaa add support for POSIX message queues, except mq_notify 2011-06-07 01:52:27 -04:00
Rich Felker 71a80c5767 use volatile pointers for intentional-crash code. 2011-06-06 18:10:43 -04:00
Rich Felker da88b16a22 fix handling of d_name in struct dirent
basically there are 3 choices for how to implement this variable-size
string member:
1. C99 flexible array member: breaks using dirent.h with pre-C99 compiler.
2. old way: length-1 string: generates array bounds warnings in caller.
3. new way: length-NAME_MAX string. no problems, simplifies all code.

of course the usable part in the pointer returned by readdir might be
shorter than NAME_MAX+1 bytes, but that is allowed by the standard and
doesn't hurt anything.
2011-06-06 18:04:28 -04:00
Rich Felker 0dc99ac413 safety fix for glob's vla usage: disallow patterns longer than PATH_MAX
this actually inadvertently disallows some valid patterns with
redundant / or * characters, but it's better than allowing unbounded
vla allocation.

eventually i'll write code to move the pattern to the stack and
eliminate redundancy to ensure that it fits in PATH_MAX at the
beginning of glob. this would also allow it to be modified in place
for passing to fnmatch rather than copied at each level of recursion.
2011-06-05 19:29:52 -04:00
Rich Felker a6c399cf62 eliminate (harmless in this case) vla usage in fnmatch.c 2011-06-05 13:30:56 -04:00
Rich Felker ddd87b2f10 implement pthread_[sg]etconcurrency.
there is a resource limit of 0 bits to store the concurrency level
requested. thus any positive level exceeds a resource limit, resulting
in EAGAIN. :-)
2011-05-30 11:31:07 -04:00
Rich Felker 11c531e21d implement uselocale function (minimal) 2011-05-30 01:41:23 -04:00
Rich Felker 9a59faab3c add useless, obsolescent function ulimit 2011-05-29 14:09:03 -04:00
Rich Felker f48832ee15 fix backwards posix_spawn file action order 2011-05-29 12:58:02 -04:00
Rich Felker dd45edb5ff add accidentally-omitted file needed for posix_spawn file actions 2011-05-28 23:31:11 -04:00