Commit Graph

1213 Commits

Author SHA1 Message Date
Rich Felker
3b43d10faf fdopen should set errno when it fails due to invalid mode string 2012-06-17 20:34:04 -04:00
Rich Felker
57d5fff5f7 header file fixes: multiple include guard consistency and correctness
one file was reusing another file's macro name, and many had
inconsistent underscores and application of SYS prefix, etc.

patch by Szabolcs Nagy (nsz)
2012-06-15 21:52:53 -04:00
Rich Felker
1dd6eee692 direct syscall to open in __init_security needs O_LARGEFILE
it probably does not matter for /dev/null, but this should be done
consistently anyway.
2012-06-14 23:58:40 -04:00
Rich Felker
ad5a332c75 reorder exit code to defer stdio flush until after dtors
this is required in case dtors use stdio.

also remove the old comments; one was cruft from when the code used to
be using function pointers and conditional calls, and has little
motivation now that we're using weak symbols. the other was just
complaining about having to support dtors even though the cost was
made essentially zero in the non-use case by the way it's done here.
2012-06-14 08:36:06 -04:00
Rich Felker
de05a2ac22 revert one change in time.h; no evidence BSD_SOURCE should expose these.. 2012-06-13 14:46:11 -04:00
Rich Felker
cf254c32ec fix feature test macros in time.h
stime is not _XOPEN_SOURCE, and some functions were missing with
_BSD_SOURCE..
2012-06-13 14:43:16 -04:00
Rich Felker
23be72ae45 add timegm function (inverse of gmtime), nonstandard 2012-06-13 14:41:52 -04:00
Rich Felker
2169265ec6 add init_module/delete_module syscall wrappers
these are not exposed publicly in any header, but the few programs
that use them (modutils/kmod, etc.) are declaring the functions
themselves rather than making the syscalls directly, and it doesn't
really hurt to have them (same as the capset junk).
2012-06-13 11:49:22 -04:00
Rich Felker
fbffcee63d add (currently stubbed due to stubbed strverscmp) versionsort function
based on patch by Emil Renner Berthing, with minor changes to dirent.h
for LFS64 and organization of declarations

this code should work unmodified once a real strverscmp is added, but
I've been hesitant to add it because the GNU strverscmp behavior is
harmful in a lot of cases (for instance if you have numeric filenames
in hex). at some point I plan on trying to design a variant of the
algorithm that behaves better on a mix of filename styles.
2012-06-13 11:14:38 -04:00
Rich Felker
e361019c24 add deprecated capabilities functions
these were left in glibc for binary compatibility after the public
part of the interface was removed, and libcap kept using them (with
its own copy of the header files) rather than just making the syscalls
directly. might as well add them since they're so small...
2012-06-13 11:04:31 -04:00
Rich Felker
6343ac8f5a fix char signedness bug (arm-specific) in dynamic linker 2012-06-09 21:20:44 -04:00
Rich Felker
819006a88b add pthread_attr_setstack interface (and get)
i originally omitted these (optional, per POSIX) interfaces because i
considered them backwards implementation details. however, someone
later brought to my attention a fairly legitimate use case: allocating
thread stacks in memory that's setup for sharing and/or fast transfer
between CPU and GPU so that the thread can move data to a GPU directly
from automatic-storage buffers without having to go through additional
buffer copies.

perhaps there are other situations in which these interfaces are
useful too.
2012-06-09 19:53:29 -04:00
Rich Felker
f457b1cb0d fix scanning of "-0x" pseudo-hex float (must give negative zero) 2012-06-08 11:17:49 -04:00
Rich Felker
3d649468c7 fix signedness errors in stdint.h constant macros
the types of these expressions must match the integer promotions.
unsigned 8- and 16-bit values promote to signed int, not unsigned int.
2012-06-08 11:11:44 -04:00
Rich Felker
63d40196b9 fix %ls breakage in last printf fix
signedness issue kept %ls with no precision from working at all
2012-06-08 10:36:43 -04:00
Rich Felker
6e9ff6a4cf fix printf %ls with precision limit over-read issue
printf was not printing too many characters, but it was reading one
too many wchar_t elements from the input. this could lead to crashes
if running off the page, or spurious failure if the conversion of the
extra wchar_t resulted in EILSEQ.
2012-06-08 10:32:59 -04:00
Rich Felker
1429ce9ba2 fix sysinfo, try 2. it seems to work this time. 2012-06-07 23:06:04 -04:00
Rich Felker
e86b18a63e sysinfo struct was utter nonsense; no idea where it came from.
this broke the busybox "free" utility (memory reporting) and possibly
other things like uptime.
2012-06-07 22:58:19 -04:00
Rich Felker
31eaad4796 fix scanf bug reading literals after width-limited field
the field width limit was not being cleared before reading the
literal, causing spurious failures in scanf in cases like "%2d:"
scanning "00:".
2012-06-07 22:52:41 -04:00
Rich Felker
498a100d05 check for ld support of -Bsymbolic-functions; disable shared if not avail
this issue affects the last gpl2 version of binutils, which some
people are still using out of aversion to gpl3. musl requires
-Bsymbolic-functions because it's the only way to make a libc.so
that's able to operate prior to dynamic linking but that still behaves
correctly with respect to global vars that may be moved to the main
program via copy relocations.
2012-06-07 00:32:22 -04:00
Rich Felker
f1fd7577ba use -nostdlib in linker tests to avoid possible missing crt/lib issues 2012-06-07 00:27:34 -04:00
Rich Felker
67a0383d07 avoid linking main program in linker tests
it's possible that the user has provided a compiler that does not have
any libc to link to, so linking a main program is a bad idea. instead,
generate an empty shared library with no dependencies.
2012-06-07 00:23:58 -04:00
Rich Felker
0c5efde8d0 make configure try to disable stack protector
in theory we could support stack protector in the libc itself, and
users wanting to experiment with such usage could add
-fstack-protector to CFLAGS intentionally. but to avoid breakage in
the default case, override broken distro-patched gcc that forces stack
protector on.
2012-06-06 22:00:08 -04:00
Rich Felker
08f70a30c0 add configure check for gnu linker hash style setting
some broken distro-provided toolchains have modified gcc to produce
only "gnu hash" dynamic hash table by default. as this is unsupported
by musl, that results in a non-working libc.so. we detect and switch
this on in configure rather than hard-coding it in the Makefile
because it's not supported by old binutils versions, but that might
not even be relevant since old binutils versions already fail from
-Bsymbolic-functions being missing. at some point I may review whether
this should just go in the Makefile...
2012-06-06 20:45:52 -04:00
Rich Felker
6e0ad2277a make gcc wrapper rewrite link options rather than just extending them
this is not tested yet, but should work to get rid of unwanted
--hash-style=gnu hacks present in some distro-patched gcc versions.
2012-06-06 15:48:06 -04:00
Rich Felker
f7d15dcc54 treat failure of mprotect in map_library as a fatal load failure
the error will propagate up and be printed to the user at program
start time; at runtime, dlopen will just fail and leave a message for
dlerror.

previously, if mprotect failed, subsequent attempts to perform
relocations would crash the program. this was resulting in an
increasing number of false bug reports on grsec systems where rwx
permission is not possible in cases where users were wrongly
attempting to use non-PIC code in shared libraries. supporting that
usage is in theory possible, but the x86_64 toolchain does not even
support textrels, and the cost of keeping around the necessary
information to handle textrels without rwx permissions is
disproportionate to the benefit (which is essentially just supporting
broken library setups on grsec machines).

also, i unified the error-out code in map_library now that there are 3
places from which munmap might have to be called.
2012-06-06 11:21:28 -04:00
Rich Felker
908bed20cd fix ctype abi junk (pointer should point to 0 slot, not -128 slot) 2012-06-05 19:42:33 -04:00
Rich Felker
3b94daba71 _GNU_SOURCE is supposed to imply _LARGEFILE64_SOURCE
this is ugly and stupid, but now that the *64 symbol names exist, a
lot of broken GNU software detects them in configure, then either
breaks during build due to missing off64_t definition, or attempts to
compile without function declarations/prototypes. "fixing" it here is
easier than telling everyone to add yet another feature test macro to
their builds.
2012-06-04 08:03:56 -04:00
Rich Felker
bd45dc9446 release notes for 0.9.1 2012-06-03 16:31:45 -04:00
Rich Felker
278883d0e2 fix configure build/host/target terminology usage 2012-06-03 16:22:13 -04:00
Rich Felker
2557d0ba47 ensure that abort always works
Per POSIX, "The abort() function shall cause abnormal process
termination to occur, unless the signal SIGABRT is being caught and
the signal handler does not return."

If SIGABRT is blocked or if a signal handler is installed and does
return, abort is still required to cause abnormal program termination.
We cannot use a_crash() to do this, since a SIGILL handler could also
be installed (and might even longjmp out of the abort, not expecting
to be invoked from within abort), nor can we rely on resetting the
signal handler and re-raising the signal (this has race conditions in
multi-threaded programs). On the other hand, SIGKILL is a perfectly
safe, unblockable way to obtain abnormal program termination, and it
requires no ugly loop-and-retry logic.
2012-06-02 21:53:04 -04:00
Rich Felker
6a4b9472fb add some ugly aliases for LSB ABI compatibility
for some nonsensical reason, glibc's headers use inline functions that
redirect some of the standard functions to ugly nonstandard names (and
likewise for some of their nonstandard functions).
2012-06-02 21:20:21 -04:00
Rich Felker
13b3645c46 increase default thread stack size to 80k
I've been looking for data that would suggest a good default, and
since little has shown up, i'm doing this based on the limited data I
have. the value 80k is chosen to accommodate 64k of application data
(which happens to be the size of the buffer in git that made it crash
without a patch to call pthread_attr_setstacksize) plus the max stack
usage of most libc functions (with a few exceptions like crypt, which
will be fixed soon to avoid excessive stack usage, and [n]ftw, which
inherently uses a fair bit in recursive directory searching).

if further evidence emerges suggesting that the default should be
larger, I'll consider changing it again, but I'd like to avoid it
getting too large to avoid the issues of large commit charge and rapid
address space exhaustion on 32-bit machines.
2012-06-02 20:15:37 -04:00
Rich Felker
40bd1726b6 remove implementation-reserved bits when saving signal mask
this fix is necessary because a program could be started with some of
the implementation-reserved signals masked (e.g. due to exec having
been called from a signal handler, or from a non-musl program) and
then could obtain an invalid-to-use-later sigset_t as the old/saved
signal mask.
2012-06-02 20:04:27 -04:00
Rich Felker
1e597a3e9b remove no-longer-needed unblocking of signals in pthread_create
this action is now performed in pthread_self initialization; it must
be performed there in case the first call to pthread_create is from a
signal handler, in which case the old signal mask could be restored on
return from the signal.
2012-06-02 19:56:18 -04:00
Rich Felker
9372655e88 add LSB abi junk for ctype functions
this should be the last major fix needed to support running
glibc-linked conforming POSIX programs with musl in place of glibc, as
long as musl provides the features they need and they don't use
pthread cancellation (which is implemented as c++ exceptions in glibc,
and fundamentally incompatible with musl).
2012-06-02 17:49:14 -04:00
Rich Felker
d200bd727b declare environ in unistd.h when _GNU_SOURCE feature test macro is used
lots of broken programs expect this, and it's gotten to the point of
being a troubleshooting FAQ topic. best to just fix it.
2012-06-02 16:51:04 -04:00
Rich Felker
19e48c5531 use fistpll mnemonic instead of fistpq (more widely supported) on x86_64 too
this was fixed previously on i386 but the corresponding code on x86_64
was missed.
2012-06-02 16:48:22 -04:00
Rich Felker
9ea20dcbaa add LSB ABI __xstat, etc. junk 2012-05-31 23:32:09 -04:00
Rich Felker
a541297617 enable LARGEFILE64 aliases
these will NOT be used when compiling with -D_LARGEFILE64_SOURCE on
musl; instead, they exist in the hopes of eventually being able to run
some glibc-linked apps with musl sitting in place of glibc.

also remove the (apparently incorrect) fcntl alias.
2012-05-31 23:12:31 -04:00
Rich Felker
ed6717277c fix musl-gcc wrapper to work with -pie
linking the wrong crt1.o resulted in textrels and thus crashing
2012-05-30 21:19:32 -04:00
Rich Felker
a34b0465ba there is no such GNU function fpurge, only __fpurge.
no idea where I got the idea fpurge should exist...
2012-05-28 22:54:27 -04:00
Rich Felker
b63cab76ec add prototype for BSD/GNU stdio *_unlocked extension functions
also fix up distinction of what is GNU-only and what's GNU+BSD
2012-05-28 22:53:24 -04:00
Rich Felker
15c7af3e21 remove duplicate lfs64 cruft in stdio.h 2012-05-28 22:46:28 -04:00
nsz
b1cf11c090 math: fix nextafter definition in tgmath.h 2012-05-28 22:55:03 +02:00
Rich Felker
5c1909a8d2 add ldd and main program loading support to dynamic linker 2012-05-27 16:01:44 -04:00
Rich Felker
b94608ca10 cleanup dynamic linker start code cruft
two actual issues: one is that __dynlink no longer wants/needs a GOT
pointer argument, so the code to generate that argument can be
removed. the other issue was that in the i386 code, argc/argv were
being loaded into registers that would be call-clobbered, then copied
to preserved registers, rather than just being loaded into the proper
call-preserved registers to begin with.

this cleanup is in preparation for adding new dynamic linker
functionality (ability to explicitly invoke the dynamic linker to run
a program).
2012-05-27 14:49:55 -04:00
Rich Felker
054ba18599 fix overrun (n essentially ignored) in wcsncmp
bug report and solution by Richard Pennington
2012-05-26 18:04:17 -04:00
Rich Felker
6436b371af fix failure of mbsinit(0) (not UB; required to return nonzero)
issue reported by Richard Pennington; slightly simpler fix applied
2012-05-26 18:02:45 -04:00
Rich Felker
aefd0f69bd fix failure of strrchr(str, 0)
bug report and solution by Richard Pennington
2012-05-26 18:01:34 -04:00