RepoMirrors
/
mpv
mirror of https://github.com/mpv-player/mpv
1
0
Fork 0
Code Issues Releases Wiki Activity

player/scripting: remove outdated comment about posix_spawn 

The comment was added in e2ab6b7f35,
but posix_spawn usage was removed in 5309497727
to ensure CLOEXEC correctness.
This commit is contained in:
nanahi 2024-07-27 15:22:04 -04:00 committed by Kacper Michajłow
parent f8700c5a94
commit fc6aa2cc8a
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
player/scripting.c
View File

@ -436,9 +436,6 @@ static int load_run(struct mp_script_args *args)
mp_subprocess(args->log, &opts, &res); mp_subprocess(args->log, &opts, &res);
// Closing these will (probably) make the client exit, if it really died. // Closing these will (probably) make the client exit, if it really died.
// They _should_ be CLOEXEC, but are not, because
// posix_spawn_file_actions_adddup2() may not clear the CLOEXEC flag
// properly if by coincidence fd==src_fd.
close(fds[0]); close(fds[0]);
if (fds[1] >= 0) if (fds[1] >= 0)
close(fds[1]); close(fds[1]);