From fc6aa2cc8a80961fffa774134e398894ec239c66 Mon Sep 17 00:00:00 2001 From: nanahi <130121847+na-na-hi@users.noreply.github.com> Date: Sat, 27 Jul 2024 15:22:04 -0400 Subject: [PATCH] player/scripting: remove outdated comment about posix_spawn The comment was added in e2ab6b7f3567542a2a1b5aab053d513737e72878, but posix_spawn usage was removed in 5309497727debfe1b268f915c5a41bdbe93ad9de to ensure CLOEXEC correctness. --- player/scripting.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/player/scripting.c b/player/scripting.c index f2265d2a25..a33b618056 100644 --- a/player/scripting.c +++ b/player/scripting.c @@ -436,9 +436,6 @@ static int load_run(struct mp_script_args *args) mp_subprocess(args->log, &opts, &res); // Closing these will (probably) make the client exit, if it really died. - // They _should_ be CLOEXEC, but are not, because - // posix_spawn_file_actions_adddup2() may not clear the CLOEXEC flag - // properly if by coincidence fd==src_fd. close(fds[0]); if (fds[1] >= 0) close(fds[1]);