RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-04-27 05:18:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MEDIUM: mux-h1: Get the session from the H1S when capturing bad messages

Browse Source 
It is not guaranteed that the backend connection has an owner. It is set when
the connection is created. But when the connection is moved in a server idle
list, the connection owner is set to NULL and may never be set again. On the
other hand, when a mux is created or when a CS is attached, the session is
always defined. The H1 stream always keep a reference on it when it is
created. Thus, when a bad message is captured we should not rely on the
connection owner to retrieve the session. Instead we should get it from the H1
stream.
This commit is contained in:
Christopher Faulet 2020-10-15 17:19:46 +02:00
parent 2469eba20f
commit db2c17da60
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mux_h1.c
View File

@ -1079,7 +1079,7 @@ static void h1_show_error_snapshot(struct buffer *out, const struct error_snapsh
static void h1_capture_bad_message(struct h1c *h1c, struct h1s *h1s, static void h1_capture_bad_message(struct h1c *h1c, struct h1s *h1s,
struct h1m *h1m, struct buffer *buf) struct h1m *h1m, struct buffer *buf)
{ {
struct session *sess = h1c->conn->owner; struct session *sess = h1s->sess;
struct proxy *proxy = h1c->px; struct proxy *proxy = h1c->px;
struct proxy *other_end; struct proxy *other_end;
union error_snapshot_ctx ctx; union error_snapshot_ctx ctx;