RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-02-28 08:30:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MEDIUM: spoe: Unset variable instead of set it if no data provided

Browse Source 
If an agent try to set a variable with the NULL data type, an unset is perform
instead to avoid undefined behaviors. Once decoded, such data are translated to
a sample with the type SMP_T_ANY. It is unexpected in HAProxy. When a variable
is set with such sample, no data are attached to the variable. Thus, when the
variable is retrieved later in the transaction, the sample data are
uninitialized, leading to undefined behaviors depending on how it is used. For
instance, it leads to a crash if the debug converter is used on such variable.

This patch should fix the issue #855. It must be backported as far as 1.8.
This commit is contained in:
Christopher Faulet 2020-10-15 16:08:30 +02:00
parent 7239c24986
commit 2469eba20f
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/flt_spoe.c
View File

@ -2368,7 +2368,10 @@ spoe_decode_action_set_var(struct stream *s, struct spoe_context *ctx,
((struct spoe_config *)FLT_CONF(ctx->filter))->agent->var_pfx,
(int)sz, str);
spoe_set_var(ctx, scope, str, sz, &smp);
if (smp.data.type == SMP_T_ANY)
spoe_unset_var(ctx, scope, str, sz, &smp);
else
spoe_set_var(ctx, scope, str, sz, &smp);
ret = (p - *buf);
*buf = p;