RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2024-12-18 01:14:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

MINOR: hlua: ambiguous lua_pushvalue with 0 index

Browse Source 
In function hlua_applet_http_send_response(), a pushvalue
is performed with index '0'.

But according to lua doc (https://www.lua.org/manual/5.3/manual.html#4.3):
"Note that 0 is never an acceptable index".

Adding a FIXME comment near to the pushvalue operation
so that this can get some chance to be reviewed later.

No backport needed.
This commit is contained in:
Aurelien DARRAGON 2022-09-29 12:00:04 +02:00 committed by Christopher Faulet
parent 28f0a60a75
commit cd341d5314
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/hlua.c
View File

@ -5372,6 +5372,7 @@ __LJMP static int hlua_applet_http_send_response(lua_State *L)
sl->info.res.status = http_ctx->status; sl->info.res.status = http_ctx->status;
/* Get the array associated to the field "response" in the object AppletHTTP. */ /* Get the array associated to the field "response" in the object AppletHTTP. */
/* FIXME: according to Lua doc, 0 is considered to be invalid index? */
lua_pushvalue(L, 0); lua_pushvalue(L, 0);
if (lua_getfield(L, 1, "response") != LUA_TTABLE) { if (lua_getfield(L, 1, "response") != LUA_TTABLE) {
hlua_pusherror(L, "Lua applet http '%s': AppletHTTP['response'] missing.\n", hlua_pusherror(L, "Lua applet http '%s': AppletHTTP['response'] missing.\n",