From cd341d53146f8bc399b865dce1ec1426c76842fb Mon Sep 17 00:00:00 2001 From: Aurelien DARRAGON Date: Thu, 29 Sep 2022 12:00:04 +0200 Subject: [PATCH] MINOR: hlua: ambiguous lua_pushvalue with 0 index In function hlua_applet_http_send_response(), a pushvalue is performed with index '0'. But according to lua doc (https://www.lua.org/manual/5.3/manual.html#4.3): "Note that 0 is never an acceptable index". Adding a FIXME comment near to the pushvalue operation so that this can get some chance to be reviewed later. No backport needed. --- src/hlua.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/hlua.c b/src/hlua.c index a64dcec7d9..aff2099cf5 100644 --- a/src/hlua.c +++ b/src/hlua.c @@ -5372,6 +5372,7 @@ __LJMP static int hlua_applet_http_send_response(lua_State *L) sl->info.res.status = http_ctx->status; /* Get the array associated to the field "response" in the object AppletHTTP. */ + /* FIXME: according to Lua doc, 0 is considered to be invalid index? */ lua_pushvalue(L, 0); if (lua_getfield(L, 1, "response") != LUA_TTABLE) { hlua_pusherror(L, "Lua applet http '%s': AppletHTTP['response'] missing.\n",