RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-05-05 17:28:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MINOR: backend: check srv_conn before dereferencing it

Browse Source 
Commit 3c4e19f42 ("BUG/MEDIUM: backend: always release the previous
connection into its own target srv_list") introduced a valid warning
about a null-deref risk since we didn't check conn_new()'s return value.

This patch must be backported to 1.9 with the patch above.
This commit is contained in:
Willy Tarreau 2019-02-01 16:38:48 +01:00
parent 9c4f08ae39
commit 1da41ecf5b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/backend.c
View File

@ -1343,7 +1343,8 @@ int connect_server(struct stream *s)
/* no reuse or failed to reuse the connection above, pick a new one */ /* no reuse or failed to reuse the connection above, pick a new one */
if (!srv_conn) { if (!srv_conn) {
srv_conn = conn_new(); srv_conn = conn_new();
srv_conn->target = s->target; if (srv_conn)
srv_conn->target = s->target;
srv_cs = NULL; srv_cs = NULL;
} }