From 1da41ecf5bcf7cfd19baaa521cea23af6b4c8adb Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Fri, 1 Feb 2019 16:38:48 +0100 Subject: [PATCH] BUG/MINOR: backend: check srv_conn before dereferencing it Commit 3c4e19f42 ("BUG/MEDIUM: backend: always release the previous connection into its own target srv_list") introduced a valid warning about a null-deref risk since we didn't check conn_new()'s return value. This patch must be backported to 1.9 with the patch above. --- src/backend.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/backend.c b/src/backend.c index 4340ba58a..eac415447 100644 --- a/src/backend.c +++ b/src/backend.c @@ -1343,7 +1343,8 @@ int connect_server(struct stream *s) /* no reuse or failed to reuse the connection above, pick a new one */ if (!srv_conn) { srv_conn = conn_new(); - srv_conn->target = s->target; + if (srv_conn) + srv_conn->target = s->target; srv_cs = NULL; }