11f319727f
Merge pull request #543 from leseb/rm-debug
...
rgw/admin: remove Debug field from API type
2021-07-29 15:47:05 +05:30
9cae71ab54
rgw/admin: remove Debug field from API type
...
Instead of implementing our own logging let's the consumer implement
their own potential debug for each HTTP requests.
Closes: https://github.com/ceph/go-ceph/issues/508
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-07-27 18:21:53 +02:00
402707f2f5
rados: naming conventions: fixes in WriteFull function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-26 14:07:47 -04:00
b7b21273e3
rados: naming conventions: fixes in Write function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-26 14:07:47 -04:00
396e8f32ff
rados: naming conventions: fixes in Unlock function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-26 14:07:47 -04:00
e7cdc8fa68
rados: naming conventions: fixes in Truncate function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-26 14:07:47 -04:00
3a7c059e82
rados: naming conventions: fixes in Stat function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-26 14:07:47 -04:00
86d8bee873
rados: naming conventions: fixes in SetXattr function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-26 14:07:47 -04:00
c27c941bef
rados: naming conventions: fixes in SetNamespace function
...
Fix up variable names that don't meet Go standards.
Command: gofmt -w -r "c_ns -> cns" rados/ioctx.go
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-26 14:07:47 -04:00
f4a114fdd6
rados: naming conventions: fixes in RmXattr function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-26 14:07:47 -04:00
4dc59eed6a
rados: naming conventions: fixes in Read function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-26 14:07:47 -04:00
64bfa59378
rados: naming conventions: fixes in LockShared function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-26 14:07:47 -04:00
b3cdd63c76
rados: naming conventions: fixes in LockExclusive function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-26 14:07:47 -04:00
22b0d4636e
rados: naming conventions: fixes in ListXattrs function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-26 14:07:47 -04:00
9f1fdbbe9e
rados: naming conventions: fixes in ListObjects function
...
Fix up variable names that don't meet Go standards.
Command: gofmt -w -r "c_entry -> cEntry" rados/ioctx.go
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-26 14:07:47 -04:00
c45780d58d
rados: naming conventions: fixes in ListLockers function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-26 14:07:47 -04:00
1cb879d9e0
rados: naming conventions: fixes in GetXattr function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-26 14:07:47 -04:00
4307dc99ec
rados: naming conventions: fixes in GetPoolStats function
...
Fix up variable names that don't meet Go standards.
Command: gofmt -w -r "c_stat -> cStat" rados/ioctx.go
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-26 14:07:47 -04:00
aba1bfef37
rados: naming conventions: fixes in Delete function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-26 14:07:47 -04:00
35d991cf64
rados: naming conventions: fixes in BreakLock function
...
Fix up variable names that don't meet Go standards.
Command: gofmt -w -r "c_client -> cClient" rados/ioctx.go
Command: gofmt -w -r "c_cookie -> cCookie" rados/ioctx.go
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-26 14:07:47 -04:00
6485854703
rados: naming conventions: fixes in Append function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-26 14:07:47 -04:00
c15b97cf7c
rbd: add image encryption format api
...
Signed-off-by: Effi Ofer <effio@il.ibm.com>
2021-07-26 15:48:33 +00:00
1a18c07193
rgw/admin: un-export mock client
...
We don't need to export the mock, the consumer will generate its own.
What really matters is to have an interface that consumer can mock it
desired. Reference: https://github.com/golang/go/wiki/CodeReviewComments#interfaces
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-07-22 10:24:57 +00:00
401fbe9698
rgw/admin: remove unnecessary type
...
Now that we use http.Method* constant from the http package, we don't
need to have verbHTTP type anymore.
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-07-21 05:11:49 +00:00
42a9620c93
rgw/admin: add ability to mock HTTP Client
...
We can now use a mocked client to be consumed by unit tests as well as
various users of the API.
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-07-21 05:11:49 +00:00
53b3842e29
rgw/admin: add an interface around the HTTP Client
...
We now have a new interface `HTTPClient` which helps us doing various
operations such as mutating and mocking the HTTP Client.
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-07-21 05:11:49 +00:00
5da5db0b9c
devcontainer: add option to start ceph nodes for tests
2021-07-19 17:07:42 -04:00
7881ee6829
rgw/admin: use http verbs from the http package
...
The http package provides constants for common http methods so let's use
them.
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-07-13 14:42:54 +00:00
7f34da0592
cephfs: add test case for ReadConfigFile
...
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-13 13:53:48 +00:00
5b727cf7a0
cephfs: add ReadConfigFile implementing ceph_conf_read_file
...
Unlike ReadDefaultConfigFile, ReadConfigFile supports user specified
paths.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-13 13:53:48 +00:00
3add450741
cephfs: fix function doc comment for ReadDefaultConfigFile
...
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-13 13:53:48 +00:00
c009f6d19e
makefile: add a flag to run go commands via a container
...
By running `make USE_GOCO=1` the makefile will run go build, etc.
commands using _GO_ from a _COntainer_. This is inspired by recent work
to enable development containers for VSCode, but is more aimed at
vim/cli users like myself who want to compile the code via makefile
rules and make use of vim's quickfix feature without having to have ceph
libs or, more importantly, the right version of the ceph libs, locally.
Full example: `make build test-bins USE_CACHE=1 USE_GOCO=1`
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-08 10:36:19 -04:00
7abb5fd321
makefile: use variables for go and gofmt commands
...
There are use cases where the default go commands are not what you want,
including an upcoming change. This simply "variablizes" the makefile.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-07-08 10:36:19 -04:00
e0727d9cf7
rados: naming conventions: fix c_entry, c_namespace
...
Fix up variable names that don't meet Go standards.
Command: gofmt -w -r "c_entry -> cEntry" rados/object_iter.go
Command: gofmt -w -r "c_namespace -> cNamespace" rados/object_iter.go
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-06-28 13:51:01 -04:00
f25ee98e0a
rados: naming conventions: fix c_cluster_name, c_name
...
Fix up variable names that don't meet Go standards.
Command: gofmt -w -r "c_cluster_name -> cClusterName" rados/rados.go
Command: gofmt -w -r "c_name -> cName" rados/rados.go
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-06-28 13:51:01 -04:00
7f77d82bab
rados: naming conventions: c_user -> cUser
...
Fix up variable names that don't meet Go standards.
Command: gofmt -w -r "c_user -> cUser" rados/rados.go
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-06-28 13:51:01 -04:00
801a9cc498
rados: naming conventions: fix c_major, c_minor, c_patch
...
Fix up variable names that don't meet Go standards.
Command: gofmt -w -r "c_major -> cMajor" rados/rados.go
Command: gofmt -w -r "c_minor -> cMinor" rados/rados.go
Command: gofmt -w -r "c_patch -> cPatch" rados/rados.go
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-06-28 13:51:01 -04:00
4c12ff0fda
rados: naming conventions: c_stat -> cStat
...
Fix up variable names that don't meet Go standards.
Command: gofmt -w -r "c_stat -> cStat" rados/conn.go
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-06-28 13:51:01 -04:00
9619de1d84
rados: naming conventions: c_opt/c_val -> cOpt/cVal
...
Fix up variable names that don't meet Go standards.
Command: gofmt -w -r "c_opt -> cOpt" rados/conn.go
Command: gofmt -w -r "c_val -> cVal" rados/conn.go
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-06-28 13:51:01 -04:00
debaac7031
rados: naming conventions: c_id -> cid
...
Fix up variable names that don't meet Go standards.
Command: gofmt -w -r "c_id -> cid" rados/conn.go
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-06-28 13:51:01 -04:00
46c860c614
rados: naming conventions: c_pool -> cPool
...
Fix up variable names that don't meet Go standards.
Command: gofmt -w -r "c_pool -> cPool" rados/conn.go
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-06-28 13:51:01 -04:00
5cbf7c6514
rados: naming conventions: c_path -> cPath
...
Fix up variable names that don't meet Go standards.
Command: gofmt -w -r "c_path -> cPath" rados/conn.go
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-06-28 13:51:01 -04:00
d7f73e112d
rados: naming conventions: c_name -> cName
...
Fix up variable names that don't meet Go standards.
Command: gofmt -w -r "c_name -> cName" rados/conn.go
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-06-28 13:51:01 -04:00
cc08cab257
devcontainer: simplify and remove Dockerfile
...
Signed-off-by: Sven Anderson <sven@redhat.com>
2021-06-25 15:03:52 +02:00
4298c2bd0e
docs: add an initial development guide
...
OK, I may have been too wordy, but its a start.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-06-21 09:11:36 -04:00
ba2e8674de
readme: document v0.10.0 and the ceph versions it supports
...
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-06-14 11:21:14 -04:00
5cb1f79d74
tests: add USE_CACHE variable to enable go packages cache
...
If the make variable USE_CACHE is set, the test container will mount
the /go directory from a named volume that is reused in following
test runs, so that go dependencies don't have to be installed again.
Signed-off-by: Sven Anderson <sven@redhat.com>
2021-06-14 14:16:42 +00:00
5c49aab11e
rbd: add GetMirrorUUID function
...
* Add GetMirrorUUID implementing rbd_mirror_uuid_get
This function is be used to get the mirroring uuid for the pool.
Basic tests included.
Signed-off-by: RAJAT SINGH <rajasing@redhat.com>
2021-06-08 14:01:09 +00:00
24eeb9512c
rbd: add a MirrorImageGlobalStatusIter implementing rbd_mirror_image_global_status_list
...
This adds the function call in the style of an iterator, as the number
of mirrored images in the entire pool could be large. Tests are
included.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-06-08 12:20:53 +00:00
8179bd4437
rgw/admin: stop returning pointers
...
Since we are not passing a pointer, let's not return a pointer either.
Also, our use case fits well the non-returning pointer approach since
the content of the struct type is not expected to be modified.
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-06-07 12:23:46 -04:00
Jiffin Tony Thottan
Sébastien Han
John Mulligan
Effi Ofer
Sven Anderson
RAJAT SINGH