1adc3bac8b
workflows: simplify ci runs using new make targets
...
The new make targets allow us to share (mirror-enabled) ceph container
instances. Use this to test both non-ptrguard and prtguard test runs
while dropping the (now redundant) non-mirror-enabled ceph + tests
container run.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-31 17:51:58 +02:00
d535ef39de
cephfs: make statx test more robust
...
The TestStatxFieldsRootDir test was assuming that the nlink count
returned by statx would be exactly 2. Make the test more robust against
varying content the root dir of the volume might have by only asserting
that the nlink be 2 or more.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-31 17:51:58 +02:00
528893ce1d
cephfs: clean up symlink created in TestSymlink func
...
Add a defer to clean up the symlink created by the test.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-31 17:51:58 +02:00
83c0acf52c
docs: add a API stability document
...
Signed-off-by: Sven Anderson <sven@redhat.com>
2021-08-25 16:51:26 +00:00
cdbffdc229
makefile: expand test-multi-container into multiple test-containers-* rules
...
This change adds a whole family of test-containers-* rules. The role
meant to be used directly "test-containers-test" brings up the
required dependencies once, and will reuse them on subsequent runs.
The targets "test-containers-kill" and "test-containers-clean" will
remove just the ceph containers and all dependencies respectively.
The change may look big, and I did shorten some lines, thus lengthening
the makefile vertically, but the logic is basically the same as before.
One can continue using "test-multi-container" and it should behave
pretty much as before, but outside the CI when working on code or
testing things out using the more granular rules can help speed things
up.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-25 15:15:48 +00:00
58289e2547
entrypoint: add --mirror-state option
...
The --mirror-state option specifies a path to a file in which the script
will record the state of (rbd) mirroring. This can then later be reused
in order to skip the somewhat time consuming mirroring setup if the
statefile indicates mirroring is already functional.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-25 15:15:48 +00:00
615b122e49
rados: naming conventions: fixes in test func TestListAcrossNamespaces
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-23 15:28:00 +00:00
5506545be0
rados: naming conventions: fixes in test function TestSetNamespace
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-23 15:28:00 +00:00
35bcee9804
rados: naming conventions: fixes in test funcs TestObjectIterator*
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-23 15:28:00 +00:00
ef031dddcf
rados: naming conventions: fixes in test function TestGetPoolStats
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-23 15:28:00 +00:00
a15c91d711
rados: naming conventions: fixes in test function TestCreate
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-23 15:28:00 +00:00
b045c8b239
rados: naming conventions: fixes in test funcs TestGetPoolBy{Name,ID}
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-23 15:28:00 +00:00
810022af7b
rados: naming conventions: fixes in test function TestMakeDeletePool
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-23 15:28:00 +00:00
e3196e45e0
rados: naming conventions: fixes in test function TestGetClusterStats
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-23 15:28:00 +00:00
9d7d31d158
rados: naming conventions: fixes in test functions for config
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-23 15:28:00 +00:00
fcdd6fd657
rados: naming conventions: fixes in TestMonCommandWithInputBuffer
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-23 15:28:00 +00:00
e5a1f842e5
rbd: naming conventions: fixes in test function TestOpenImage
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-23 15:28:00 +00:00
ee3c7f3a80
rbd: naming conventions: fixes in test function TestReadAt
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-23 15:28:00 +00:00
e6941b1e27
rbd: naming conventions: fixes in test function TestIOReaderWriter
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-23 15:28:00 +00:00
d78d42972e
rbd: naming conventions: fixes in test function TestWriteSame
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-23 15:28:00 +00:00
c2e4cd5377
rbd: naming conventions: fixes in test function TestDeprecatedImageOpen
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-23 15:28:00 +00:00
067924a4cf
cephfs: naming conventions: fix names in cephfs permissions test
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-23 14:51:22 +00:00
7a542b786a
github: update mergify rules to handle API vs non-API PRs
...
This implements the policy first outlined in
https://github.com/ceph/go-ceph/discussions/549
In short: if a PR includes API changes (has the API label) then
either 2 reviews are required or 1 review plus 10 days must pass;
if a PR includes no API changes, then only 1 review is needed.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-23 10:14:21 -04:00
a32355cba2
rbd: implement binding for rbd_mirror_image_instance_id_list
...
This commit adds MirrorImageInstanceIDList and
MirrorImageInstanceIDIter with necessary helper functions
and tests.
Fixes : #483
Signed-off-by: Rakshith R <rar@redhat.com>
2021-08-23 06:39:51 +00:00
1d2ef78c2f
remove .travis.yml file
...
We haven't used tavis ci for more than a year. There's no reason to keep
this config yaml file around any longer.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-19 12:29:06 -04:00
882da262a3
cephfs: re-enabled the skipped test for cephfs
...
cephfs test was disabled because there was bug in ceph related to ftruncate
the ceph bug is resolved, so re-enabling the cephfs test
Closes: https://github.com/ceph/go-ceph/issues/439
Signed-off-by: parth-gr <paarora@redhat.com>
2021-08-12 18:47:26 +00:00
4f9322e9f1
rbd: add revive directives to ignore underscores in ImageInfo
...
These are public fields of a public type and changing them would be
a breaking change. Add revive comment directives to ignore them
so we can continue to have names in this struct that violate the
Go naming convention.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
8ea2109309
rbd: naming conventions: fixes in RemoveImage function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
ae97cd3e7d
rbd: naming conventions: fixes in CreateImage function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
6abfb039a4
rbd: naming conventions: fixes in TrashRemove, TrashRestore functions
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
e4cfae9eaa
rbd: naming conventions: fixes in SetSnapshot function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
1cbbe2cea5
rbd: naming conventions: fixes in GetSnapshotNames function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
d1b251fef5
rbd: naming conventions: fixes in BreakLock function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
8848df53e1
rbd: naming conventions: fixes in Unlock function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
70db71e0b6
rbd: naming conventions: fixes in LockExclusive, LockShared functions
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
05538bceab
rbd: naming conventions: fixes in ListLockers function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
96846c2ccf
rbd: naming conventions: fixes in Copy function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
2add913aaf
rbd: naming conventions: fixes in GetStripeCount, GetStripeUnit functions
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
ee7767a0d3
rbd: naming conventions: fixes in IsOldFormat function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
f4769e6f89
rbd: naming conventions: fixes in Stat function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
751c644eb5
rbd: naming conventions: fixes in Rename function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
07df8d3338
rbd: naming conventions: fixes in Trash function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
645fd2be49
rbd: naming conventions: fixes in Clone function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
3d2c476cd4
rbd: naming conventions: fixes in Create, Create2, Create3 functions
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
3a168ec717
rbd: naming conventions: fixes in Version function
...
Fix up variable names that don't meet Go standards.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
56af1b3822
rbd: fix naming convention violations in options.go
...
Fix up variable names that don't meet Go standards.
Command: gofmt -w -r 'c_set -> cSet' rbd/options.go
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
030411ac3f
rbd: fix naming convention violations in options.go
...
Fix up variable names that don't meet Go standards.
Command: gofmt -w -r 'c_value -> cValue' rbd/options.go
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
bf0ddeffa9
rbd: fix naming convention violations in snapshot.go
...
Fix up variable names that don't meet Go standards.
Command: gofmt -w -r 'c_is_protected -> cIsProtected' rbd/snapshot.go
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
7536a52346
rbd: fix naming convention violations in snapshot.go
...
Fix up variable names that don't meet Go standards.
Command: gofmt -w -r 'c_snapname -> cSnapName' rbd/snapshot.go
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
848b877686
rbd: fix naming convention violations in metadata.go
...
Fix up variable names that don't meet Go standards.
Command: gofmt -w -r 'c_key -> cKey' rbd/metadata.go
Command: gofmt -w -r 'c_value -> cValue' rbd/metadata.go
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2021-08-12 11:05:09 -04:00
John Mulligan
Sven Anderson
Rakshith R
parth-gr