Commit Graph

427 Commits

Author SHA1 Message Date
Dave Anderson
58fff92459 Fix for the extensions/trace.c extension module to account for
Linux 4.7 kernel commit 9b94a8fba501f38368aef6ac1b30e7335252a220,
which changed the ring_buffer_per_cpu.nr_pages member from an int
to a long.  Without the patch, the trace.so extension module fails
to load on big-endian machines, indicating "extend: Num of pages
is less than 0".
(feij.fnst@cn.fujitsu.com)
2017-04-15 13:45:13 -04:00
Dave Anderson
270d8b40a4 Fix for the "set scope" option if the kernel was configured with
CONFIG_RANDOMIZE_BASE.  Without the patch, the command fails with
the message "set: gdb cannot find text block for address: <symbol>".
This also affects extension modules that call gdb_set_crash_scope()
when running with KASLR kernels.
(anderson@redhat.com)
2017-04-10 14:01:41 -04:00
Dave Anderson
3bb49a5a95 Fix for the "dis" command to detect duplicate symbols in the case
of a "symbol+offset" argument where the duplicates are contiguous
in the symbol list.  In addition, reject "symbol+offset" arguments
if the resultant address goes beyond the end of the function.
(anderson@redhat.com)
2017-04-07 11:51:29 -04:00
Dave Anderson
eb1057eff0 Fix for the determination of the x86_64 "phys_base" value when it is
not passed in the VMCOREINFO data of ELF vmcores.  Without the patch,
it is possible that the base address of the vmalloc region is unknown
and initialized to an incorrect default address during the very early
stages of initialization, which causes the parsing of the PT_LOAD
segments for the START_KERNEL_map region to fail.
(anderson@redhat.com)
2017-04-06 13:13:04 -04:00
Dave Anderson
9578af8191 Provide basic Huge Page usage as part of "kmem -i" output, showing
the total amount of memory allocated for huge pages, and the amount
of the total that is free.
(atomlin@redhat.com)
2017-04-06 11:34:35 -04:00
Dave Anderson
a5ebe53b6b Fix for the "list -[hH]" options if a list_head.next pointer is
encountered that contains an invalid NULL pointer.  Without the
patch, the "list -[hH]" options would complete/continue as if the
NULL were a legitimate end-of-list indicator, and no error would be
reported.
(rabin.vincent@axis.com)
2017-03-31 13:40:02 -04:00
Dave Anderson
b204a20c66 Fix for a compilation error if glibc-2.25 or later has been installed
on the host build machine.  Without the patch, the build fails with
the error message "amd64-linux-nat.c:496:1: error: conflicting types
for 'ps_get_thread_area'".
(anderson@redhat.com)
2017-03-28 15:44:40 -04:00
Dave Anderson
ba176a49e1 Optimization of the "kmem -f <address>" and "kmem <address>" options
to signficantly reduce the amount of time to complete the buddy
allocator free-list scan for the target address.  On very large
memory systems, the patch may reduce the time spent by several orders
of magnitude.
(anderson@redhat.com)
2017-03-24 11:09:59 -04:00
Dave Anderson
0cb149ba43 Enhancement for the determination of the ARM64 "kimage_voffset" value
in Linux 4.6 and later kernels if an ELF format dumpfile does not
contain its value in a VMCOREINFO note, or when running against
live systems using /dev/mem, /proc/kcore, or an older version of
/dev/crash.
(liyueyi@live.com)
2017-03-20 11:20:59 -04:00
Dave Anderson
7c28f077d0 Fix for the "kmem <address>" option and the "search" command
in x86_64 kernels that contain, or have backports of, kernel commit
7c1da8d0d046174a4188b5729d7579abf3d29427, titled "crypto: sha - SHA1
transform x86_64 AVX2", which introduced an "_end" text symbol.
Without the patch, if a base kernel symbol address that is larger
than the "_end" text symbol is passed to "kmem <address>", its
symbol/filename information will not be displayed.  Also, when the
"search" command scans the __START_KERNEL_map region that contains
kernel text and static data, the search will be truncated to stop at
the "_end" text symbol address.
(anderson@redhat.com)
2017-03-17 12:14:20 -04:00
Dave Anderson
f4623a2f14 Implemented a new "log -a" option that dumps the audit logs remaining
in kernel audit buffers that have not been copied out to the
user-space audit daemon.
(d.hatayama@jp.fujitsu.com)
2017-03-15 11:53:35 -04:00
Dave Anderson
ed60e97e31 Linux 4.10 commit 401721ecd1dcb0a428aa5d6832ee05ffbdbffbbe finally
exports the x86_64 "phys_base" value in the VMCOREINFO note, so
utilize it whenever it exists.
(anderson@redhat.com)
2017-03-09 16:41:11 -05:00
Dave Anderson
ce0648294b Fix for the "mod -[sS]" option to prevent the erroneous reassignment
of one or more symbol values of a kernel module.  Without the patch,
when loading a kernel module, a message may indicate "mod: <module>:
last symbol: <symbol> is not _MODULE_END_<module>?" may be displayed,
and one or more symbols may be reassigned an incorrect symbol value.
If none of the erroneous symbol value reassignments are beyond the
end of the module's address space, then there will be no message.
(anderson@redhat.com)
2017-03-07 15:14:32 -05:00
Dave Anderson
a78535cf44 Fix for the PPC64 "mach -o" option to update the OPAL console buffer
size from 256K to 1MB, based upon the latest skiboot firmware source.
(ankit@linux.vnet.ibm.com)
2017-03-06 09:20:01 -05:00
Dave Anderson
5907614b2a Fixes to address three gcc-7.0.1 compiler warnings that are generated
when building with "make warn".  The warning types are "[-Wnonnull]"
in filesys.c, and "[-Wformat-overflow=]" in kernel.c and cmdline.c.
(anderson@redhat.com)
2017-03-03 15:10:02 -05:00
Dave Anderson
9221942f40 Mark start of 7.1.9 development with version 7.1.8++ 2017-03-03 15:08:30 -05:00
Dave Anderson
a80c0b1dfd crash-7.1.7 -> crash-7.1.8 2017-02-22 14:26:24 -05:00
Dave Anderson
c27dabf7f9 Removed -Werror from the bfd and opcode library builds.
(anderson@redhat.com)
2017-02-21 11:17:13 -05:00
Dave Anderson
e4fbec3d41 Allow the "--kaslr=<offset>" and/or "--kaslr=auto" command line
options to be used with the 32-bit X86 architecture.
(anderson@redhat.com)
2017-02-17 15:01:06 -05:00
Dave Anderson
fc9c517acd Fix for 32-bit X86 kernels to determine the active task in a dumpfile
in the situation where the task was running on its soft IRQ stack,
took a hard IRQ, and then the system crashed while it was running on
its hard IRQ stack.
(hirofumi@mail.parknet.co.jp)
2017-02-17 10:39:24 -05:00
Dave Anderson
e71102d356 Additional fix for Linux 3.15 and later 32-bit X86 kernels containing
kernel commit 198d208df4371734ac4728f69cb585c284d20a15, titled "x86:
Keep thread_info on thread stack in x86_32".  The patch fixes the
stack transition symbol from "handle_IRQ" to "handle_irq" for usage
by the "bt" command.
(anderson@redhat.com)
2017-02-16 09:37:51 -05:00
Dave Anderson
5959759058 Fix for Linux 3.15 and later 32-bit X86 kernels containing kernel
commit 198d208df4371734ac4728f69cb585c284d20a15, titled "x86: Keep
thread_info on thread stack in x86_32".  Without the patch, incorrect
addresses of each per-cpu hardirq_stack and softirq_stack were saved
for usage by the "bt" command.
(hirofumi@mail.parknet.co.jp, anderson@redhat.com)
2017-02-15 16:29:53 -05:00
Dave Anderson
345da6dc90 Remove two one-time warning messages that are displayed when running
the "bt" command on Linux 4.2 and later 32-bit X86 kernels.  Without
the patch, the first "bt" command that is executed will be preceded
by "bt: WARNING: "system_call" symbol does not exist", followed by
"bt: WARNING: neither "ret_from_sys_call" nor "syscall_badsys"
symbols exist".
(anderson@redhat.com)
2017-02-15 15:39:13 -05:00
Dave Anderson
8323490fd9 Another fix for a similar "bt: cannot resolve stack trace" warning
on a 32-bit X86 idle/swapper task, but when running on cpu 0.
(anderson@redhat.com)
2017-02-15 15:04:07 -05:00
Dave Anderson
63dd57685e Fix for an invalid "bt" warning on a 32-bit X86 idle (swapper) task.
Without the patch, the backtrace displays the "cannot resolve stack
trace" warning, dumps the backtrace, and then the text symbols:

  crash> bt
  PID: 0      TASK: f0962180  CPU: 6   COMMAND: "swapper/6"
  bt: cannot resolve stack trace:
   #0 [f095ff1c] __schedule at c0b6ef8d
   #1 [f095ff58] schedule at c0b6f4a9
   #2 [f095ff64] schedule_preempt_disabled at c0b6f728
   #3 [f095ff6c] cpu_startup_entry at c04b0310
   #4 [f095ff94] start_secondary at c04468c0
  bt: text symbols on stack:
      [f095ff1c] __schedule at c0b6ef8d
      [f095ff58] schedule at c0b6f4ae
      [f095ff64] schedule_preempt_disabled at c0b6f72d
      [f095ff6c] cpu_startup_entry at c04b0315
      [f095ff94] start_secondary at c04468c5
  crash>

The backtrace shown is actually correct.
(anderson@redhat.com)
2017-02-14 16:23:56 -05:00
Dave Anderson
ec1a9b967d Fix for a "[-Wmisleading-indentation]" compiler warning and the
associated bug that is generated by lkcd_x86_trace.c when building
32-bit X86 with "make warn" with gcc-6.3.1.
(anderson@redhat.com)
2017-02-14 15:23:01 -05:00
Dave Anderson
69b577e423 Fix for the "bt" command on Linux 4.9 and later 32-bit X86 kernels
containing kernel commit 0100301bfdf56a2a370c7157b5ab0fbf9313e1cd,
subject "sched/x86: Rewrite the switch_to() code".  Without the
patch, backtraces for inactive (sleeping) tasks fail with the message
"bt: invalid structure member offset: task_struct_thread_eip".
(anderson@redhat.com)
2017-02-14 14:25:37 -05:00
Dave Anderson
1a4af84dbd Introduction of a new PPC64-only "mach -o" option that dumps the OPAL
"Open Power Abstraction Layer" console buffer.
(ankit@linux.vnet.ibm.com)
2017-02-14 10:08:33 -05:00
Dave Anderson
222e784fb2 Fix for 32-bit X86 kernels configured with CONFIG_RANDOMIZE_BASE.
Without the patch, an invalid kernel PAGE_OFFSET value is calculated
and as a result the session fails during session initialization just
after the patching of the gdb minimal_symbol values message, showing
the warning message "WARNING: cannot read linux_banner string",
followed by "crash: /vmlinux and /dev/crash do not match!".  This
patch also adds a new "--machdep page_offset=<value>" option that
can be used if the CONFIG_PAGE_OFFSET value is not the default
address of 0xc0000000.
(anderson@redhat.com)
2017-02-10 15:07:58 -05:00
Dave Anderson
fe63125327 Fix for the "CURRENT" value displayed by the "timer -r" command.
Without the patch, if the target machine has been up for a long
enough time, an arithmetic overflow will occur and the time value
displayed will be incorrect.
(shane.seymour@hpe.com)
2017-02-07 15:06:59 -05:00
Dave Anderson
61f4e172fd Clarification in the display of CONFIG_SLUB object addresses that are displayed
by the "kmem" command when SLAB_RED_ZONE has been enabled in Linux 4.6 and later
kernels.  By default, CONFIG_SLUB object addresses that are displayed by the
"kmem" command will point to the SLAB_RED_ZONE padding inserted at the
beginning of the object.  As an alternative, a new "redzone" environment
variable has been addedd that can be toggled on or off.  If "set redzone off"
is entered, the object addresses will point to the address that gets returned
to the allocator.
(hirofumi@mail.parknet.co.jp, anderson@redhat.com)
2017-02-07 12:08:55 -05:00
Dave Anderson
9c49844316 Fix for the "trace.c" extension module. The kernel buffer referenced
by "max_tr_ring_buffer" is not available in all configurations of the
kernel so the unitialized max_tr_ring_buffer variable should not be
used.  A similar check existed previously before the recent rework of
the trace extension module to support multiple buffers.
(rabinv@axix.com)
2017-02-07 10:42:46 -05:00
Dave Anderson
880574406d Fix for the "tree -t radix", "irq", and "files -p" command options
in Linux 4.6 and later kernels due to upstream changes in the radix
tree facility.  Without the patch, the commands will fail with the
message "radix trees do not exist or have changed their format".
(hirofumi@mail.parknet.co.jp)
2017-02-02 16:15:39 -05:00
Dave Anderson
b5292a8b41 Fix the bracketing of the x86_64 FILL_PML4() macro.
(anderson@redhat.com)
2017-02-01 16:07:16 -05:00
Dave Anderson
02826c505b Fix for a possible segmentation violation when analyzing Linux 4.6
and earlier x86_64 kernels configured with CONFIG_RANDOMIZE_BASE.
A segmentation violation may occur during session initialization,
just after the patching of the gdb minimal_symbol values message,
depending upon the value of KERNEL_IMAGE_SIZE, which was variable
in the earlier KASLR kernels.  This patch sets the KERNEL_IMAGE_SIZE
default value to 1GB for those earlier kernels, and also adds a
new "--machdep kernel_image_size=<value>" option that can be
used to override the default KERNEL_IMAGE_SIZE value if necessary.
(anderson@redhat.com)
2017-01-31 15:43:20 -05:00
Dave Anderson
3db3d3992d Fix for the PPC64 "bt" command for non-panicking active tasks in
FADUMP-generated dumpfiles (Firmware Assisted Dump facility).
Without the patch, backtraces of those tasks may be of the form
"#0 [c0000000700b3a90] (null) at c0000000700b3b50  (unreliable)".
This patch uses and displays the ptregs register set saved in the
dumpfile header for the non-panicking active tasks.
(hbathini@linux.vnet.ibm.com)
2017-01-24 14:37:03 -05:00
Dave Anderson
651c824ffe Prevent the livepatch taint flag check during the system banner
display from generating a fatal session-killing error if relevant
kernel symbol names or data structures change in the future (again).
(anderson@redhat.com)
2017-01-19 14:15:50 -05:00
Dave Anderson
e37dd7852f Prepare for the kernel's "taint_flag.true" and "taint_flag.false"
member names to be changed to "c_true" and "c_false", which fixes
build problems when an out-of-tree module defines "true" or "false".
(anderson@redhat.com)
2017-01-17 14:15:11 -05:00
Dave Anderson
33c79e0ba7 Update to the module taint flags handling patch above to account for
the change in size of the module.taints flag from an int to a long,
while allowing for a kernel backport that keeps it as an int.
(anderson@redhat.com)
2017-01-17 10:36:19 -05:00
Dave Anderson
ad1a44f5d9 Fix for support of /proc/kcore as the live memory source in Linux 4.8
and later x86_64 kernels configured with CONFIG_RANDOMIZE_BASE, which
randomizes the unity-mapping PAGE_OFFSET value.  Without the patch,
the crash session fails during session initialization with the error
message "crash: seek error: kernel virtual address: <address>
type: page_offset_base".
(anderson@redhat.com)
2017-01-13 15:38:39 -05:00
Dave Anderson
24a696228c Fix for Linux 4.10 commit 7fd8329ba502ef76dd91db561c7aed696b2c7720
"taint/module: Clean up global and module taint flags handling".
Without the patch, when running against Linux 4.10-rc1 and later
kernels, the crash utility fails during session initialization with
the message "crash: invalid structure size: tnt".
(panand@redhat.com)
2017-01-05 14:55:18 -05:00
Dave Anderson
58225d5106 Fix for the ARM64 "bt" command in Linux 4.10 and later kernels that
are configured with CONFIG_THREAD_INFO_IN_TASK.  Without the patch,
the "bt" command will fail for active tasks in dumpfiles that were
generated by the kdump facility.
(takahiro.akashi@linaro.org)
2017-01-05 09:23:33 -05:00
Dave Anderson
b809cb7d9b For ARM64 dumpfiles with VMCOREINFO, verify the new "VA_BITS" number
against the calculated number.
(anderson@redhat.com)
2017-01-03 09:46:21 -05:00
Dave Anderson
ec02834f48 The 32-bit MIPS PGD_ORDER() macro expects __PGD_ORDER to be signed,
which it isn't now since the internal machdep->pagesize is unsigned.
Without this patch, module loading fails during initialization on a
kernel that has a page size of 16KB, with messages that indicate
"please wait... (gathering module symbol data)" followed by
"crash: invalid size request: 0  type: pgd page".
(rabinv@axis.com)
2016-12-05 13:55:22 -05:00
Dave Anderson
c7a6b862ca Fix for a segmentation violation during session inialization when
running against a 32-bit MIPS ELF kdump or compressed kdump if a
per-cpu NT_PRSTATUS note cannot be be gathered from the dumpfile
header.  Without the the patch, a segmentation violation occurs after
the message "WARNING: cannot find NT_PRSTATUS note for cpu: <number>"
is displayed.
(rabinv@axis.com)
2016-12-05 12:11:10 -05:00
Dave Anderson
3d41b666a5 Fix for the initialization-time loading of kernel module symbols
if the kernel crashed while running a module's initcall.  Without
the patch, the crash session fails during initialation with a message
similar to "crash: store_module_symbols_v2: total: 7 mcnt: 8".
(rabinv@axis.com)
2016-12-05 11:42:54 -05:00
Dave Anderson
59fbaf3e4b Fix for Linux 4.6 commit b03a017bebc403d40aa53a092e79b3020786537d,
which introduced the new slab management type OBJFREELIST_SLAB.
In this mode, the freelist can be an object, and if the slab is full,
there is no freelist.  On the next free, an object is recycled to be
used as the freelist but not cleaned-up.  This patch will go through
only known freed objects, and will prevent "kmem -S" errors that
indicate "invalid/corrupt freelist entry" on kernels configured
with CONFIG_SLAB.
(thgarnie@google.com)
2016-12-02 13:57:11 -05:00
Dave Anderson
01e6fa2073 Mark start of 7.1.8 development with version 7.1.7++ 2016-12-02 13:55:26 -05:00
Dave Anderson
9db1795ae0 crash-7.1.6 -> crash-7.1.7 2016-11-30 13:58:26 -05:00
Dave Anderson
e726a31519 Update of the sample memory_driver/crash.c /dev/crash kernel driver
to version 1.3, which adds support for Linux 4.6 and later ARM64
kernels, kernels configured with CONFIG_HARDENED_USERCOPY, and
S390X kernels use xlate_dev_mem_ptr() and unxlate_dev_mem_ptr()
instead of kmap() and kunmap().
(anderson@redhat.com)
2016-11-22 11:43:40 -05:00