This commit updates NetworkStack::create_worker() to a virtual
function to reduce type check redundancy.
Since calling a pure virtual function in a constructor method is
strictly prohibited, NetworkStack::create_worker() is currently
not implemented as a virtual function.
It requires duplicated type check with NetworkStack::create(),
making the code a little bit tricky.
Considering NetworkStack instances can only be instantiated
through NetworkStack::create(), this commit moves worker creation
out of its constructor to NetworkStack::create(), makes it a pure
virtual, and lets inherited classes implement it to remove the
type check redundancy. By making it a non-static, we can also
reduce unnecessary class member function exposure.
Signed-off-by: Insu Jang <insu_jang@tmax.co.kr>
mgr/dashboard: fix wrong import in iscsi unit test
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
* refs/pull/38364/head:
mds/CDir: make the data length as long as possible for each op
mds/CDir: correct the write_size
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
* refs/pull/38033/head:
client: do not use g_conf().get_val<>() in libcephfs
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
* refs/pull/37708/head:
qa/suites/fs: enable thrashing in multifs environment
qa/workunits/fs/snaps: allow tests to be run
qa/tasks/{kclient,ceph_fuse}: allow mounting
qa/tasks: allow per file system config setting
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
since GCC-9
> Using the types and functions in <filesystem> does not require linking
> with -lstdc++fs now.
see https://gcc.gnu.org/gcc-9/changes.html#libstdcxx
Signed-off-by: Kefu Chai <kchai@redhat.com>
mgr/dashboard: SSO not working after REST API versioning
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
mgr/dashboard: Use pipe instead of calling function within template wherever possible
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
mgr/dashboard: Allow managing iSCSI Initiator after removing from group
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
the crimson::net::Messenger interface was changed in
44585adc78 and
ff2c3b597d, so need to change the tests
accordingly.
Signed-off-by: Kefu Chai <kchai@redhat.com>
It may appear to be useful to track the sporadic test failures
observed on jenkins, not reproducible locally.
Previously it was disabled because the output could be too
large. But after the hexdump was improved to skip repeating bytes
the output will hopefully be much smaller.
Signed-off-by: Mykola Golub <mgolub@suse.com>
This function was missing initially and was added by two separate
commits [1][2]. We have to remove one of the two definitions.
This reverts commit c17c53f460.
[1] c17c53f460
[2] 074dd33c4f
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
This commit fixes Building wheel for cffi (setup.py) ... error:
c/_cffi_backend.c:15:10: fatal error: ffi.h: No such file or directory
some python packages do not offer precompiled binary packages for aarch64 on PyPI.
only happens on non-amd64 arches, so add [!amd64].
Signed-off-by: JiangYu <lnsyyj@hotmail.com>
this is modeling the seastar::with_lock() method with the exception
that obc is also captured in the finally block.
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
rgw: avoid expiration early triggering caused by overflow
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
