Commit Graph

133773 Commits

Author SHA1 Message Date
Adam King
f577d1117d doc/cephadm: document recommended syntax for mounting files with ECA
Mounting files with extra container args seems to not
work with some of the more intuitive syntaxes.
See https://tracker.ceph.com/issues/57338

Signed-off-by: Adam King <adking@redhat.com>
2022-09-12 15:19:18 -04:00
Adam King
0320c67351
Merge pull request #48007 from adk3798/fix-staggered-pacific-version
doc/cephadm: correct version staggered upgrade got in pacific

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2022-09-12 15:06:33 -04:00
Guillaume Abrioux
a651a5152f
Merge pull request #46344 from mjenglish/ceph-volume-multiple-actuator
ceph-volume/ceph_volume/util: ceph-volume multi-actuator drive attribute
2022-09-12 20:58:41 +02:00
Soumya Koduri
e9b87fb943
Merge pull request #47970 from soumyakoduri/wip-skoduri-coverity
rgw/dbstore: Fix coverity issues #1510412, #1511420

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2022-09-12 22:51:54 +05:30
Nizamudeen A
6ef176b674
Merge pull request #47976 from rhcs-dashboard/fix-duplicate-snapshot
mgr/dashboard: fix snapshot creation with duplicate name

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-09-12 11:22:40 +05:30
Soumya Koduri
86cf43728d rgw/dbstore: Fix coverity issues #1510412, #1511420
Fixes: https://tracker.ceph.com/issues/57322
Fixes: https://tracker.ceph.com/issues/57325

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
2022-09-12 10:41:21 +05:30
Nizamudeen A
c49b81c7d6
Merge pull request #48032 from rhcs-dashboard/openapi-check-fix
mgr/dashboard: fix openapi-check

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2022-09-10 12:49:28 +05:30
Pere Diaz Bou
9673ed1869 mgr/dashboard: docs gen tags sort
When generating tags the order of endpoints wasn't taken into account.
Two endpoints with the same url prefix, for example `/api/cluster/` and
`/api/cluster/user`, have different docs and the tags is generated from
a doc of one of these two, and since the order of these endpoints might
vary it is imperative to sort them to have a deterministic output.

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-09-09 22:43:01 +02:00
Neha Ojha
b81ece50ae
Merge pull request #47770 from rzarzynski/wip-doc-dups-trimming-relnotes
PendingReleaseNotes: document online and offline trimming of PG Log's…

Reviewed-By: Neha Ojha <nojha@redhat.com>
2022-09-09 10:00:41 -07:00
Nizamudeen A
d84a03e989
Merge pull request #47700 from s0nea/wip-rgw-overview-labels
monitoring/ceph-mixin: add RGW host to label info

Reviewed-by: MrFreezeex <NOT@FOUND>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-09-09 17:36:40 +05:30
Nizamudeen A
0a60e89992
Merge pull request #47784 from rhcs-dashboard/ingress-unmanaged
mgr/dashboard: fix unmanaged service creation

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2022-09-09 10:44:35 +05:30
Nizamudeen A
84f4e123be
Merge pull request #47959 from rhcs-dashboard/service-id-filter-undefined
mgr/dashboard: fix Cannot read properties of undefined (reading 'filter')

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-09-09 09:27:14 +05:30
Ilya Dryomov
f4bb197f3e
Merge pull request #48014 from idryomov/wip-57116-cont
test/{librbd, rgw}: increase delay between and number of bind attempts

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
2022-09-08 20:52:28 +02:00
Daniel Gryniewicz
0cdd0c47bc
Merge pull request #48003 from dang/wip-dang-zipper-admin-api
RGW - Zipper - Allow per-store admin APIs

Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-09-08 14:36:46 -04:00
Ilya Dryomov
5855c7890f
Merge pull request #48009 from ljflores/wip-install-deps-focal-bionic
install-deps.sh: fix install-deps script for focal and bionic

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-09-08 20:05:15 +02:00
Daniel Gryniewicz
70c6cac4e6 RGW - Zipper - Allow per-store admin APIs
Some of the existing admin APIs are rados-specific, and other stores
will want to add specific APIs.  Allow this by having a function to add
store-specific APIs.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2022-09-08 12:38:57 -04:00
Radoslaw Zarzynski
dbfb50453c PendingReleaseNotes: document online and offline trimming of PG Log's dups
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-09-08 15:35:38 +00:00
Ilya Dryomov
48016eaa15 test/{librbd, rgw}: increase delay between and number of bind attempts
Commit aa7885f7cc ("test/{librbd, rgw}: retry when bind fail with
port 0") reduced the frequency of sporadic unit test failures caused
by EADDRINUSE a lot, but not entirely.

Currently, it yields a cumulative sleep of ~9 seconds.  Let's increase
that to 1 minute.

Fixes: https://tracker.ceph.com/issues/57116
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-09-08 11:46:58 +02:00
Yuval Lifshitz
72f8cfadb3
Merge pull request #47274 from faithuniterh/Golang-Notification-creation
examples/golang : Add put notification creation golang example code

reviewed-by: yuvalif
2022-09-08 12:31:24 +03:00
Nizamudeen A
165de92cc1
Merge pull request #46757 from nSedrickm/navigation-component-accessibility-update
mgr/dashboard: Improve accessibility for navigation components

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-09-08 09:41:29 +05:30
Laura Flores
0d2a5f3466 install-deps.sh: fix install-deps script for focal and bionic
When run on focal and bionic, install-deps ends early
due to this extra debug message that was added to the
end of `ensure_decent_gcc_on_ubuntu`. The debug message
prints when the script is run in a jenkins environment.

When the script is not run in a jenkins environment, the
value returned there is "false" or "0", which acts as
an early return. This stops the script from completing.

We can remove this line, as `ensure_decent_gcc_on_ubuntu`
is only called for focal and bionic, and most of the jenkins
nodes are running jammy. Also, there is a debug message at the
beginning of the function that should suffice.

Fixes: https://tracker.ceph.com/issues/57466
Signed-off-by: Laura Flores <lflores@redhat.com>
2022-09-07 19:45:57 +00:00
Adam King
91befb14d5 doc/cephadm: correct version staggered upgrade got in pacific
This didn't end up making 16.2.10 so the first version
it will actually be available is 16.2.11

Signed-off-by: Adam King <adking@redhat.com>
2022-09-07 15:19:02 -04:00
Yuval Lifshitz
e85e121747
Merge pull request #47091 from faithuniterh/Golang-Topic-creation
Topic creation example and sorting Golang examples into different folders

reviewed-by: anthonyeleven, yuvalif
2022-09-07 21:15:52 +03:00
Yuval Lifshitz
10fd49e073
Merge pull request #47864 from yuvalif/wip-yuval-fix-53186
rgw/notifications: add region to bucket ARN

reviewed-by: mattbenjamin, nthonyeleven
2022-09-07 21:09:16 +03:00
Casey Bodley
e82d5994fb
Merge pull request #47924 from tchaikov/wip-57355
denc: support non-c++20 compliant C++ standard library

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-09-07 12:53:36 -04:00
J. Eric Ivancich
558df7c10b
Merge pull request #47935 from ivancich/wip-simplify-bucket-listing-logging
rgw: simplify bucket listing logging

Reviewed-by: Ali Maredia <amaredia@redhat.com>
2022-09-07 11:30:21 -04:00
Laura Flores
934e487a91
Merge pull request #47741 from ljflores/wip-python3-fix
do_cmake.sh: build with python3.10 on ubuntu version >= 22.0
2022-09-07 10:11:08 -05:00
Pere Diaz Bou
521caba4f3
Merge pull request #47857 from nSedrickm/duplicate-id-accessibility-update
mgr/dashboard: remove duplicate ids from table column filters

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-09-07 16:56:08 +02:00
Aashish Sharma
2ae1bca1d9 mgr/dashboard: fix snapshot creation with duplicate name
Snapshot creation with same name on UI throwing 500 Internal Error, This PR intends to fix this issue.

Fixes: https://tracker.ceph.com/issues/57456
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2022-09-07 17:06:52 +05:30
Yingxin
815125eaad
Merge pull request #47981 from myoungwon/wip-rbm-cleanup2
crimson/os/seastore: RBM cleanups (mkfs, open, unittest)

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-09-07 18:54:27 +08:00
Pere Diaz Bou
a1719ab4f2
Merge pull request #47054 from nSedrickm/grafana-component-accessibility-update
mgr/dashboard: Improve level A accessibility for grafana component

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
2022-09-07 10:30:00 +02:00
myoungwon oh
594f1a360b crimson/os/seastore/rbm: use RBMDevice::size instead of TestMemory::size in TestMemory
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-09-07 14:58:48 +09:00
myoungwon oh
c4d2314058 crimson/os/seastore/rbm: force to make rbm superblock when mkfs is called
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-09-07 14:58:40 +09:00
myoungwon oh
2c13b1a58c crimson/os/seastore/rbm: call device.open() before rbm.open() or rbm.mkfs()
This commit also deletes open_device() in rbn.open()

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-09-07 14:58:33 +09:00
myoungwon oh
52e0c81f06 test/crimson/seastore: fix randomblockmanager test
1. remove transaction manager initialization in rbm test
2. do not call check_bitmap_blocks directly and use close() and open()
because open() invokes it internally

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-09-07 14:58:23 +09:00
Ilya Dryomov
7c73866e7d
Merge pull request #47987 from idryomov/wip-52810
librbd: retry ENOENT in V2_REFRESH_PARENT as well

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
2022-09-06 20:17:15 +02:00
Casey Bodley
d465f17d38
Merge pull request #47783 from soumyakoduri/wip-skoduri-sync-flow
radosgw-admin: fix crash with 'sync flow' cmd without 'flow-type'

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
2022-09-06 12:29:53 -04:00
Yuri Weinstein
747d1d39bb
Merge pull request #45883 from ifed01/wip-ifed-fix-bluefs-truncate
os/bluestore: fix no metadata update on truncate+fsync 

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
2022-09-06 09:12:29 -07:00
Sridhar Seshasayee
b6e36cb4a9
Merge pull request #47630 from sseshasa/wip-add-mclk-cpu-util-rel-note
PendingReleaseNotes: Note the fix for high CPU utilization during recovery

Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-09-06 20:45:02 +05:30
Tatjana Dehler
15fa97d49d
monitoring/ceph-mixin: add RGW host to label info
Add the missing information about the RGW instance to the labels of the
"Average GET/PUT Latencies" panel on the "RGW Overview" dashboard.

Fixes: https://tracker.ceph.com/issues/57166
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
2022-09-06 16:19:19 +02:00
Daniel Gryniewicz
1d08d8c124
Merge pull request #47908 from dang/wip-dang-zipper-cleanup
RGW - Sal - remove unused default constructors

Reviewed-by: Casey Bodley <cbodley@redat.com>
2022-09-06 09:48:49 -04:00
Casey Bodley
0676cabb31
Merge pull request #47907 from cbodley/wip-57195
rgw: fix d3n crash in StoreManager::get_config()

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Mark Kogan <mkogan@redhat.com>
2022-09-06 07:52:34 -04:00
nsedrickm
05c1b776c2 mgr/dashboard: add cypress e2e accessibility tests for navigation
* Add cypress e2e accessibility tests
* Log accessibility violations to console for quick debugging
* Disable retries to avoid duplicate logs

Signed-off-by: nsedrickm <nsedrick101@gmail.com>
2022-09-06 07:37:09 +01:00
nsedrickm
d84c827879 mgr/dashboard: Improve accessibility for navigation components
* Fix all dropdown accessibility issues by setting their roles as buttons
* Increase navlink font-size to 16px
* Add new primary color variable $primary-wcag-aa-large-text: #25828e  to meet WCAG level AA color contrast ratio for active navlink backgrounds

Fixes: https://tracker.ceph.com/issues/56021
Signed-off-by: nsedrickm <nsedrick101@gmail.com>
2022-09-06 07:37:09 +01:00
Kefu Chai
bd8b7aa4da
Merge pull request #46823 from lightmelodies/librados-c-api-stat2
librados: export stat2 in C API

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-09-06 08:40:46 +08:00
Kefu Chai
1217c9eb98
Merge pull request #47962 from tchaikov/wip-3rd-time-is-a-charm
test/{librbd, rgw}: retry when bind fail with port 0

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-09-06 08:37:45 +08:00
Ilya Dryomov
36f1d515ca librbd: make RefreshRequest tests compatible with clone v1
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-09-05 23:02:39 +02:00
Ilya Dryomov
bd885d75b2 librbd: retry ENOENT in V2_REFRESH_PARENT as well
With auto-deletion of trashed snapshots, it is relatively easy to lose
a race to "rbd flatten" as follows:

- when V2_GET_PARENT runs, the image is technically still a clone
- when V2_REFRESH_PARENT runs, the image is fully flattened and the
  snapshot in the parent image is deleted

This results in a spurious ENOENT error, mainly when trying to open the
image (e.g. for "rbd info").  This race condition has always been there
but auto-deletion of trashed snapshots makes it much worse.

Retry ENOENT in V2_REFRESH_PARENT the same way as in V2_GET_SNAPSHOTS.

Fixes: https://tracker.ceph.com/issues/52810
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-09-05 23:02:39 +02:00
Ilya Dryomov
8570194b13 librbd: limit the number of ENOENT retries in RefreshRequest
If the image header is corrupt, ENOENT error may be persistent.  Avoid
an infinite loop in that case.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-09-05 23:02:39 +02:00
Ilya Dryomov
6bd89ea119 librbd: fix a bunch of issues with restarting RefreshRequest
Make RefreshRequest properly restartable, at least up until and including
V2_REFRESH_PARENT step:

- clear m_migration_spec when skipping GET_MIGRATION_HEADER
- don't rely on potentially stale m_incomplete_update on retry
- reset m_legacy_parent when retrying more than just V2_GET_PARENT
- don't rely on potentially stale m_parent_md.overlap and
  m_head_parent_overlap on retry
- clear m_metadata before fetching image metadata (but not before
  fetching pool metadata)
- clear m_op_features when skipping V2_GET_OP_FEATURES
- clear m_group_spec on EOPNOTSUPP error in V2_GET_GROUP
- reset m_legacy_snapshot when retrying more than just V2_GET_SNAPSHOTS
- don't rely on potentially stale m_snap_parents on retry

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-09-05 23:02:39 +02:00