Commit Graph

130244 Commits

Author SHA1 Message Date
Boris Ranto
f1d17b04e4
Merge pull request #45295 from lbausch/tweak_mgr_alerts_mail
mgr/alerts: Add Message-Id and Date header to sent emails

Reviewed-by: Boris Ranto <branto@redhat.com>
2022-03-29 13:55:14 +02:00
Kefu Chai
1651ce5b03
Merge pull request #45676 from rzarzynski/wip-crimson-toolset-10
ceph.spec.in: use gcc-toolset-10 for building crimson

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-03-29 17:03:14 +08:00
Ernesto Puerta
729e956855
Merge pull request #44014 from rhcs-dashboard/host-detail-service-column
mgr/dashboard: extend daemon actions to host details 

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
2022-03-29 10:49:31 +02:00
Yuval Lifshitz
cd96c07c6f
Merge pull request #45537 from yuvalif/wip-yuval-multisite-test-devices
multisite/test: running the multisite test script with custom devices
2022-03-29 10:35:57 +03:00
Tim Serong
01359f7905
Merge pull request #45666 from SUSE/wip-fix-55087
ceph.spec.in: Use libthrift-devel on SUSE distros

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-03-29 18:01:46 +11:00
Tim Serong
c454eeae35
Merge pull request #45664 from SUSE/wip-fix-55079
ceph.spec.in: remove build directory at end of %install

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-03-29 17:08:09 +11:00
Radosław Zarzyński
30f7514317 ceph.spec.in: use gcc-toolset-10 for building crimson
This commit bumps up the toolset version but only to build crimson.
That is, the classical OSD stays unaffected.

The reason behind the upgrade is the following FTBFS:

```
[ 32%] Building CXX object src/seastar/CMakeFiles/seastar.dir/src/core/reactor.cc.o
/home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-11345-ga3bb1485/rpm/el8/BUILD/ceph-17.0.0-11345-ga3bb1485/src/seastar/src/core/reactor.cc: In constructor ‘seastar::reactor::reactor(std::shared_ptr<seastar::smp>, seastar:👽:instance&, unsigned int, seastar::reactor_backend_selector, seastar::reactor_config)’:
/home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-11345-ga3bb1485/rpm/el8/BUILD/ceph-17.0.0-11345-ga3bb1485/src/seastar/src/core/reactor.cc:926:90: error: use of deleted function ‘seastar::condition_variable::condition_variable()’
  926 |     , _thread_pool(std::make_unique<thread_pool>(this, seastar::format("syscall-{}", id))) {
      |                                                                                          ^
In file included from /home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-11345-ga3bb1485/rpm/el8/BUILD/ceph-17.0.0-11345-ga3bb1485/src/seastar/include/seastar/core/reactor.hh:74,
                 from /home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-11345-ga3bb1485/rpm/el8/BUILD/ceph-17.0.0-11345-ga3bb1485/src/seastar/src/core/reactor.cc:32:
/home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-11345-ga3bb1485/rpm/el8/BUILD/ceph-17.0.0-11345-ga3bb1485/src/seastar/include/seastar/core/condition-variable.hh:157:5: note: ‘seastar::condition_variable::condition_variable() noexcept’ is implicitly deleted because its exception-specification does not match the implicit exception-specification ‘’
  157 |     condition_variable() noexcept = default;
```

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-03-28 21:03:01 +02:00
Ernesto Puerta
2022a56646
Merge pull request #45647 from rhcs-dashboard/fix-55060-master
mgr/dashboard: fix api test issue with pip

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: David Galloway <dgallowa@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: zmc <NOT@FOUND>
2022-03-28 17:29:11 +02:00
Tim Serong
19922e1875 ceph.spec.in: Use libthrift-devel on SUSE distros
Fixes: 80e82686eb
Fixes: https://tracker.ceph.com/issues/55087
Signed-off-by: Tim Serong <tserong@suse.com>
2022-03-28 20:46:26 +11:00
Ernesto Puerta
2289ad2bc3
mgr/dashboard: fix api test issue with pip
Fix
```
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
apache-libcloud 3.5.0 requires requests>=2.26.0, but you have requests 2.25.1 which is incompatible.
Successfully installed CherryPy-13.1.0 PyJWT-2.0.1 Routes-2.4.1 bcrypt-3.1.4 ceph-1.0.0 chardet-4.0.0 cheroot-8.6.0 idna-2.10 jaraco.functools-3.5.0 more-itertools-4.1.0 natsort-8.1.0 portend-3.1.0 pyopenssl-22.0.0 pytz-2022.1 repoze.lru-0.7 requests-2.25.1 tempora-5.0.1
```

Fixes: https://tracker.ceph.com/issues/55060
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2022-03-28 11:28:36 +02:00
Tim Serong
aa18cb1200 ceph.spec.in: remove build directory at end of %install
By the time we get to the end of the %install section, all the
built binaries have been installed in the build root, so we can
delete the build directory from the source tree.  This frees up
about 17GB of disk space on build hosts, which is helpful in
case other processes later in the RPM build need more disk space.

Fixes: https://tracker.ceph.com/issues/55079
Signed-off-by: Tim Serong <tserong@suse.com>
2022-03-28 19:23:18 +11:00
Kefu Chai
01b57c1f63
Merge pull request #45661 from tchaikov/doc-dpdk
doc/dpdk: reformat and reword

Reviewed-by: Chunsong Feng <fengchunsong@huawei.com>
2022-03-27 09:58:43 +08:00
Kefu Chai
352ab9b5f0 doc/dpdk: reword the root access part
the root access to system is not a must have for running a DPDK
application. so reword the "Configuring OSD DPDKStack" section.

also, manually editing /etc/passwd is not encouraged, so use
"usermod" instead. to add a directory after user's command
interpreter in /etc/passwd does not make sense. see PASSWD(5).
so drop the paragraph on editing /etc/passwd.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-03-27 01:00:21 +08:00
Ronen Friedman
a3bb148507
Merge pull request #45640 from ronen-fr/wip-rf-snaptrim
osd/scrub: restart snap trimming only after scrubbing is done

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-03-26 20:00:20 +03:00
Kefu Chai
3d2d6ffabb doc/dpdk: improve the formatting
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-03-27 00:46:17 +08:00
Kefu Chai
20b11d81df
Merge pull request #44292 from fengchunsong/dpdk-doc
doc/dev: add dpdkstack doc

Reviewed-by: Haomai Wang <haomai@xsky.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-03-26 23:48:00 +08:00
Adam King
56f20feb62
Merge pull request #44343 from adk3798/nfs-offline
mgr/cephadm: Reschedule nfs daemons from offline hosts

Reviewed-by: Michael Fritch <mfritch@suse.com>
2022-03-25 19:45:39 -04:00
David Galloway
dcd4b20462
Merge pull request #45649 from tchaikov/wip-crimson-cleanup
crimson/os: use fmt::format() instead of sstream
2022-03-25 15:07:39 -04:00
David Galloway
01b730d349
Merge pull request #45539 from rhcs-dashboard/css-fix-highlight-search
mgr/dashboard: Remove padding in search highlighted text
2022-03-25 14:44:46 -04:00
Neha Ojha
55f87377e5
Merge pull request #45651 from sseshasa/wip-qa-fix-activate-osd-test
qa/standalone: Fix test_activate_osd() test in ceph-helpers.sh

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
2022-03-25 11:24:52 -07:00
Neha Ojha
88cad13a08
Merge pull request #45553 from wxypro/doc-update
doc/mgr/prometheus.rst: fix spelling error

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-03-25 11:06:14 -07:00
Neha Ojha
8d73d8aa1a
Merge pull request #45575 from wxypro/options-fix
common/options: fix typos: smarctl -> smartctl

Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-03-25 11:00:19 -07:00
J. Eric Ivancich
323c4fffdd
Merge pull request #44699 from ivancich/wip-bucket-index-timeout-config
core,rgw: allow configuration of bi tx timeout; add instrumentation

Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2022-03-25 13:16:39 -04:00
Neha Ojha
506361eb45
Merge pull request #45522 from sseshasa/wip-improve-mclock-docs
Doc: Improve mclock config reference documentation & update PendingReleaseNotes.

Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-03-25 09:46:41 -07:00
Sridhar Seshasayee
3aa2df2e0f qa/standalone: Fix test_activate_osd() test in ceph-helpers.sh
Modify test_activate_osd() to get the type of scheduler in use and then
verify the value of osd_max_backfills. This is because mclock scheduler
overrides this option to 1000 upon OSD initialization.

The test earlier used to pass because the OSD daemon was killed but not
marked down and upon being brought up, the wait for OSD up check was
passing quickly. But the OSD still didn't have the latest config values.

But now upon killing the OSD, the osd_fast_shutdown sequence notifies the
mon (see PR: https://github.com/ceph/ceph/pull/44807) and is marked down
and dead. Upon bringing it up, the wait for OSD up check takes a longer
time and this is sufficient for the config values to be updated. This
results in the correct values being read from the config 'Values' map.

Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
2022-03-25 22:10:31 +05:30
Yuri Weinstein
ea1727e7d5
Merge pull request #44807 from NitzanMordhai/wip-nitzan-fast-shutdown-notify-mon
osd/OSD: osd_fast_shutdown_notify_mon not quite right

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2022-03-25 08:59:05 -07:00
Kefu Chai
ac114ad172 crimson/os: use fmt::format() instead of sstream
for better readability.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-03-25 23:49:45 +08:00
J. Eric Ivancich
17692c14ad
Merge pull request #45309 from caisan/modify_without_source_segfault
radosgw-admin: fix segfault on pipe modify without source/dest zone specified

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-03-25 11:46:09 -04:00
Venky Shankar
d6516fa649
Merge pull request #45573 from wxypro/cephfs-shell-typos
tools/cephfs-shell: fix typos in comments

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2022-03-25 18:14:33 +05:30
Adam King
b511c9534d
Merge pull request #44895 from rkachach/fix_issue_54026
mgr/cephadm: Adding support for natural sorting

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2022-03-25 08:35:47 -04:00
Adam King
0bdf0eff49
Merge pull request #45241 from rkachach/fix_issue_51072
mgr/cephadm: fixing prometheus port handling

Reviewed-by: Adam King <adking@redhat.com>
2022-03-25 08:33:54 -04:00
Adam King
8cc6cbc5b1
Merge pull request #45314 from rkachach/fix_issue_54503
mgr/cephadm: checking service name before removal

Reviewed-by: Adam King <adking@redhat.com>
2022-03-25 08:32:01 -04:00
Ronen Friedman
948d3266c6 osd/scrub: restart snap trimming only after scrubbing is done
Snap trimming that was postponed as the target PG was scrubbing
must be restarted at scrub completion.
PR #38111 moved trimming restart to just before the scrub fully
terminated. The current PR fixes that.

Trimming is also restarted in those cases where scrub was
queued but aborted immediately.

Fixes: https://tracker.ceph.com/issues/52026

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2022-03-25 11:49:51 +00:00
Ilya Dryomov
b89b099893
Merge pull request #45601 from idryomov/wip-diff-iterate-striping-fix
librbd: make diff-iterate in fast-diff mode sort and merge reported extents

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
2022-03-25 09:45:26 +01:00
Kefu Chai
75ee0e2184
Merge pull request #45513 from tchaikov/wip-cxx20-fixes-mon
mgr,mon,test: C++20 fixes

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-03-25 12:24:24 +08:00
Samuel Just
0af6bc8778
Merge pull request #45386 from cyx1231st/wip-crimson-epm-split-hot-cold
crimson/os/seastore: reuse RecordSubmitter for SegmentedJournal and EPM::Writer

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-03-24 20:46:02 -07:00
J. Eric Ivancich
20e9121fdc rgw: bucket index transaction instrumentation clean-ups
Add a series of clean-ups to the instrumentation code. Keep this as a
separate commit so it will be easier to reconcile other code streams.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2022-03-24 22:24:13 -04:00
J. Eric Ivancich
85f4ee7811 rgw: additional configurable CLS instrumentation on bucket index TXs
This supplements an earlier commit to add additional instrumentation
on bucket index transactions on the CLS side.

The instrumentation is triggered by setting the configuration option
rgw_bucket_index_transaction_instrumentation in the [global] section.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2022-03-24 22:24:13 -04:00
Venky Shankar
6abcf97a8c
Merge pull request #45115 from mchangir/mgr-snap_schedule-restart-old-schedules-on-startup
mgr/snap_schedule: restart old schedules

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2022-03-25 07:24:05 +05:30
Adam King
81f31fdba1
Merge pull request #45399 from adk3798/no-firewall
cephadm: respect --skip-firewalld flag

Reviewed-by: Michael Fritch <mfritch@suse.com>
2022-03-24 15:21:32 -04:00
Adam King
f5d0e61ecd
Merge pull request #45401 from adk3798/legacy-config
cephadm: verify config file exists when inferring it

Reviewed-by: Michael Fritch <mfritch@suse.com>
2022-03-24 15:20:32 -04:00
Adam King
cdb55ba418
Merge pull request #45527 from adk3798/eca-osd-allowed
python-common/drive_group: add extra_container_args to supported features

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2022-03-24 15:19:14 -04:00
Yuri Weinstein
0891b824ca
Merge pull request #45250 from ifed01/wip-ifed-get-bluest-extents-cleanup
os/bluestore: refactor bluefs get_block_extents interface


Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
2022-03-24 09:49:46 -07:00
J. Eric Ivancich
cdfc29ff5a rgw: configurable instrumentation on bucket index transactions
In order to better understand corner cases with bucket index
operations, extra instrumentation is now added and controlled by a
boolean configuration variable
("rgw_bucket_index_transaction_instrumentation").

When set to true, there is extra logging during all CLS operations
involving bucket index transactions. Additionally, all these log
entries are tagged with "BITX" to make them easier to find in the
logs. This is preferable to setting all OSD logging at a high level
due to the log size issues.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2022-03-24 12:17:37 -04:00
J. Eric Ivancich
6e17a50497 rgw: make bucket index pending op expiration configureable
Bucket index operations are transactional with data object
manipulation. The operation is prepared by adding a pending operation
record. And when the data object side is complete, the bucket index
operation is committed.

If it fails to be committed, later bucket listings will compare the
pending ops with the current data object state and see whether it
completed or not and then either commit or expire the op. The time
span for expiration is currently hard-coded as 120 seconds (unless
overridden in the bucket header, which can happen during "bucket
check").

This commit allows that expiration time to be configured.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2022-03-24 12:16:17 -04:00
J. Eric Ivancich
3877c1e37f osd: add new CLS call to retrieve global configuration
Currently there is no easy way to gain access to global configuration
from CLS (objclass) code. This adds a new call to the CLS interface
that returns a "const ConfigProxy&" from which configuration can be
accessed.

NOTE: Working code to do provide this functionality in crimson is not
provided.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2022-03-24 12:15:32 -04:00
Kefu Chai
78dc720504
Merge pull request #45393 from rzarzynski/wip-crimson-fix-throw-in-plugins
build, crimson/osd: do not let Seastar to interfere with ELF's program headers

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-03-24 21:47:24 +08:00
Milind Changire
ac6c7240d3 qa: test snap_schedule with mgr restart
Scheduled snaps should follow the created schedule even across mgr
restart.

Signed-off-by: Milind Changire <mchangir@redhat.com>
2022-03-24 18:01:44 +05:30
Milind Changire
dca7fdb600 mgr/snap_schedule: restart old schedules
Old schedules were not picked up from database when mgr was restarted.
Restart old schedules on mgr restart.

Fixes: https://tracker.ceph.com/issues/54052
Signed-off-by: Milind Changire <mchangir@redhat.com>
2022-03-24 18:01:44 +05:30
Milind Changire
24915c8ee9 mgr/util: add function to list all fs names
Signed-off-by: Milind Changire <mchangir@redhat.com>
2022-03-24 18:01:44 +05:30