Commit Graph

81934 Commits

Author SHA1 Message Date
Yuri Weinstein
ee5c1c3071
Merge pull request #17683 from shashalu/fix-lc-xml
rgw: RGWPutLC return ERR_MALFORMED_XML  when missing <Rule> tag in lifecycle.xml

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Amit Kumar <amitkuma@redhat.com>
2018-01-09 09:10:29 -08:00
Yuri Weinstein
43378e3a86
Merge pull request #17873 from amitkumar50/cov-rgw-8
rgw: Returning when dst_ioctx.operate() returns error

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2018-01-09 09:05:32 -08:00
Yuri Weinstein
4e3a9c9c65
Merge pull request #18861 from gaosibei/wip-fix-null-pointer
rgw: fix null pointer crush

Reviewed-by: Orit Wasserman <owasserm@redhat.com>
2018-01-09 09:04:57 -08:00
Yuri Weinstein
1f1c4451f4
Merge pull request #19061 from Leeshine/wip-rgw-bug-21583
rgw: fix the bug of radowgw-admin zonegroup set requires realm

Reviewed-by: Orit Wasserman <owasserm@redhat.com>
2018-01-09 09:04:22 -08:00
Casey Bodley
cb0f1aa086
Merge pull request #19854 from fangyuxiangGL/doc-sync-err
rgw: add radosgw-admin sync error trim to trim sync error log

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2018-01-09 11:15:15 -05:00
Kefu Chai
877cd68717
Merge pull request #19809 from liu-chunmei/fix_dpdk_mzname_setting_issue
osd: fix dpdk memzon mz_name setting issue

Reviewed-By: Kefu Chai <kchai@redhat.com>
2018-01-09 23:16:43 +08:00
Sage Weil
0cdb6a74e7
Merge pull request #19616 from ifed01/wip-ifed-revert-extents
osd: get rid off extent map in object_info

Reviewed-by: Sage Weil <sage@redhat.com>
2018-01-09 08:44:52 -06:00
Sage Weil
e1cd4b5a6e
Merge pull request #19764 from ifed01/wip-ifed-storetest-cempty
objectstore/store_test: fix lack of flush prior to collection_empty()…

Reviewed-by: Sage Weil <sage@redhat.com>
2018-01-09 08:44:28 -06:00
Sage Weil
ddd5a6a7b1
Merge pull request #19841 from rzarzynski/wip-bs-dump-onode-by-ref
os/bluestore: _dump_onode() don't prolongate Onode anymore.

Reviewed-by: Sage Weil <sage@redhat.com>
2018-01-09 08:44:14 -06:00
fang yuxiang
233a4d237d rgw: add radosgw-admin sync error trim to trim sync error log
Signed-off-by: fang yuxiang fang.yuxiang@eisoo.com
2018-01-09 14:24:42 +08:00
Patrick Donnelly
7829d22689
Merge PR #19791 into master
* refs/pull/19791/head:
	doc: misc fixes
	doc: fix heading

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2018-01-08 20:45:32 -08:00
Jos Collin
ecacd1078d doc: misc fixes
misc fixes for best-practices.

Signed-off-by: Jos Collin <jcollin@redhat.com>
2018-01-09 10:09:09 +05:30
Kefu Chai
9d788c6a5b
Merge pull request #19662 from tchaikov/wip-denc-cxx-17
denc: use constexpr-if to replace some SFINAE impls

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2018-01-09 11:34:15 +08:00
Kefu Chai
09f68052cb denc: use constexpr-if to replace some SFINAE impls
more readable this way IMO.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-01-09 09:54:50 +08:00
Patrick Donnelly
cdea54757b
Merge PR #19807 into master
* refs/pull/19807/head:
	mds: warn for mds_cache_memory_limit bug in doc

Reviewed-by: Zheng Yan <zyan@redhat.com>
2018-01-08 14:27:36 -08:00
Patrick Donnelly
733d21f592
mds: warn for mds_cache_memory_limit bug in doc
Fixes: http://tracker.ceph.com/issues/22599

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2018-01-08 14:14:53 -08:00
Adam C. Emerson
5ddc90ebe1
Merge pull request #19657 from adamemerson/wip-hypermodern
The Day Has Come!

Update language standard version to C++17 and remove backported standard library features.

Reviewed-By: Casey Bodley <cbodley@redhat.com>
Reviewed-By: Kefu Chai <kchai@redhat.com>
2018-01-08 16:31:57 -05:00
Jason Dillaman
e747d24c2e
Merge pull request #19823 from trociny/wip-ggate-list-xml
rbd-ggate: make list command produce valid xml format output

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2018-01-08 16:18:41 -05:00
Casey Bodley
ad62acef9d
Merge pull request #19846 from fangyuxiangGL/compress-info
rgw: make radosgw object stat RGW_ATTR_COMPRESSION dump readable

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2018-01-08 15:54:41 -05:00
Yuri Weinstein
b63708c762
Merge pull request #19732 from shinobu-x/using_find_primarylogpg
osd: Making use of find to reduce computational complexity

Reviewed-by: Sage Weil <sage@redhat.com>
2018-01-08 12:51:11 -08:00
Yuri Weinstein
c30eca51a4
Merge pull request #19765 from liewegas/wip-force-backfill-cleanups
qa: tolerate failure to force backfill

Reviewed-by: Kefu Chai <kchai@redhat.com>
2018-01-08 12:50:18 -08:00
Yuri Weinstein
5784779305
Merge pull request #19786 from dillaman/wip-osd-class-cap
osd: support class method whitelisting within caps

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2018-01-08 12:49:51 -08:00
Adam C. Emerson
79b19aacf0 {common,osd,mds,rbd}: Remove unused captures
If we aren't referencing a variable, don't capture it. (This makes the
lambdas smaller, too, modulo Sufficiently Smart Compiler.)

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2018-01-08 15:30:05 -05:00
Adam C. Emerson
6580d0a6d9 dout: Remove VLA sanity check
This doesn't seem to be able to work for C++17 under both GCC and
Clang. Maybe there's a better way to do it. I might try routing
that argument through a constexpr function in the macro later.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2018-01-08 15:30:05 -05:00
Adam C. Emerson
22d52655c3 common: Remove backport_std.h entirely
And use the experimental ostream joiner provided with the library.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2018-01-08 15:30:05 -05:00
Adam C. Emerson
3a9ec5fc9e common: Remove backported C++17 functions
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2018-01-08 15:30:05 -05:00
Adam C. Emerson
ad038df0fd common: Remove backported typedefs
Since they're no longer needed.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2018-01-08 15:30:05 -05:00
Adam C. Emerson
da1457cdc0 build: Bump language to C++17
Fix up all of the fallout from that.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2018-01-08 15:30:03 -05:00
chunmei Liu
623c6bd5b1 osd: fix dpdk memzon mz_name setting issue
Signed-off-by: chunmei Liu <chunmei.liu@intel.com>
2018-01-08 10:57:04 -08:00
Igor Fedotov
f669fcdfd5 objectstore/store_test: fix lack of flush prior to collection_empty() call
Fixes: http://tracker.ceph.com/issues/22409

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2018-01-08 20:30:18 +03:00
Igor Fedotov
1653bcca3e qa/standalone/scrub/osd-scrub-repair.sh: remove extents flag from object_info_t
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2018-01-08 20:10:16 +03:00
Igor Fedotov
89e43115a1 osd: get rid off extent map in object_info
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2018-01-08 20:10:16 +03:00
Yuri Weinstein
585ffbec98
Merge pull request #19475 from ZVampirEM77/wip-em-copyobj-ret
rgw: add xml output header in RGWCopyObj_ObjStore_S3 response msg

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: scienceluo <luo.kexue@zte.com.cn>
2018-01-08 08:57:53 -08:00
Matt Benjamin
f6953235c4
Merge pull request #19824 from qrGitHub/wip-rgw-useless-line3
rgw: drop useless type conversion
2018-01-08 11:55:23 -05:00
Yuri Weinstein
55813f3c69
Merge pull request #19570 from yaozongyou/rgw-remove-unused-variable
cls/rgw: remove unused variable bl

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2018-01-08 08:55:10 -08:00
fang yuxiang
a5896e5c01 rgw: make radosgw object stat RGW_ATTR_COMPRESSION dump readable
Signed-off-by: fang yuxiang fang.yuxiang@eisoo.com
2018-01-09 00:54:55 +08:00
Yuri Weinstein
8096752c5a
Merge pull request #19575 from Liuchang0812/rgw-tier-type-check
rgw: proper error message when tier_type does not exist

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
2018-01-08 08:54:23 -08:00
Yuri Weinstein
4032b1a4fe
Merge pull request #19582 from qrGitHub/wip-rgw-redundant-readingAttrs
rgw: remove get_system_obj_attrs in function RGWDeleteLC::execute and RGWDeleteCORS::execute

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2018-01-08 08:53:19 -08:00
Yuri Weinstein
d095ab2a4e
Merge pull request #19676 from qrGitHub/wip-rgw-redundant-compare
rgw: remove redundant signature compare in LocalEngine::authenticate

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2018-01-08 08:52:25 -08:00
Yuri Weinstein
26e174045f
Merge pull request #19678 from yaozongyou/rgw-civetweb-status-code
rgw: log the right http status code in civetweb frontend's access log

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2018-01-08 08:51:35 -08:00
Yuri Weinstein
240ead6836
Merge pull request #19687 from qrGitHub/wip-rgw-bucketPolicy-invalidEffect
rgw: put bucket policy panics RGW process

Reviewed-by: Adam Emerson <aemerson@redhat.com>
2018-01-08 08:49:51 -08:00
Yuri Weinstein
7ecef5ba1e
Merge pull request #19700 from qrGitHub/wip-rgw-optimize-function
rgw: optimize function RGWHandler::do_init_permissions

Reviewed-by: Adam Emerson <aemerson@redhat.com>
2018-01-08 08:49:18 -08:00
Yuri Weinstein
b712b75e69
Merge pull request #19710 from qrGitHub/wip-rgw-optimize-function2
rgw: optimize function abort_bucket_multiparts

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
2018-01-08 08:46:54 -08:00
Yuri Weinstein
205320b25c
Merge pull request #19772 from fangyuxiangGL/quota
rgw: update quota is inconsistent at add/del object with compression

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2018-01-08 08:46:22 -08:00
Yuri Weinstein
e57055c7cc
Merge pull request #19773 from chuang-he/fix_create_form_headers
rgw: fix the return type is wrong

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2018-01-08 08:46:02 -08:00
John Spray
5ae196e465
Merge pull request #19431 from wido/mgr-pg-status
mgr/dashboard: Fix PG status coloring

Reviewed-by: John Spray <john.spray@redhat.com>
2018-01-08 16:13:56 +00:00
Sage Weil
a913358d6f
Merge pull request #19294 from myoungwon/wip-manifest-ref-flush
osd: flush operations for chunked objects

Reviewed-by: Sage Weil <sage@redhat.com>
2018-01-08 08:55:47 -06:00
Radoslaw Zarzynski
49a4c51e02 os/bluestore: _dump_onode() don't prolongate Onode anymore.
Before the patch `BlueStore::_dump_onode()` takes `OnodeRef`
by value effectively extending the object's life time.

This is unnecessary and can be costly as `BlueStore::OnodeRef`
is ref-counted with `boost::intrusive_ptr`. Moreover, callers
are supposed to already hold a reference, so the optimization
for `count == 0` case stays without effect of inhibiting call
to `BlueStore::Onode::put()` and atomic integer increment.

    ```
    0000000000907d70 <BlueStore::_do_read(BlueStore::Collection*, boost::intrusive_ptr<BlueStore::Onode>, unsigned long, unsigned long, ceph::buffer::list&, unsigned int)>:
      907d70:       41 57                   push   %r15
      907d72:       41 56                   push   %r14

    ...

      907f1f:       48 8b 44 24 78          mov    0x78(%rsp),%rax
      907f24:       48 8b 00                mov    (%rax),%rax
      907f27:       48 85 c0                test   %rax,%rax
      907f2a:       48 89 84 24 a0 01 00    mov    %rax,0x1a0(%rsp)
      907f31:       00
      907f32:       74 04                   je     907f38 <BlueStore::_do_read(BlueStore::Collection*, boost::intrusive_ptr<BlueStore::Onode>, unsigned long, unsigned long, ceph::buffer::list&, unsigned int)+0x1c8>
      907f34:       f0 83 00 01             lock addl $0x1,(%rax)
      907f38:       48 8d 84 24 a0 01 00    lea    0x1a0(%rsp),%rax
      907f3f:       00
      907f40:       ba 1e 00 00 00          mov    $0x1e,%edx
      907f45:       4c 89 ff                mov    %r15,%rdi
      907f48:       48 89 c6                mov    %rax,%rsi
      907f4b:       48 89 44 24 20          mov    %rax,0x20(%rsp)
      907f50:       e8 9b bc fb ff          callq  8c3bf0 <BlueStore::_dump_onode(boost::intrusive_ptr<BlueStore::Onode>, int)>
      907f55:       48 8b bc 24 a0 01 00    mov    0x1a0(%rsp),%rdi
      907f5c:       00
      907f5d:       48 85 ff                test   %rdi,%rdi
      907f60:       74 05                   je     907f67 <BlueStore::_do_read(BlueStore::Collection*, boost::intrusive_ptr<BlueStore::Onode>, unsigned long, unsigned long, ceph::buffer::list&, unsigned int)+0x1f7>
      907f62:       e8 99 14 02 00          callq  929400 <BlueStore::Onode::put()>
      907f67:       48 8d 84 24 d0 00 00    lea    0xd0(%rsp),%rax
    ```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2018-01-08 13:27:25 +01:00
Kefu Chai
c9c821cb99
Merge pull request #19428 from tchaikov/wip-erasure-cleanup
erasure-code: use std::count() instead

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2018-01-08 19:51:10 +08:00
Kefu Chai
f69516e1dc
Merge pull request #19777 from tchaikov/wip-rpm-fix-upgrade
rpm: adjust ceph-{osdomap,kvstore,monstore}-tool feature move

Reviewed-by: Boris Ranto <branto@redhat.com>
Reviewed-By: Nathan Cutler <ncutler@suse.com>
2018-01-08 19:07:48 +08:00