Commit Graph

97855 Commits

Author SHA1 Message Date
J. Eric Ivancich
edddca27fa rgw: add editor directive comments to rgw services source files
So that both vi and emacs help to correctly format the source files,
add the directives to each of the source files. In addition, use
`#pragma once` in the header files instead of the macro work-around.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2019-04-30 14:54:55 -04:00
Abhishek L
b8863264ec
Merge pull request #27793 from theanalyst/doc/releases/14.2.1
doc: release notes for 14.2.1

Reviewed-By: Sage Weil <sweil@redhat.com>
Reviewed-By: Nathan Cutler <nculter@suse.com>
2019-04-30 18:23:03 +02:00
Sage Weil
ccfb160628 Merge PR #27734 into master
* refs/pull/27734/head:
	msg/async: Don't miss record l_msgr_running_recv_time if "pendingReadLen != 0"

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2019-04-30 10:45:15 -05:00
Sage Weil
97bba5d52d Merge PR #27869 into master
* refs/pull/27869/head:
	tools/ceph-objectstore-tool: dump onode internal metadata.
	tools/ceph-objectstore-tool: add --no-superblock option.

Reviewed-by: Sage Weil <sage@redhat.com>
2019-04-30 10:44:36 -05:00
Abhishek Lekshmanan
5453a228c1 doc: changelog: drop redundant nautilus and component names
Also sort the entries

Signed-off-by: Abhishek Lekshmanan <alekshmanan@suse.com>
2019-04-30 17:29:58 +02:00
Lenz Grimmer
75902401df
mgr/dashboard: Queue notifications as default (#27274)
mgr/dashboard: Queue notifications as default

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-04-30 16:04:42 +02:00
Lenz Grimmer
b94c5edcc1
Merge pull request #27612 from Devp00l/wip-issue-39296
mgr/dashboard: KV-table transforms dates through pipe

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2019-04-30 16:03:06 +02:00
Lenz Grimmer
a55dd48a6d
mgr/dashboard: bucket modification time to local time (#27669)
mgr/dashboard: bucket modification time to local time

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2019-04-30 15:42:25 +02:00
Sage Weil
4933a0475b Merge PR #27875 into master
* refs/pull/27875/head:
	mgr/DaemonServer: Fix pgp_num throttling min
	mgr/DaemonServer: allow pgp_num increases to be fast if pool is empty(ish)
	mgr: fix pgp_num vs merge pacer

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-04-30 08:28:21 -05:00
Sebastian Wagner
f82013123f
Merge pull request #26185 from jmolmo/hosts_management_ls
mgr/ansible: Host ls implementation
2019-04-30 13:36:43 +02:00
Kefu Chai
0d1071bd1a
Merge pull request #27883 from majianpeng/crimson-compiler-error
test/crimson: fix a compiler error.

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-04-30 19:36:24 +08:00
Sebastian Wagner
828241b675
Merge pull request #27607 from sebastian-philipp/test-orchestrator-id-race
mgr/test_orchestrator: Fix 'TestWriteCompletion' object has no attribute 'id'

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
2019-04-30 13:29:37 +02:00
Stephan Müller
30aee04465 mgr/dashboard: Queue notifications as default
Every time "show" is triggers now the notification gets queued before
sending it out. The notification service will make sure not to send out
duplicated notifications and to combine notifications that have the same
title. The combination of notification is useful for error messages.

For example if the mgr goes down you will get a view toasties notifying
about a 500 error. With the new implementation you get only one with the
different API paths it couldn't get.

Fixes: https://tracker.ceph.com/issues/39034
Signed-off-by: Stephan Müller <smueller@suse.com>
2019-04-30 10:15:36 +02:00
Nathan Cutler
8bce53fa72
Merge pull request #27614 from smithfarm/wip-39323
tests: mgr/tox: make run-tox.sh scripts more robust

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
2019-04-30 10:13:00 +02:00
Lenz Grimmer
3ec1130719
Merge pull request #27613 from Devp00l/wip-issue-23858
mgr/dashboard: RBD snapshot name suggestion with local time suffix

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
2019-04-30 09:43:01 +02:00
Jianpeng Ma
13e04977ac test/crimson: fix a compiler error.
When with -DWITH_SEASTAR=ON, met the following bug:
/home/ceph/src/test/crimson/test_alien_echo.cc:164:13: error: ‘client’ was not declared in this scope
             client.msgr->set_require_authorizer(false);
             ^~~~~~
/home/ceph/src/test/crimson/test_alien_echo.cc:164:13: note: suggested alternative: ‘client_t’
             client.msgr->set_require_authorizer(false);
             ^~~~~~
             client_t
/home/ceph/src/test/crimson/test_alien_echo.cc: In instantiation of ‘seastar_echo(entity_addr_t, echo_role, unsigned int)::<lambda(auto:47)>::<lambda(auto:48&)> [with auto:48 = seastar_pingpong::Client; auto:47 = ceph::net::Messenger*]’:
/usr/include/c++/7/type_traits:2428:26:   required by substitution of ‘template<class _Fn, class ... _Args> static std::__result_of_success<decltype (declval<_Fn>()((declval<_Args>)()...)), std::__invoke_other> std::__result_of_other_impl::_S_test(int) [with _Fn = seastar_echo(entity_addr_t, echo_role, unsigned int)::<lambda(auto:47)> [with auto:47 = ceph::net::Messenger*]::<lambda(auto:48&)>; _Args = {seastar_pingpong::Client&}]’
/usr/include/c++/7/type_traits:2439:55:   required from ‘struct std::__result_of_impl<false, false, seastar_echo(entity_addr_t, echo_role, unsigned int)::<lambda(auto:47)> [with auto:47 = ceph::net::Messenger*]::<lambda(auto:48&)>, seastar_pingpong::Client&>’
/usr/include/c++/7/type_traits:2444:12:   required from ‘struct std::__invoke_result<seastar_echo(entity_addr_t, echo_role, unsigned int)::<lambda(auto:47)> [with auto:47 = ceph::net::Messenger*]::<lambda(auto:48&)>, seastar_pingpong::Client&>’
/usr/include/c++/7/type_traits:2457:12:   required from ‘class std::result_of<seastar_echo(entity_addr_t, echo_role, unsigned int)::<lambda(auto:47)> [with auto:47 = ceph::net::Messenger*]::<lambda(auto:48&)>(seastar_pingpong::Client&)>’
/home//ceph/src/seastar/include/seastar/core/do_with.hh:93:17:   required from ‘auto seastar::do_with(T&&, F&&) [with T = seastar_pingpong::Client; F = seastar_echo(entity_addr_t, echo_role, unsigned int)::<lambda(auto:47)> [with auto:47 = ceph::net::Messenger*]::<lambda(auto:48&)>]’
/home/ceph/src/test/crimson/test_alien_echo.cc:184:32:   required from ‘seastar_echo(entity_addr_t, echo_role, unsigned int)::<lambda(auto:47)> [with auto:47 = ceph::net::Messenger*]’
/usr/include/c++/7/type_traits:2428:26:   required by substitution of ‘template<class _Fn, class ... _Args> static std::__result_of_success<decltype (declval<_Fn>()((declval<_Args>)()...)), std::__invoke_other> std::__result_of_other_impl::_S_test(int) [with _Fn = seastar_echo(entity_addr_t, echo_role, unsigned int)::<lambda(auto:47)>; _Args = {ceph::net::Messenger*&&}]’
/usr/include/c++/7/type_traits:2439:55:   required from ‘struct std::__result_of_impl<false, false, seastar_echo(entity_addr_t, echo_role, unsigned int)::<lambda(auto:47)>, ceph::net::Messenger*&&>’
/usr/include/c++/7/type_traits:2444:12:   required from ‘struct std::__invoke_result<seastar_echo(entity_addr_t, echo_role, unsigned int)::<lambda(auto:47)>, ceph::net::Messenger*&&>’
/usr/include/c++/7/type_traits:2457:12:   required from ‘class std::result_of<seastar_echo(entity_addr_t, echo_role, unsigned int)::<lambda(auto:47)>(ceph::net::Messenger*&&)>’
/home//ceph/src/seastar/include/seastar/core/future.hh:980:30:   required by substitution of ‘template<class Func, class Result>  requires  CanApply<Func, ceph::net::Messenger*> Result seastar::future<ceph::net::Messenger*>::then<Func, Result>(Func&&) [with Func = seastar_echo(entity_addr_t, echo_role, unsigned int)::<lambda(auto:47)>; Result = <missing>]’
/home//ceph/src/test/crimson/test_alien_echo.cc:207:8:   required from here
/home/ceph/src/test/crimson/test_alien_echo.cc:190:13: error: base operand of ‘->’ has non-pointer type ‘ceph::net::Messenger’
             client.msgr->set_require_authorizer(false);
             ^~~~~~

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
2019-04-30 15:29:08 +08:00
Kefu Chai
1f5bb0c200
Merge pull request #27880 from majianpeng/fio_ceph_messenger
test/fio: fix a compiler error.

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-04-30 14:49:05 +08:00
Jianpeng Ma
c6a9e988f3 test/fio: fix a compiler error.
Met the following bug when -DWITH_FIO=ON:
/home/src/test/fio/fio_ceph_messenger.cc:217:5: error: ‘require_authorizer’ was not declared in this scope
     require_authorizer = false;
This bug introduce by f10660e84f which omit this.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
2019-04-30 13:48:47 +08:00
Sage Weil
a0d63c1a1f mgr/DaemonServer: Fix pgp_num throttling min
This was meant to limit the size of any single change to 1/2 of the
max_misplaced (see the comment above!).

Signed-off-by: Sage Weil <sage@redhat.com>
2019-04-29 16:27:58 -05:00
Sage Weil
c7c2d18da5 mgr/DaemonServer: allow pgp_num increases to be fast if pool is empty(ish)
If we just created a new pool and it's basically empty, there is no reason
to throttle the pgp_num changes.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-04-29 16:17:40 -05:00
Sage Weil
e6113c1725 mgr: fix pgp_num vs merge pacer
This condition should only kick in for pgp_num reductions, or else we'll
end up jump to the end instead of slowing down merges.  (For splits, we
don't need to pace like this at all.)

Fixes 76503a1438

Signed-off-by: Sage Weil <sage@redhat.com>
2019-04-29 16:17:01 -05:00
Gregory Farnum
8cd1128157
Merge pull request #27867 from tchaikov/wip-ceph-object-corpus
ceph-object-corpus: pick up 15.0.0-539-g191ab33faf

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2019-04-29 13:45:16 -07:00
Abhishek Lekshmanan
272dd1fc2b doc: release notes for 14.2.1
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
2019-04-29 20:26:40 +02:00
Casey Bodley
f0a9719d2c
Merge pull request #27730 from cbodley/wip-rgw-boost-170
rgw: fix compile errors with boost 1.70

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2019-04-29 13:06:47 -04:00
Igor Fedotov
c3968c4f03 tools/ceph-objectstore-tool: dump onode internal metadata.
Supported for BlueStore only.

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2019-04-29 19:43:56 +03:00
Kefu Chai
c99f7e1682
Merge pull request #27861 from tchaikov/wip-utime-cleanup
include/utime: do not cast sec to time_t

Reviewed-by: Samuel Just <sjust@redhat.com>
2019-04-30 00:17:08 +08:00
Kefu Chai
b1ed98a617 ceph-object-corpus: pick up 15.0.0-539-g191ab33faf
Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-04-30 00:13:41 +08:00
Lenz Grimmer
f92638fe3d
Merge pull request #27784 from Devp00l/wip-39483
mgr/dashboard: Make all columns sortable
2019-04-29 18:05:26 +02:00
Sage Weil
f3f2490620 Merge PR #27590 into master
* refs/pull/27590/head:
	messages: #include necessary header

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-04-29 11:04:31 -05:00
Sage Weil
5b1bbdfec1 Merge PR #27804 into master
* refs/pull/27804/head:
	common, osd: remove erroneous 'section' in dump functions
	dencoder: include some missed types
	common: make utime_t dencoder-compatible
	common: make uuid_d dencoder-compatible
	osd: make watch_item_t dencoder-compatible

Reviewed-by: Sage Weil <sage@redhat.com>
2019-04-29 11:04:15 -05:00
Sage Weil
0191a27579 Merge PR #27832 into master
* refs/pull/27832/head:
	qa/suites/upgrade/mimic-x-singleton: suppress legacy statfs warning
	osd: reenable authorizer on hb messenger for nautilus+
	mon/MonClient: do not crash on empty auth request buffer
	msg: set_require_authorizer on messenger, not dispatcher
	mon/Monitor: allow probe if MMonProbe::mon_release == 0
	mon: fix min_mon_release print

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-04-29 11:03:53 -05:00
Kefu Chai
519f417ef5
Merge pull request #27788 from cyx1231st/wip-seastar-msgr-batch-send
crimson/net: improve batching in the write path

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-04-29 23:38:16 +08:00
Stephan Müller
a23ec08795 mgr/dashboard: RBD snapshot name suggestion with local time suffix
The new suffix is still a time that follows the ISO standard as it can
be converted into any other time zone through the time zone prefix of
itself.

Fixes: https://tracker.ceph.com/issues/23858
Signed-off-by: Stephan Müller <smueller@suse.com>
2019-04-29 16:49:28 +02:00
Kefu Chai
41747f7d9e
Merge pull request #27776 from JunHe77/install-deps
install-deps.sh: add option to skip prebuilt boost-* pkgs installation

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-04-29 22:34:10 +08:00
Stephan Müller
ba6d0f96db mgr/dashboard: Make all columns sortable
Fixes: https://tracker.ceph.com/issues/39483
Signed-off-by: Stephan Müller <smueller@suse.com>
2019-04-29 15:48:37 +02:00
Kefu Chai
50226ef63c include/utime: do not cast sec to time_t
strictly speaking, time_t is an opaque time, and in this context, we
need a uint32_t, so it is not necessary and wrong. let's remove it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-04-29 21:11:52 +08:00
Lenz Grimmer
34b4cce61e
mgr/dashboard: auth: fix user lastUpdate timestamp generation (#27604)
mgr/dashboard: auth: fix user lastUpdate timestamp generation

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2019-04-29 14:23:17 +02:00
Lenz Grimmer
106388be8f
monitoring: Prometheus default alerts (#27596)
monitoring: Prometheus default alerts

Reviewed-by: Boris Ranto <branto@redhat.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2019-04-29 13:36:05 +02:00
Kefu Chai
1e8183e01b
Merge pull request #27837 from cyx1231st/wip-seastar-msgr-fix-read
crimson/net: misc fixes in v1 read path

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-04-29 18:51:09 +08:00
Yingxin Cheng
5ca97cd358 crimson/net: misc fixes in v1 read path
* abort when decoding/signature-check failed;
* change log-level to warn;
* free the decoded message when failed;
* add unlikely to read path;

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>
2019-04-29 23:13:23 +08:00
Igor Fedotov
bb142b2182 tools/ceph-objectstore-tool: add --no-superblock option.
This allows to use the tool to inspect 'incomplete' object stores.
E.g. ones created by ceph_test_objectstore.

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2019-04-29 11:21:46 +03:00
Yingxin Cheng
c9aae7a99f crimson/net: increase out buffer to 65536
Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>
2019-04-29 15:58:03 +08:00
Yingxin Cheng
4df5bb5860 crimson/net: group write-related general implementations
Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>
2019-04-29 15:58:03 +08:00
Yingxin Cheng
4091f76a68 crimson/net: use optional keepalive_ack to notify writes
Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>
2019-04-29 15:58:03 +08:00
Yingxin Cheng
b5e9c89065 crimson/net: gather message buffers when send
Gather buffers from pending messages/keepalive and send them together.

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>
2019-04-29 15:58:03 +08:00
Kefu Chai
f2bafe4b03
Merge pull request #27809 from tchaikov/wip-crimson-auth
crimson,auth: fix FTBFS of crimson-osd and fix v1/v2 auth

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-04-29 09:10:16 +08:00
Kefu Chai
378b057e59
Merge pull request #27831 from tchaikov/wip-crimson-silence-warning
crimson/net: prefer <fmt/chrono.h> over <fmt/time.h>

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2019-04-29 09:09:15 +08:00
Sage Weil
fdf6f8b26b qa/suites/upgrade/mimic-x-singleton: suppress legacy statfs warning
Signed-off-by: Sage Weil <sage@redhat.com>
2019-04-28 19:21:52 -05:00
Mykola Golub
24ef73f4cf
Merge pull request #27756 from dillaman/wip-39025
librbd: initial consolidation of internal locks

Reviewed-by: Mykola Golub <mgolub@suse.com>
2019-04-28 20:03:02 +03:00
Kefu Chai
535aef6082 crimson/osd: silence -Wunused-variable warning
silence warning like

/home/kchai/ceph/src/crimson/osd/heartbeat.cc:314:24: warning: unused
variable ‘peer’ [-Wunused-variable]
       auto& [peer, info] = item;
                        ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-04-29 00:12:57 +08:00