Commit Graph

132938 Commits

Author SHA1 Message Date
Yingxin Cheng
eaa1519217 crimson/os/seastore: cleanup segment_id_t
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-05 09:20:59 +08:00
Yingxin Cheng
487983477f crimson/os/seastore: cleanup DEVICE_ID_BITS
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-05 09:20:59 +08:00
Kefu Chai
ba8a30c663
Merge pull request #47427 from tchaikov/wip-strong-ordering
include, common, osd: use std::strong_ordering machinery

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-08-05 08:29:35 +08:00
Kefu Chai
70d68f56b6
Merge pull request #47462 from ronen-fr/wip-rf-list-snapset
tests/osd: fix a test to follow an output formatting change

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-08-05 08:22:02 +08:00
Kefu Chai
2a87d0dada
Merge pull request #47461 from tchaikov/wip-wip32-deps
win32_deps_build.sh: bump curl to curl-7_84_0

Reviewed-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2022-08-05 07:51:35 +08:00
Casey Bodley
df35a7392d
Merge pull request #47468 from cbodley/wip-cmake-exporter-no-mgr
cmake: ceph-exporter fix for WITH_MGR=OFF

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
2022-08-04 19:24:18 -04:00
Casey Bodley
be9b7cedb1 cmake: ceph-exporter fix for WITH_MGR=OFF
removing vstart-base's unconditional dependency on ceph-exporter. it's
added conditionally just below:

if (WITH_MGR)
  add_dependencies(vstart-base ceph-mgr)
  add_dependencies(vstart-base ceph-exporter)

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2022-08-04 14:25:24 -04:00
Ronen Friedman
b04ef6ebfc tests/osd: fix a test to follow an output formatting change
PR#47255 modified the formatting of std::set-s. That broke
the osd-scrub-snaps.sh standalone test.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2022-08-04 15:46:11 +00:00
Kefu Chai
6b43df3c58 win32_deps_build.sh: bump curl to curl-7_84_0
to silence warnings like:

```
configure.ac:3671: warning: The macro `AC_HELP_STRING' is obsolete.
configure.ac:3671: You should run autoupdate.
```

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-04 23:08:12 +08:00
Kefu Chai
0420a7bb91 common,include: drop include/cmp.h
it is not used anymore. so just ditch it.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-04 21:33:51 +08:00
Kefu Chai
e9963ed7dc common: drop WRITE_{EQ,CMP}_OPERATORS_7()
the default-generated comparison operators can fulfill our needs.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-04 21:33:51 +08:00
Kefu Chai
f02a2a7195 osd: implement three-way comparison operator for basic types
this is the prerequisite for implementing the three-way comparison
operator for types which aggregates these basic types

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-04 21:33:51 +08:00
Kefu Chai
06c641b8c6 common: drop WRITE_{EQ,CMP}_OPERATORS_5()
the default-generated comparison operators can fulfill our needs.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-04 21:33:51 +08:00
Kefu Chai
cba426698f common: drop WRITE_{EQ,CMP}_OPERATORS_4()
the default-generated comparison operators can fulfill our needs.

the order of member variables of `ghobject_t` is adjusted to match
the ordering of `ghobject_t`. the default-generated three-way
comparison operator uses the order in which the member variables
are declared to do the lexical comparison.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-04 21:33:51 +08:00
Kefu Chai
fac4942b03 librados, os: drop WRITE_{EQ,CMP}_OPERATORS_3()
the default-generated comparison operators can fulfill our needs.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-04 21:33:51 +08:00
Kefu Chai
e9a110aaa3 include: drop WRITE_{EQ,CMP}_OPERATORS_2()
the default-generated comparison operators can fulfill our needs.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-04 21:33:51 +08:00
Kefu Chai
27e38181ab include: drop WRITE_{EQ,CMP}_OPERATORS_1()
the default-generated comparison operators can fulfill our needs.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-04 21:33:51 +08:00
Kefu Chai
4bbc8cc2d3 osd/osd: do not init OSDOp::rval explicitly
errorcode32_t's ctor can take care of this. it sets the internal value
to 0.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-04 21:33:51 +08:00
Kefu Chai
c1062a0df2
Merge pull request #47449 from tchaikov/rpm-gts-11
ceph.spec.in: build with gcc-toolset-11

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-08-04 21:30:51 +08:00
Venky Shankar
bcfc2e2089
Merge pull request #46876 from neesingh-rh/feature_55821
mgr/volumes: add interface to check the presence of subvolumegroups/subvolumes

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-08-04 18:40:10 +05:30
Kefu Chai
2a97033ba8 cmake: disable LTO when building pmdk
See-also: https://tracker.ceph.com/issues/54473
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-04 17:56:48 +08:00
Kefu Chai
9f00a70232 debian: use dpkg/default.mk to init popular make variables
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-04 16:35:20 +08:00
Nizamudeen A
4697911c07
Merge pull request #47263 from rhcs-dashboard/fix-host-service-instances
mgr/dashboard: host list tables doesn't show all services deployed

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
2022-08-04 12:58:03 +05:30
Avan
ddce14e982
Merge pull request #46213 from ceph/feature-exporter
exporter: per node metric exporter

Reviewed-by: MrFreezeex <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Sébastien Han <seb@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
2022-08-04 11:48:54 +05:30
Kefu Chai
3811e8835d ceph.spec.in: BuildRequires gcc-toolset-11-libatomic-devel for aarch64
to address following failure when generating the building system
using CMake:

```
-- Performing Test HAVE_LIBATOMIC
-- Performing Test HAVE_LIBATOMIC - Failed
CMake Error at cmake/modules/CheckCxxAtomic.cmake:66 (message):
  Host compiler /opt/rh/gcc-toolset-11/root/usr/bin/c++ requires libatomic,
but it is not found
```

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-04 12:15:03 +08:00
Kefu Chai
336fe86af8 ceph.spec.in: call %enable_devtoolset11 on centos8
before this change %enable_devtoolset11 is called only when building
with crimson on centos8.

after this change %enable_devtoolset11 is called when building on
centos8. because we've started using gcc-toolset-11 for building
rpm packages on centos8 after the C++20 migration. so, to build
with gcc-11, we need to enable it.

also, because gcc-toolset-11 is used, we have to disable
annotated_build.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-04 11:02:16 +08:00
Adam King
d32a19abe1
Merge pull request #47299 from hookak/loki-dependency
mgr/cephadm: Add loki dependency to grafana, promtail

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2022-08-03 15:52:07 -04:00
Yuri Weinstein
49937c3798
Merge pull request #47165 from NitzanMordhai/wip-nitzan-librados-ioctx-destroy-Segmentation-fault
librados: rados_ioctx_destroy check for initialized ioctx

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-08-03 08:04:58 -07:00
Yuri Weinstein
dc218e4b6b
Merge pull request #47138 from kamoltat/wip-ksirivad-fix-test-pool-min-size
qa/tasks/ceph_manager.py: increase test_pool_min_size timeout

Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-08-03 08:03:52 -07:00
Yuri Weinstein
9b1e6011c8
Merge pull request #47065 from ifed01/wip-ifed-fix-blufs-unlink-fsync
os/bluestore: do not signal deleted dirty file to bluefs log

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
2022-08-03 08:03:24 -07:00
Yuri Weinstein
9a792f629b
Merge pull request #46838 from pdvian/wip-version-mgrupdate
mgr: Remove service_daemon handling from MMgrUpdate

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
2022-08-03 08:02:33 -07:00
Yuri Weinstein
fa6ca01c2c
Merge pull request #46507 from aclamk/wip-memstore-leak
os/memstore: Fix memory leak

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-08-03 08:01:45 -07:00
Yuri Weinstein
e6e6e54452
Merge pull request #44774 from rishabh-d-dave/qa-cleanup
qa/ceph_manager: clean up CephManager.do_rados()

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-08-03 08:01:00 -07:00
Kefu Chai
f9f896d3fe
Merge pull request #47327 from rosinL/fix-op-release
crimson/osd/osd_operation: fix abort caused by op be deleted ahead

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-08-03 22:27:15 +08:00
Venky Shankar
5cdf5ea3a3
Merge pull request #47026 from lxbsz/wip-56517
fuse_ll: fix compile error when libfuse version is larger than 3.0

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Luis Henriques <lhenriques@suse.de>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2022-08-03 19:48:27 +05:30
Kefu Chai
7995d53f47
Merge pull request #47412 from rzarzynski/wip-crimson-monc-nothrow-on-renewal
crimson/net: don't throw on failure when renewing tickets and keyrings

Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-08-03 21:32:27 +08:00
Guillaume Abrioux
059efbb960
Merge pull request #47434 from guits/cv-fix-test-get-file-content
ceph-volume/tests: fix test_exception_returns_default
2022-08-03 13:28:51 +02:00
Yuval Lifshitz
439db888f4
Merge pull request #47177 from yuvalif/wip-yuval-backport-doc-fix
doc: change "master" to "main" in backport doc

reviewed-by: anthonyeleven, ljflores, zdover23
2022-08-03 14:13:52 +03:00
Avan Thakkar
d7226fcc45 exporter: per node metric exporter
Fixes: https://tracker.ceph.com/issues/55046

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
2022-08-03 13:13:49 +02:00
Kefu Chai
2a9ad58cf9
Merge pull request #47428 from tchaikov/wip-crimson-strong-ordering
crimson: use std::strong_ordering mechinary

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-03 18:49:10 +08:00
Nizamudeen A
1c260e88f2
Merge pull request #46863 from bryanmontalvan/dashboard-matcher
mgr/dashboard: Simplified silence-form matchers list layout

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2022-08-03 15:56:17 +05:30
Avan Thakkar
25b03d8515 mgr/dashboard: add cephadm e2e tests for checking count for services instances
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
2022-08-03 15:40:47 +05:30
Kefu Chai
81742bc195 crimson/os: do not use WRITE_*_OPERATORS_{3,4}()
the default-generated comparison operator is able to fulfill our needs
already.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-03 17:20:43 +08:00
Guillaume Abrioux
47aec3b86b ceph-volume/tests: fix test_exception_returns_default
There are cases, like running tests as root user, where this test fails
because root user can always read the file content.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2022-08-03 11:16:36 +02:00
yuval Lifshitz
f7975b0770 doc: change "master" to "main" in backport doc
also fix the alias setting example

Signed-off-by: yuval Lifshitz <ylifshit@redhat.com>
2022-08-03 08:32:16 +00:00
Nizamudeen A
704c56b2f4
Merge pull request #47418 from rhcs-dashboard/token-logs-no-good
mgr/dashboard: remove token logging

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2022-08-03 12:25:49 +05:30
Tim Serong
9de4c8e5a4
Merge pull request #47429 from SUSE/wip-suse-gcc11-or-greater
ceph.spec.in: set BuildRequires: gcc-c++ >= 11 for SUSE distros

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-08-03 16:45:06 +10:00
Yingxin
044d449c9e
Merge pull request #47426 from cyx1231st/wip-seastore-silence-this
crimson: capture this explicitly to silence warnings

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2022-08-03 13:20:32 +08:00
Tim Serong
80949babab ceph.spec.in: set BuildRequires: gcc-c++ >= 11 for SUSE distros
This is much simpler than explicitly requiring gcc 11, and
anyway, openSUSE Tumbleweed is up to gcc 12 now.

Signed-off-by: Tim Serong <tserong@suse.com>
2022-08-03 15:20:25 +10:00
Kefu Chai
c34d3fd066 crimson: do not use WRITE_{EQ,CMP}_OPERATORS_2()
the default-generated comparison operators can fulfill our needs.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-03 12:57:34 +08:00