Commit Graph

125959 Commits

Author SHA1 Message Date
David Galloway
e1b55f6878 run-make-check.sh: Increase failure output log size
Fixes: https://tracker.ceph.com/issues/43566

Signed-off-by: David Galloway <dgallowa@redhat.com>
2021-08-18 14:01:05 -04:00
Ronen Friedman
fcdf7f3791
Merge pull request #42827 from ronen-fr/wip-ronenf-std-fix2
key_value_store: fix missing std

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-08-18 14:40:30 +03:00
Kefu Chai
feac6426a5
Merge pull request #42825 from hualongfeng/fix_blk_pmem
blk/pmem: Add namespace std for map,string

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-08-18 19:39:26 +08:00
Sebastian Wagner
b778996620
Merge pull request #42690 from adk3798/offline2
mgr/cephadm: make scheduler able to accomodate offline/maintenance hosts

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Reviewed-by: Cory Snyder <csnyder@iland.com>
2021-08-18 12:00:33 +02:00
Sebastian Wagner
4bf9a31d45
Merge pull request #42592 from vfreex/cephadm-better-port-stripping
cephadm: better port stripping

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
2021-08-18 11:52:09 +02:00
Sebastian Wagner
bea992a7c0
Merge pull request #42590 from vfreex/cephadm-propagate-env-vars
cephadm: propagate environment variables to subprocesses
2021-08-18 11:51:17 +02:00
Sebastian Wagner
28f9290eac
Merge pull request #42589 from vfreex/fix-cephadm-ipv6
cephadm: Fix bootstrap error with IPv6 mon-ip

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
2021-08-18 11:48:18 +02:00
Sebastian Wagner
6462dc77ca
Merge pull request #42816 from sebastian-philipp/cephadm-upgrade-status-message
mgr/cephadm/upgrade: Upgrade status: We also upgrade non-ceph daemons

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Dimitri Savineau <dsavinea@redhat.com>
2021-08-18 11:41:22 +02:00
Ronen Friedman
5778c8300f key_value_store: fix missing std
following the removal of 'using std' in PR #42742, and missed
in PR #42790.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2021-08-18 08:25:49 +00:00
Ilya Dryomov
463e40c6b4
Merge pull request #41968 from CongMinYin/fix-ssd-bug
librbd/cache/pwl/ssd: fix m_bytes_allocated exceeding m_bytes_allocated_cap

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2021-08-18 10:08:50 +02:00
Alfonso Martínez
6d7dfefafb
Merge pull request #42768 from s0nea/wip-dashboard-suppressed-alerts
mgr/dashboard: don't notify for suppressed alerts
2021-08-18 08:32:49 +02:00
Feng Hualong
f865a81355 blk/pmem: Add namespace std for map,string
Due to not use namespace std for map,string, it leads to
`map,string` not be declared.

Signed-off-by: Feng Hualong <hualong.feng@intel.com>
2021-08-18 13:52:50 +08:00
Kefu Chai
b1ca6e5021
Merge pull request #42758 from liewegas/gh-template
.github/pull_request_template: fix dashboard e2e test command

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-08-18 13:44:50 +08:00
Kefu Chai
53065cad3f
Merge pull request #42801 from ivancich/wip-update-rados-rm-help
doc: clarify use of `rados rm` command

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-08-18 11:46:45 +08:00
Kefu Chai
b21f9c5f73
Merge pull request #42822 from tchaikov/wip-drop-gdbm
ceph.spec.in: drop gdbm from build deps

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2021-08-18 11:36:02 +08:00
Kefu Chai
9d05d73374 ceph.spec.in: drop gdbm from build deps
neither gdbm nor libgdbm is used when building ceph, so let's drop it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-08-18 01:04:42 +08:00
Sebastian Wagner
c045701101
Merge pull request #42738 from sebastian-philipp/mypy-3.7
pybind/mgr: tox: also test mypy with python 3.7

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-08-17 16:37:15 +02:00
Kefu Chai
8c8a170da0
Merge pull request #42811 from tchaikov/wip-dashboard-test
mgr/dashboard/api: set a UTF-8 locale when running pip

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
2021-08-17 20:40:47 +08:00
Alfonso Martínez
bbee74edd1
Merge pull request #42732 from rhcs-dashboard/bug-1950644
mgr/dashboard: disable create snapshot with subvolumes
2021-08-17 14:35:24 +02:00
Alfonso Martínez
0f9d8eb953
Merge pull request #42717 from rhcs-dashboard/iscsi-target-refresh-btn
mgr/dashboard: Refresh button on the iscsi targets page
2021-08-17 14:32:49 +02:00
Sebastian Wagner
bcd127b46a
mgr/cephadm/upgrade: Upgrade status: We also upgrade non-ceph daemons
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
2021-08-17 14:27:40 +02:00
Ilya Dryomov
41b95ac987 librbd/cache/pwl/ssd: ensure bdev and pool sizes match
m_log_pool_size should be multiple of 1M but, just in case, prevent
is_valid_io() assert in KernelDevice::aio_write().

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2021-08-17 13:06:26 +02:00
Alfonso Martínez
1ebf69054e
Merge pull request #42786 from aaryanporwal/visual-tests
mgr/dashboard: visual tests: Add more ignore regions for dashboard component
2021-08-17 11:57:41 +02:00
Pere Diaz Bou
b38259b629 mgr/dashboard: disable create snapshot with subvolumes
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
2021-08-17 10:35:24 +02:00
Kefu Chai
be90b9e90b
Merge pull request #42808 from tchaikov/wip-crimson-test-cleanup
test/crimson: do not discard returned future<>

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-08-17 16:03:06 +08:00
Kefu Chai
05e4145856 mgr/dashboard/api: set a UTF-8 locale when running pip
ansible-core started to include files whose filenames are encoded in
non-ascii characters, so we have to use a more capable encoding for the
locale in order to install this package. otherwise we'd have following
error:

Collecting ansible-core<2.12,>=2.11.3
  Using cached ansible-core-2.11.4.tar.gz (6.8 MB)
ERROR: Exception:

Traceback (most recent call last):
  File "/tmp/tmp.fX76ASIrch/venv/lib/python3.8/site-packages/pip/_internal/cli/base_command.py", line 173, in _main
    status = self.run(options, args)
...
  File "/tmp/tmp.fX76ASIrch/venv/lib/python3.8/site-packages/pip/_internal/utils/unpacking.py", line 226, in untar_file
    with open(path, "wb") as destfp:
UnicodeEncodeError: 'latin-1' codec can't encode characters in position 137-140: ordinal not in range(256)

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-08-17 15:57:38 +08:00
Kefu Chai
89d168d635
Merge pull request #42807 from tchaikov/wip-crimson-test-more-chatty
test/crimson: re-enable logging output

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Xuehan Xu <xuxuehan@360.cn>
2021-08-17 15:01:45 +08:00
Kefu Chai
23878e4f67
Merge pull request #42791 from ideepika/wip-50947-blk-cmake
src/blk: fix block_device_t return if no aio libs present

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-08-17 14:32:32 +08:00
Kefu Chai
fc5d863117
Merge pull request #42800 from tchaikov/wip-cmake-debug-build
cmake: set CMAKE_BUILD_TYPE to Debug when .git exists

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
2021-08-17 14:28:07 +08:00
Kefu Chai
65df8b1e78 test/crimson: do not discard returned future<>
to silence following warning:

../src/test/crimson/seastore/test_randomblock_manager.cc:122:7: warning: ignoring return value of function declared with 'nodiscard' attribute [-Wunused-result]
      rbm_manager->add_free_extent(t.allocated_blocks, r.first * DEFAULT_BLOCK_SIZE,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-08-17 14:27:09 +08:00
Kefu Chai
a4f542f7c0 test/crimson: use structured binding
for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-08-17 14:27:09 +08:00
Kefu Chai
f8167f6883
Merge pull request #42798 from xxhdx1985126/wip-52275
crimson/common: allow the tls interrupt_cond to exist when a continuation starts to run

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-08-17 13:43:39 +08:00
Kefu Chai
39ce93d8e4 test/crimson: re-enable logging output
this change reverts 57877075c0

per Yingxin's request, we should enable it for better debugging
experience when the test fails.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-08-17 13:39:40 +08:00
Kefu Chai
4ef4148125
Merge pull request #42787 from rzarzynski/wip-crimson-fix-warn-storenbd
crimson/tools: silence [[maybe_unused]] warning in store-nbd.cc.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-08-17 13:07:25 +08:00
Yingxin Cheng
12008a84fa Revert "crimson/onode-staged-tree: force test work with invalidated transactions"
This reverts commit 8b6428c4ac.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-08-17 12:20:25 +08:00
Xuehan Xu
6160ad80e1 test/crimson: avoid creating interrupt condition within an already interruptible continuation chain
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2021-08-17 12:18:56 +08:00
Xuehan Xu
b1763cd331 crimson/common: assert the existence of interrupt_cond even in release builds
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2021-08-17 12:18:56 +08:00
Xuehan Xu
8bceb47531 crimson/common: allow the tls interrupt_cond to exist when a continuation starts to run
Release build of seastar invokes continuations synchronously if their predecessor futures
are resolved at the time when those continuations are constructed, so we have to allow
these circumstances to happen

Fixes: https://tracker.ceph.com/issues/52275
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2021-08-17 12:18:56 +08:00
Kefu Chai
52e28c4c39
Merge pull request #42658 from tchaikov/wip-doc-build
admin/build-doc: rebuild venv if md5 does not match

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
2021-08-17 11:26:07 +08:00
Patrick Donnelly
9f7f9327a6 Merge PR #42749 into master
* refs/pull/42749/head:
	doc: document that NEARFULL conditions can result in slow writes

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-08-16 19:15:37 -07:00
Kefu Chai
6e8bf43500
Merge pull request #42797 from rzarzynski/wip-crimson-no-prometheus-by-default
crimson/osd: disable Premetheous by default.

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-08-17 09:09:52 +08:00
Kefu Chai
6e394b447b cmake: set CMAKE_BUILD_TYPE to Debug when .git exists
if CMAKE_BUILD_TYPE is an empty string, we should also set it to Debug.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-08-17 08:47:33 +08:00
Kefu Chai
4152cef1e1 erasure-code/clay: do not set unreferenced variable
plane_count was introduced by 2a3e56b22c5b52e4834a9fd5047b3cdff7e8859f,
and presumably it is only used for debugging. let's drop it as it is not
referenced in production.

this change silences following warning:

../src/erasure-code/clay/ErasureCodeClay.cc:502:7: error: variable 'plane_count' set but not used [-Werror,-Wunused-but-set-variable]
  int plane_count = 0;
      ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-08-17 08:47:33 +08:00
Kefu Chai
621725ab47 erasure-code/lrc: early return if to_string() fails
so far to_string() always return 0, but it is designed to return
an error code if it fails to parse a string.

this change silences following warning:

../src/erasure-code/lrc/ErasureCodeLrc.cc:399:7: error: variable 'err' set but not used [-Werror,-Wunused-but-set-variable]
  int err = 0;
      ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-08-17 08:47:33 +08:00
Kefu Chai
dfc14d2a36 mds/CDir: do not set referenced variable
off is set by never get referenced, let's just drop it.

this variable was introduced by
0ec5f3a84a.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-08-17 08:47:33 +08:00
Liu-Chunmei
a4558a2d26
Merge pull request #42731 from liu-chunmei/seastore-alloc-extent-hint
crimson/seastore alloc extent hint

Replace L_ADDR_MIN by obj hash in onode, omap, object_data when alloc_extent.

 Reviewed-by: Sam Just <sjust@redhat.com> and Cheng, Yingxin <yingxin.cheng@intel.com>
2021-08-16 17:15:22 -07:00
Kefu Chai
658ecaec8e rgw: disable -Wimplicit-const-int-float-conversion conditionally
to silence warning like:

 unknown warning group '-Wimplicit-const-int-float-conversion', ignored [-Werror,-Wunknown-warning-option]
 #pragma clang diagnostic ignored "-Wimplicit-const-int-float-conversion"

clang-10 does not support this option yet.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-08-17 08:05:39 +08:00
J. Eric Ivancich
8e975ba9fd doc: clarify use of rados rm command
The man page did not make it clear that multiple objects could be
specified, nor did it describe use of "--force-full".

Info displayed about "rm" with `rados --help` was poorly formatted and
the wording was adjusted.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2021-08-16 18:28:07 -04:00
Ilya Dryomov
1fc722bc21 librbd/cache/pwl: make pool size a multiple of 1M
In ssd mode, we need it to be a multiple of bdev block size.
Instead of munging it after opening the bdev in ssd/WriteLog.cc, let's
impose a common restriction and round rbd_persistent_cache_size down to
a 1M boundary.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2021-08-16 23:07:59 +02:00
Chunmei Liu
1c0e6e7c8d crimson/seastore: change unit test using hint
Signed-off-by: Chunmei Liu <chunmei.liu@intel.com>
2021-08-16 13:56:08 -07:00