Commit Graph

118012 Commits

Author SHA1 Message Date
Kefu Chai
e181249148
Merge pull request #38624 from rzarzynski/wip-crimson-nopack-in-blocking_future
crimson/osd: drop arg packs from blocking_future.

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-12-17 09:28:39 +08:00
zdover23
ac439c7244
Merge pull request #38450 from zdover23/wip-doc-dev-guide-basic-workflow-auto-pr-valid-dec-2020-1
doc/dev: update auto pr validation section

Reviewed-by: Josh Durgin <jdurgin@redat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
2020-12-17 11:28:21 +10:00
Kefu Chai
596a746ef0
Merge pull request #38600 from agayev/master
os/bluestore: Fix code rot in ZonedAllocator.

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-12-17 09:02:49 +08:00
Kefu Chai
f55eb186f0
Merge pull request #38609 from ideepika/fix-yaml-failure
cmake: fix build failure due to yaml-cpp not available

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-12-17 08:05:44 +08:00
Kefu Chai
4294fcf005
Merge pull request #38608 from tchaikov/wip-crimson-build
rpm,deb: conditionally package crimson-store-nbd in ceph-test

Reviewed-by: Samuel Just <sjust@redhat.com>
2020-12-17 07:54:29 +08:00
Kefu Chai
f80a45202e
Merge pull request #38578 from cyx1231st/wip-seastar-onode-tree-fix-stage-type
crimson/onode-staged-tree: fix match_stage_t related compile issue

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-12-17 07:52:34 +08:00
Neha Ojha
37792040f4
Merge pull request #38625 from batrick/tox-fix
qa: fix tox failures

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2020-12-16 14:11:18 -08:00
Patrick Donnelly
123de8cda8
qa: fix tox failures
Fixes: c6121e48ec
Fixes: https://tracker.ceph.com/issues/48633
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2020-12-16 12:43:58 -08:00
Radoslaw Zarzynski
4d46497fd4 crimson/osd: drop arg packs from blocking_future.
This feature is not necessary as the `seastar::feature` lost
the support for `T...`.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-12-16 19:44:45 +01:00
Ernesto Puerta
355c855bc6
Merge pull request #38548 from rhcs-dashboard/wip-48570-master
github: add action to manage needs-rebase label

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
2020-12-16 18:16:58 +01:00
Patrick Donnelly
c6121e48ec
Merge branch 'CVE-2020-27781' into master
* CVE-2020-27781:
  tasks/cephfs/test_volume_client: Add tests for authorize/deauthorize
  pybind/ceph_volume_client: Optionally authorize existing auth-ids
  pybind/ceph_volume_client: Preserve existing caps while authorize/deauthorize auth-id
  pybind/ceph_volume_client: Disallow authorize auth_id

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
2020-12-16 08:19:21 -08:00
zdover23
9838e03b01
Merge pull request #38580 from anthonyeleven/anthonyeleven/48301-underscores
doc: standardize config option names with interstitial underscores

Reviewed-by: Zac Dover <zac.dover@gmail.com>
2020-12-17 01:11:53 +10:00
Yingxin Cheng
e488cabbdd crimson/onode-staged-tree: comment out excessive range checks
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2020-12-16 22:59:22 +08:00
Zac Dover
0eaf991bd8 doc/dev: update auto pr validation section
This commit updates the "Automated PR Validation"
section of the "Basic Workflow" page in the
Developer Guide. This is part of a project that
aims to clean all of the sentences currently extant
in the Dev Guide, prior to a slight reorganization
of that guide for the sake of clarity and simplicity.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2020-12-17 00:32:58 +10:00
Abutalib Aghayev
85e0944435 os/bluestore: Fix code rot in ZonedAllocator.
Signed-off-by: Abutalib Aghayev <agayev@psu.edu>
2020-12-16 09:05:40 -05:00
Deepika Upadhyay
29a932c292 install-deps.sh: add with_jaeger options for installing it's dependencies
* if WITH_JAEGER flag is specified, install-deps should mangle and update
  debian/control + ceph.spec the way we do for adding crimson dependencies
  with WITH_SEASTAR flag.

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2020-12-16 18:17:01 +05:30
Deepika Upadhyay
a8213f07b6 debian/control: update yaml-cpp version if building with Jaeger
jaeger specifically requires yaml-dev +0.6 but since all supported
distro(bionic) still doesn't have this version, yaml-cpp will be build
from source if enabled.
This fixes the build failure:
```
Could NOT find yaml-cpp: Found unsuitable version "", but required is at
  least "0.5.1" (found yaml-cpp_LIBRARY-NOTFOUND)
```

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2020-12-16 18:13:03 +05:30
Ernesto Puerta
e8ec1848ec
Merge pull request #38316 from rhcs-dashboard/temporary-lockout
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-12-16 13:29:22 +01:00
Ernesto Puerta
63a5cd41c8
Merge pull request #38534 from votdev/issue_48542_rgw_status
mgr/dashboard: The /rgw/status endpoint does not check for running service

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2020-12-16 13:27:32 +01:00
Mykola Golub
0e9ffeb7cb
Merge pull request #38536 from dillaman/wip-48553
librbd/mirror: unlink the third snapshot when the limit is reached

Reviewed-by: Mykola Golub <mgolub@suse.com>
2020-12-16 13:20:38 +02:00
Nizamudeen A
3f50b05e25 mgr/dashboard: Updating the docs regarding the user lockout
Fixes: https://tracker.ceph.com/issues/40914
Signed-off-by: Nizamudeen A <nia@redhat.com>
2020-12-16 16:14:47 +05:30
Nizamudeen A
41941f0d28 mgr/dashboard: Temporary User Lockout if 10 Invalid Login attempts
Implemented a user lockout mechanism if the user enters 10 invalid attempts. The attempt count gets resetted to 0 once the user succesfully logins before getting disabled. Once the user gets disabled administrator has to manually enable the user which will also resets the number of attempts.

Fixes: https://tracker.ceph.com/issues/40914
Signed-off-by: Nizamudeen A <nia@redhat.com>
2020-12-16 16:14:47 +05:30
Ernesto Puerta
f649030c73
Merge pull request #38606 from rhcs-dashboard/log-e2e-fix
mgr/dashboard: Fixing dashboard logs e2e test

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2020-12-16 11:43:54 +01:00
Nizamudeen A
0b2b172930 mgr/dashboard: Fixing dashboard logs e2e test
Yesterday there were some changes went in which disables the logging of config set and config-key set to to be logged in mgr audit logs. Dashboard has an e2e test which checks for this config set and broke the current e2e jenkins job. This commit removes that certain test to fix the jenkins job.

Fixes: https://tracker.ceph.com/issues/48623
Signed-off-by: Nizamudeen A <nia@redhat.com>
2020-12-16 14:43:00 +05:30
Kefu Chai
8e4cf7cbc5 debian: install crimson-store-nbd with pkg.ceph.crimson profile
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-12-16 15:55:51 +08:00
Kefu Chai
5af17733c7 rpm: package crimson-store-nbd in ceph-test package
when building with seastar enabled, package crimson-store-ndb in
"ceph-test" package. "crimson-store-nbd" is a new tool for testing
seastore using nbd.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-12-16 15:55:48 +08:00
Kefu Chai
1085472893
Merge pull request #38581 from cyx1231st/wip-seastar-msgr-fix-test-preemptive-shutdown
crimson/net: fix test_preemptive_shutdown() failure

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-12-16 13:58:05 +08:00
Josh Durgin
8a74a937dd
Merge pull request #31358 from ideepika/wip-jaegertracing-in-ceph
jaegertracing build/ops integration

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2020-12-15 16:29:26 -08:00
Anthony D'Atri
21d68cf137 doc: standardize config option names to use interstitial underscores
Ceph config option names may use spaces, underscores, or by one reference hyphens
as interstitial separators. Most usage within the doc tree uses underscores,
though example conf files and especially structured lists of options mostly
use spaces. Mostly. Underscores help differentiate the config names from
surrounding text, and moreover facilitate scripting, grep, awk, etc and match
their form in src/common/options.cc.

This PR conforms these occurrences of option names to use interstitial underscores instead of spaces.

Fixes: https://tracker.ceph.com/issues/48301
Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
2020-12-15 13:55:38 -08:00
Josh Durgin
351960345a
Merge pull request #38479 from neha-ojha/wip-37503-2
Do not add sensitive information in Ceph log files

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2020-12-15 12:06:39 -08:00
Jason Dillaman
067dc85af4
Merge pull request #38514 from lixiaoy1/rbd_types_fix
librbd/cmake: Add missed PWL related types

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-12-15 14:53:48 -05:00
Ernesto Puerta
0280349fef
Merge pull request #38546 from rhcs-dashboard/round-button
mgr/dashboard: Making the edges of not rounded button rounded

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2020-12-15 20:07:23 +01:00
Ernesto Puerta
0abb05d97e
Merge pull request #38269 from rhcs-dashboard/fix-44960-master
mgr/dashboard: replace cdCopy2ClipboardButton Directive with a component

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-12-15 19:51:45 +01:00
Ernesto Puerta
ba650bf561
Merge pull request #37937 from p-se/cd-alternative-grafana-fe-url
mgr/dashboard: enable different URL for users of browser to Grafana

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-12-15 19:47:30 +01:00
Ernesto Puerta
4c6bd8dd3b
github: add action to manage needs-rebase label
Fixes: https://tracker.ceph.com/issues/48570
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2020-12-15 19:09:28 +01:00
Ernesto Puerta
9a71e9e363
Merge pull request #36715 from rhcs-dashboard/fix-39128-master
mgr/dashboard: new generic HTTP error page component

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-12-15 18:59:14 +01:00
Ernesto Puerta
4abf4d9a4a
Merge pull request #38456 from SMIL-Infra/fix-crush-map-viewer
mgr/dashboard: Fix CRUSH map viewer VirtualScroll

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2020-12-15 18:57:03 +01:00
Courtney Caldwell
065fbf9603 mgr/dashboard: replace cdCopy2ClipboardButton Directive with a component
Replaces Directive-Based copy2ClipboardButton with a Component-based version.
Further replaces all instances of Directive use with Component version.
Similar toastr logic used.
Fixes: https://tracker.ceph.com/issues/44960

Signed-off-by: Courtney Caldwell <ccaldwel@redhat.com>
2020-12-15 11:41:18 -05:00
Neha Ojha
9f80520670 mon, messages: use TOPNSPC::common for crimson compatibility
Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-12-15 16:02:15 +00:00
Neha Ojha
f4b3d6b769 mgr/ActivePyModules.cc: don't log config value in get_typed_config
Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-12-15 16:02:15 +00:00
Neha Ojha
77932ae49b mon/ConfigMonitor.cc: don't log config values in refresh_config
Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-12-15 16:02:15 +00:00
Neha Ojha
19000fad57 mgr: don't add config values to mgr log in config_callback and module_config
The original code has been commented out and left for future debugging
purposes.

Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-12-15 16:02:15 +00:00
Neha Ojha
a68b459778 mon/ConfigMonitor.cc: don't dump all keys and values in config map
Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-12-15 16:02:15 +00:00
Neha Ojha
4b83dfb1f7 mon: don't log "config set" and "config-key set" dispatch and finished messages
Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-12-15 16:02:15 +00:00
Neha Ojha
3d54660ca1 messages/MMonCommand, MMonCommandAck: don't log values for "config set" and "config-key set"
This acts like a big hammer to avoid adding sensitive information, like passwords
into mon/mgr/cluster logs when using "config set" and "config-key set" to set keys
whose values should be secure.

Fixes: https://tracker.ceph.com/issues/37503
Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-12-15 16:02:06 +00:00
Casey Bodley
71b485f096
Merge pull request #38010 from cbodley/wip-rgw-doc-reshard-syncstop
doc/rgw: update reshard design regarding 'bucket sync disable'

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2020-12-15 08:51:07 -05:00
Kefu Chai
32921b7003
Merge pull request #38585 from tchaikov/wip-doc-dev-errorator
doc/dev/crimson: highlight code blocks using C++ lexer

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-12-15 20:28:57 +08:00
Kefu Chai
28408bb50f
Merge pull request #38582 from tchaikov/wip-crimson-cleanup
crimson/osd: cleanups

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-12-15 20:26:52 +08:00
Kefu Chai
c03415caf1 doc/dev/crimson: quote inline codeblock using "``"
backquote is used for quoting italic typed text.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-12-15 17:50:43 +08:00
Kefu Chai
370f04fa82 doc/dev/crimson: highlight code blocks using C++ lexer
also remove redundant ":", normally "::" would suffice to start a
codeblock.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-12-15 17:48:02 +08:00