* mimic.rst: add title underline
to address sphinx warning like:
```
WARNING: Title underline too short.
```
* octopus.rst: use consistent underline
to address following sphinx warning:
```
doc/releases/octopus.rst:49: WARNING: Title level inconsistent:
```
Signed-off-by: Kefu Chai <kchai@redhat.com>
cephadm: Check for pool existence for iscsi And NFS
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Fix "Error EINVAL: invalid size option '4915200.0'".
In pytho2 int/2 will get a int type result, but in python3 it maybe
a float type.
Fixes: https://tracker.ceph.com/issues/45247
Signed-off-by: Xiubo Li <xiubli@redhat.com>
Currently both iscsi and NFS require pools to be specified when they are
deployed. However, we don't actaully check these pools exist. Leading to
broken containers.
This patch uses the rados client that is part of the mgrmodule to check
that the specified pool exists. As we need to check in 2 different
daemons, a helper method:
def _check_pool_exists(self, pool, service_name):
was added to `cephadm/module.py`.
Fixes: https://tracker.ceph.com/issues/45161
Signed-off-by: Matthew Oliver <moliver@suse.com>
Traceback (most recent call last):
File "test_tmp/tmp.ykMmPiFqIT/cephadm", line 4578, in <module>
r = args.func()
File "test_tmp/tmp.ykMmPiFqIT/cephadm", line 1121, in _default_image
return func()
File "test_tmp/tmp.ykMmPiFqIT/cephadm", line 2489, in command_bootstrap
is_available('mgr', is_mgr_available)
File "test_tmp/tmp.ykMmPiFqIT/cephadm", line 895, in is_available
if func():
File "test_tmp/tmp.ykMmPiFqIT/cephadm", line 2486, in is_mgr_available
out = cli(['status', '-f', 'json-pretty'], timeout=timeout)
File "test_tmp/tmp.ykMmPiFqIT/cephadm", line 2403, in cli
return CephContainer(
File "test_tmp/tmp.ykMmPiFqIT/cephadm", line 2140, in run
out, _, _ = call_throws(
File "test_tmp/tmp.ykMmPiFqIT/cephadm", line 838, in call_throws
raise RuntimeError('Failed command: %s' % ' '.join(command))
Signed-off-by: Michael Fritch <mfritch@suse.com>
This is currently only utilized for the case where a newly created image
has mirroring enabled at time of creation, but it could be expanded in the
future if we track writes.
Fixes: https://tracker.ceph.com/issues/44596
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
If the image is clean, it's treated as if it was newly created and
therefore clean since snapshot id 0. The CreateRequest and
CloneRequest state machines pass true for this bool if mirroring
is being enabled during creation.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
This will be stored in the primary MirrorSnapshotNamespace for use by
the rbd-mirror snapshot replayer.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
It is only valid for primary snapshots so we can re-use the space
previously used by the primary_snap_id without the need to bump the
version id.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
This allows the user to enable mirroring while creating, cloning,
copying, importing, or migrating an image.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
The constructor that took an ImageCtx did not support passing the
non-primary global image id and instead defaulted to an empty string.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
If attempting to create a snapshot-based mirroring primary snapshot,
the image needs to first be opened. If we weren't supplied an image,
open the image, create the snapshot, and close the image again.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
