Commit Graph

137201 Commits

Author SHA1 Message Date
Matt Benjamin
3f2313f0e6 Do not duplicate query-string in ops-log
Fixes: https://tracker.ceph.com/issues/59059

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2023-03-14 20:46:09 -04:00
Neha Ojha
1e048aade9 doc/dev/release-checklists.rst: add after dev freeze section
- add release to redmine
- add milestone

Signed-off-by: Neha Ojha <nojha@redhat.com>
2023-03-14 18:45:30 +00:00
Ali Maredia
02172304dd
Merge pull request #50339 from cbodley/wip-qa-rgw-reef-upgrade
qa/rgw: add rgw/upgrade suite

Reviewed-by: Ali Maredia <amaredia@redhat.com>
2023-03-14 13:59:34 -04:00
Pere Diaz Bou
cde9233083
Merge pull request #50409 from rhcs-dashboard/formly
mgr/dashboard: replace ajsf with formly


Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2023-03-14 11:41:16 -04:00
Xiubo Li
254eeb2730 libcephfs: move ClearSetuid to suidsgid.cc
And rename it to ChownClearSetuid, which will test the chown only.

Fixes: https://tracker.ceph.com/issues/58680
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2023-03-14 23:01:46 +08:00
Xiubo Li
8886f5f5dd libcephfs: add test cases for dropping the suid/sgid in write/truncate
Write/truncate by privileged user leaves the suid and sgid and by
unprivileged user will clear them.

Fixes: https://tracker.ceph.com/issues/58680
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2023-03-14 23:00:31 +08:00
Xiubo Li
36416b2df5 libcephfs: add test cases for dropping the suid/sgid in fallocate
This test cases are from xfstests-dev's generic/684.

Fixes: https://tracker.ceph.com/issues/58680
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2023-03-14 22:58:44 +08:00
Xiubo Li
463b932fff libcephfs: fix ClearSetuid incorrectly using SETATTR_MODE mask
Both the STATX_MODE and SETATTR_MODE equal 1, so the test didn't
fail.

Fixes: https://tracker.ceph.com/issues/58680
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2023-03-14 22:54:05 +08:00
Xiubo Li
c5153d77fa client: switch to clear_suid_sgid for ftruncate
Currently the ftruncate will always clear the suid/sgid even the
privileged users are truncating the file. This isn't consistent with
all the other existing filesystems in Linux.

Fixes: https://tracker.ceph.com/issues/58680
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2023-03-14 22:54:05 +08:00
Xiubo Li
2f9d9b9ccc client: switch to clear_suid_sgid for _write()
Currently the write will clear the suid/sgid always even the
privileged users are writing the file. This isn't consistent with
all the other existing filesystems in Linux.

Fixes: https://tracker.ceph.com/issues/58680
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2023-03-14 22:54:05 +08:00
Xiubo Li
1a56bf2ce7 mds/client: clear the suid/sgid in fallocate path
There is no Posix item requires that we should clear the suid/sgid
in fallocate code path but this is the default behaviour for most of
the filesystems and the VFS layer. And also the same for the write
code path, which have already support it.

Fixes: https://tracker.ceph.com/issues/58680
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2023-03-14 22:54:05 +08:00
Xiubo Li
db10cfc807 client: allow unprivileged users to clear suid/sgid
The fallocate path will try to clear the suid/sgid if a unprivileged
user changed the file. And the VFS will set the ATTR_MODE and at the
same time by clearing the suid/sgid mode bits.

There is no Posix item requires that we should clear the suid/sgid
in fallocate code path but this is the default behaviour for most of
the filesystems and the VFS layer. And also the same for the write
code path, which have already support it.

Fixes: https://tracker.ceph.com/issues/58680
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2023-03-14 22:54:05 +08:00
Rishabh Dave
e3c6e15165
Merge pull request #45960 from rishabh-d-dave/xfstests-dev-run-more-tests
qa/cephfs: upgrade xfstests_dev.py to run more tests

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-03-14 20:13:02 +05:30
zdover23
334fbf20ee
Merge pull request #50390 from Svelar/vstart-doc
doc/crimson: add SeaStore when using vstart.

Reviewed-by: Zac Dover <zac.dover@proton.me>
2023-03-15 00:23:02 +10:00
Casey Bodley
75350e23c6
Merge pull request #48411 from liangmingyuanneo/wip-rgw-reshard-collision
rgw/reshard: fix hold reshard lock collisions

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-03-14 09:41:57 -04:00
Casey Bodley
a080d8cd84
Merge pull request #48482 from cbodley/wip-rgw-site-config
rgw: add SiteConfig to load/create zonegroup configuration

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2023-03-14 09:41:20 -04:00
Casey Bodley
a22b26eade
Merge pull request #50347 from cbodley/wip-rgw-sal-aio
rgw/aio: remove RGWSI_RADOS from generic Aio::get()

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2023-03-14 09:40:45 -04:00
Ilya Dryomov
f443eedd5e
Merge pull request #50343 from pkalever/fix-errormsg
librbd: report better errors when failing to enable mirroring on an image

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2023-03-14 14:28:26 +01:00
zdover23
5852e5a7f2
Merge pull request #50500 from jdurgin/wip-release-checklist
doc/dev/release-checklist: add another step for ceph-build

Reviewed-by: Neha Ojha <nojha@redhat.com>
2023-03-14 11:40:53 +10:00
Casey Bodley
7a1e4e67e7 rgw: add default Server response header
if a specific rgw_service_provider_name is not configured, add a default
Server response header that includes the ceph release name:

Server: Ceph Object Gateway (reef)

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-03-13 17:27:25 -04:00
Casey Bodley
f46ff8fcd9 Revert "rgw/beast: add extra_response_headers for Server name"
This reverts commit ffeacc0959.

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-03-13 17:18:39 -04:00
Ernesto Puerta
d26e5144f0
Merge pull request #50494 from rhcs-dashboard/fix-58942-main
mgr/dashboard: force TLS 1.3

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2023-03-13 20:01:01 +01:00
Pere Diaz Bou
2c43dd0c16 mgr/dashboard: replace ajsf with formly
ajsf json schema library for angular doesn't seem to be actively
maintained. Instead, fromly is a well maintained replacement with extra
stuff like validators builtin, support for json schemas, custom
components, etc...

Textareas weren't supported on ajsf, therefore, it made sense to move to
this dep instead.

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
Signed-off-by: Nizamudeen A <nia@redhat.com>
2023-03-13 19:55:14 +01:00
Casey Bodley
7288cbe280 rgw/s3: DeleteObjects response uses correct delete_marker flag
use delete_marker from the DeleteOp result, not from the sal::Object

Fixes: https://tracker.ceph.com/issues/59048

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-03-13 13:40:04 -04:00
Ernesto Puerta
a1071b499e
Merge pull request #50147 from cbodley/wip-debian-mgr-pytest
debian/mgr: remove pytest from debian/ceph-mgr-dashboard.requires

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2023-03-13 17:00:10 +01:00
Yuval Lifshitz
f0f7fc7a2e
Merge pull request #50282 from mhmdawnallah/fix-access-a-destructed-temporary-variable-in-rgw_sync_checkpoint
src/rgw/rgw_sync_checkpoint.cc: fix a destructed temporary variable access

reviewed-by: adamemerson, yuvalif
2023-03-13 17:46:34 +02:00
Laura Flores
831a41aff7
Merge pull request #50482 from neha-ojha/wip-milestore
.github/milestone.yml: add reef
2023-03-13 09:59:50 -05:00
Josh Durgin
4fcad7161f doc/dev/release-checklist: add another step for ceph-build
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
2023-03-13 07:45:07 -07:00
Venky Shankar
d73916c7cd Merge PR #50493 into main
* refs/pull/50493/head:
	qa: fixup quota values exceeding 64 bit signed int value
	qa, cleanup: no need to specify human readable quota values in comment

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2023-03-13 19:53:14 +05:30
Venky Shankar
14d341360b Merge PR #48382 into main
* refs/pull/48382/head:
	test: add test to validate attrs for snapdir after snap operations
	client: update {m,c}time and change attr for snapdir from last modification time of a snap realm
	mds: update last modification time and change attr for a snap realm node
	mds: include last modification time and change attr of a snap realm node in snap trace reply
	mds: use change_attr from closest ancestor when initializing a new snaprealm
	mds: initialize last_modified to current timestamp for root inode snaprealm
	mds: track last modification time and change attr for a snap realm node (srnode)

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
2023-03-13 19:26:59 +05:30
Venky Shankar
d140a71fce Merge PR #49970 into main
* refs/pull/49970/head:
	mds: force replay sessionmap version

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-03-13 19:24:38 +05:30
Venky Shankar
44f82d2327 Merge PR #50049 into main
* refs/pull/50049/head:
	qa: add cephfs_mirror test case to check root dir modes
	cephfs_mirror: sync snap dir root mode with remote dir

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-03-13 19:22:04 +05:30
Prasanna Kumar Kalever
828a0dea2d rbd: improve log msgs when failing to enable mirroring on image
Attempting to enable mirroring on an an image within a namespace bails
out without any useful msg.

$ rbd mirror image enable mi_pool/ns_0/big snapshot
2021-11-17T08:33:21.321+0000 7f4b36f9c2c0 -1 librbd::api::Mirror:
  image_enable: cannot enable mirroring in the current pool mirroring mode

Fixes: https://tracker.ceph.com/issues/58895
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
2023-03-13 18:18:51 +05:30
Rishabh Dave
1428fb1e73 qa/cephfs: minor corrections in caps_helper.py
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-03-13 17:45:57 +05:30
Zac Dover
ca803a24c6 doc/rados: edit operations/bs-migration (2 of x)
Disambiguate and improve the English language in
doc/rados/operations/bluestore-migration.rst up to but not including the
section called "Whole Host Replacement".

Co-authored-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-03-13 22:09:31 +10:00
Ernesto Puerta
cd8946631b
mgr/dashboard: force TLS 1.3
Fixes: https://tracker.ceph.com/issues/58942

Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2023-03-13 11:03:37 +01:00
Venky Shankar
ad7eb17266 qa: fixup quota values exceeding 64 bit signed int value
The test does the following:

        setfattr -n ceph.quota.max_bytes -v 8388608Ti .

This failes since 8388608Ti exceeds 64 bit signed integer value.
Change that to the approprivate value and expect faliure when
quota is set for this exceeded value.

Fixes: http://tracker.ceph.com/issues/55940
Introduced-by: 7330651482
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2023-03-13 14:42:13 +05:30
Matan Breizman
5b33995073 crimson/common/log: Fix debug logging macros
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-03-13 09:04:42 +00:00
Matan Breizman
0408337248 test/librados/snapshots*: Enable supported tests
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-03-13 08:55:48 +00:00
Venky Shankar
3286d478e7 qa, cleanup: no need to specify human readable quota values in comment
... since the values themselves are self-explanatory.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
2023-03-13 14:05:25 +05:30
Rishabh Dave
c4ce7221a0 qa/cephfs: run all generic tests from xfstests-dev
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-03-13 11:49:48 +05:30
Rongqi Sun
055bb2bd53 doc/crimson: add SeaStore when using vstart.
Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
2023-03-13 09:45:24 +08:00
Zac Dover
96166b463b doc/rados: edit operations/bs-migration (1 of x)
Disambiguate and improve the English language in
doc/rados/operations/bluestore-migration.rst up to but not including the
section called "Whole Host Replacement".

Co-authored-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-03-13 10:11:37 +10:00
Casey Bodley
b929958f0f rgw/rados: copy_obj_data() can use yielding throttle
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-03-12 19:52:41 -04:00
Casey Bodley
646db2175f rgw: RGWRealmReloader reloads rgw::SiteConfig
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-03-12 19:07:38 -04:00
Casey Bodley
7e36bd5c8f rgw/main: init_storage() creates a ConfigStore and loads SiteConfig
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-03-12 19:05:22 -04:00
Casey Bodley
f887f9a8b6 rgw: add SiteConfig to load/create zonegroup configuration
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-03-12 19:05:22 -04:00
Casey Bodley
6bd867fe72 rgw/main: null-initialize pointer members
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-03-12 19:05:22 -04:00
Casey Bodley
0e2e7d594b
Merge pull request #50383 from cbodley/wip-rgw-admin-formatter-v2
rgw/admin: fix formatter leaks again

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2023-03-12 19:00:44 -04:00
Casey Bodley
e587a71aff test/rgw: ceph_test_rgw_throttle no longer needs rados
run it as a unittest instead of a workunit

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-03-12 18:56:54 -04:00