RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2024-12-25 21:03:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

libcephfs: fix ClearSetuid incorrectly using SETATTR_MODE mask

Browse Source 
Both the STATX_MODE and SETATTR_MODE equal 1, so the test didn't
fail.

Fixes: https://tracker.ceph.com/issues/58680
Signed-off-by: Xiubo Li <xiubli@redhat.com>
This commit is contained in:
Xiubo Li 2023-03-14 11:16:53 +08:00
parent c5153d77fa
commit 463b932fff
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/test/libcephfs/test.cc
View File

@ -2116,7 +2116,7 @@ TEST(LibCephFS, ClearSetuid) {
stx.stx_gid = g;
mode_t m = S_ISGID|S_ISUID|S_IRUSR|S_IWUSR;
stx.stx_mode = m;
ASSERT_EQ(ceph_ll_setattr(cmount, in, &stx, CEPH_STATX_MODE|CEPH_SETATTR_UID|CEPH_SETATTR_GID, rootcred), 0);
ASSERT_EQ(ceph_ll_setattr(cmount, in, &stx, CEPH_SETATTR_MODE|CEPH_SETATTR_UID|CEPH_SETATTR_GID, rootcred), 0);
ASSERT_EQ(ceph_ll_getattr(cmount, in, &stx, CEPH_STATX_MODE, 0, altcred), 0);
ASSERT_EQ(stx.stx_mode&(mode_t)ALLPERMS, m);
/* not dropped without exe bit */