Use same_interval_since set to zero to communicate that an import has happened
and the correct value needs to be computed.
Fixes: #10794
Signed-off-by: David Zafman <dzafman@redhat.com>
RPM spec files summary should not end with a dot.
This was inconsistent across the ceph rpm packages
and creates errors with rpm lint.
Signed-off-by: Owen Synge <osynge@suse.com>
Dont bail out if the input value happens to be .
Fixes: #11620
Signed-off-by: Rajesh Nambiar <rajesh.n@msystechnologies.com>
Tested-by: Sage Weil <sage@redhat.com>
Update the ErasureCodeShec::init function to use string default
values. The default profile values for technique, ruleset-root and
ruleset-failure-domain are set for the user to see.
The error message when an invalid technique is provided is written to
the error stream to be returned to the user instead of being written to
the OSD log.
Updating other values from the profile would require deeper changes and
is left for later.
http://tracker.ceph.com/issues/9589Fixes: #9589
Signed-off-by: Loic Dachary <ldachary@redhat.com>
Update the ErasureCodeLrc::init function to use string default values
and update the profile accordingly.
If the k,m,l values are set and generate mappings and layers entries,
those are not stored in the profile. The details of what k,m,l create
are private and not exposed to the caller.
http://tracker.ceph.com/issues/9589Fixes: #9589
Signed-off-by: Loic Dachary <ldachary@redhat.com>
Update the ErasureCodeJerasure::init function to use string default values
and update the profile accordingly.
The ErasureCodeJerasure::revert_to_default prototype is modified so it
can update the profile.
http://tracker.ceph.com/issues/9589Fixes: #9589
Signed-off-by: Loic Dachary <ldachary@redhat.com>
Update the ErasureCodeIsa::init function to use string default values
and update the profile accordingly.
Also fix a bug by which the plugin would incorrectly report using the
default technique when the reed_sol_van or cauchy techniques are the
only legitimate values.
http://tracker.ceph.com/issues/9589Fixes: #9589
Signed-off-by: Loic Dachary <ldachary@redhat.com>
The to_int, to_bool prototypes are modified and the default values are
changed to string instead of int. If a default value is set, the profile
is modified to contain the default value.
The to_string helper is added so it can be used to set the default value
of a string, in a way that is consistent with to_int and to_bool.
http://tracker.ceph.com/issues/9589Fixes: #9589
Signed-off-by: Loic Dachary <ldachary@redhat.com>
Interestingly enough, the function is not even entirely idempotent:
it prints debugging output, duplicated.
Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
Instead of removing the | when an alternative is found in the control
file such as
cryptsetup-bin | cryptsetup
remove the surrounding spaces so that it is treated as a regular
expression that matches either one.
Replace the form
sudo bash -c "FOO=bar ..."
with
sudo env FOO=bar ...
to reduce the levels of shell escaping.
Reported-by: http://dyweni.com/
Signed-off-by: Loic Dachary <ldachary@redhat.com>
The wheel and pip module must not only be installed in each wheelhouse
directory for tox to find. They must also be installed in the virtual
environment that populates the wheelhouse directory. Otherwise older pip
modules such as the one found by default on Ubuntu 12.04 will fail.
Python 2.7.3 on Ubuntu 12.04 also requires that distribute >= 0.7.3 is
installed although it is redundant with setuptools, otherwise it will
fail to run the wheel module.
Signed-off-by: Loic Dachary <ldachary@redhat.com>
Otherwise we can reorder an op around another op which got blocked by a
scrub which started after the first blocked on an obc.
Fixes: #11691
Signed-off-by: Samuel Just <sjust@redhat.com>
os/chain_xattr: cope with xfs limit of 254 bytes for inlined xattrs.
Reviewed-by: Haomai Wang <haomaiwang@gmail.com>
Reviewed-by: Ning Yao <zay11022@gmail.com>
Replicated: For COPY_GET, only src has data/omap digest, the dst can do.
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
