mgr/nfs: clarify in the output message
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
The inter-connectedness of RadosStore and RGWRados resulted in a
segfault during RGWRados::init_complete due to the rados pointer not
being set in RadosStore yet.
Split the calls to RGWRados::initialize and RGWRados::init_complete, so
that we can set up RadosStore between them, allowing the services
created in RGWRados::init_complete to access the RadosStore.
Fixes: https://tracker.ceph.com/issues/55512
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
The pgcalc tool has moved to the "old" ceph site so update
the link to avoid a 404.
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
The pgcalc tool has moved to the "old" ceph site so update
the link to avoid a 404.
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
Ioctx.get_stats() had a typo in return value documentation
block so add the "c" in "objects".
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
Fix invalid syntax where "linenos:" was printed in the
final rendered documentation instead of being used as
formatting syntax.
There is no need to use sudo for editing a source file
so run vim without sudo.
Change the whole block to use bash prompt since it is
a command.
Also modify the preceding text to hopefully not bold it.
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
because bucket object is created only after authentication,
if bucket object is null upon accessing Request.Bucket.Name, we return req_state->init_state.url_bucket
Signed-off-by: Omri Zeneva <ozeneva@redhat.com>
In cephadm service management documentation several of the
ceph orch commands are missing the ceph part, mostly in
ceph orch apply commands but not all of them.
Add ceph in the front of the command to make them consistent
with all other commands.
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
rgw: address crash and race in RGWIndexCompletionManager
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Adding LoggerSinkSet, an abstract API that enables unit-testing
of OSD components that emit cluster-log messages, and trapping the
logs.
First usage example is in the Scrubber backend unit-tests.
The log "implementation" there (note the error counter that
can be used to determine tests success):
class MockLog : public LoggerSinkSet {
public:
void warn(std::stringstream& s) override
{
std::cout << "\n<<warn>> " << s.str() << std::endl;
}
void error(std::stringstream& s) override
{
err_count++;
std::cout << "\n<<error>> " << s.str() << std::endl;
}
...
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Reformatting the OSD scrub code files to match styleguide.
Specifically:
- force 80-cols lines; and
- (sadly) force 'use tabs' (replacing each 8 indentation
blanks with a tab.
clang-format version used: 13
Configuration file used is detailed in PR comment.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
The example commit didn't show the convention of prefixing the message with
the relative directory path where the file lives, which has led new
contributors to innocently submit changes that aren't formatted ideally.
This adds a path to the example.
Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
Iterator-bounding feature is introduced to make RocksDB iterators limited, so they
would less likely traverse over tombstones.
This is used when listing keys in fixed range, for example OMAPS for specific object.
It is problematic when extending this logic to WholeSpaceIterator,
since prefix must be taken into account.
Fixes: https://tracker.ceph.com/issues/55444
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
This commit adds logic to automatically detect when sse-s3 is
available and if not, disables sse-s3 tests by default.
Configuration opions are provided to override the default either way.
Signed-off-by: Marcus Watts <mwatts@redhat.com>
For debugging purposes, allow radosgw-admin to run with stores other
than RadosStore. Many operations will still fail (by crashing), so care
must be taken when running this way.
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
DBStore, and some other Stores like Motr, don't need to connect to the
Mons to work. However, startup automatically connects to the mons.
There's provision to not connect, but the split isn't quite right. We
need to call global_pre_init() to get config from the file, to determine
which store to start, but we then need to decide before calling
global_init() whether the configured store needs to connect to the mons.
This requires a slight change to global_init() to set no_mon_config from
the new flags.
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
.. of NFS and ingress services after creating/deleting a NFS cluster.
The `nfs cluster info` command is not sufficient to show that the
NFS cluster is created/deleted as expected.
Signed-off-by: Ramana Raja <rraja@redhat.com>
