rgw: add logging to bucket listing so calls are better understood
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Ali Maredia <amaredia@redhat.com>
mgr/dashboard: fetch host facts only if get_facts orch feature available
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
crimson/osd: fix network address selection for hearbeat's messengers.
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
For the sake of compliance with the classical OSD where the type
of the listening address is being reflected in the address type
of an accepted connection:
```
int PosixServerSocketImpl::accept(ConnectedSocket *sock, const SocketOptions &opt, entity_addr_t *out, Worker *w) {
// ...
sockaddr_storage ss;
// ...
int sd = accept_cloexec(_fd, (sockaddr*)&ss, &slen);
if (sd < 0) {
return -ceph_sock_errno();
}
// ...
out->set_type(addr_type);
out->set_sockaddr((sockaddr*)&ss);
handler.set_priority(sd, opt.priority, out->get_family());
}
```
In Rook crimson binds explicitly to v2 address:
```
INFO 2021-10-26 17:55:08,116 [shard 0] osd - picked address v2:0.0.0.0:0/0
ERROR 2021-10-26 17:55:08,116 [shard 0] none - Falling back to public interface
INFO 2021-10-26 17:55:08,116 [shard 0] osd - picked address v2:0.0.0.0:0/0
```
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Allow user to specify cookie of choice at the time of map
$ rbd device attach rbd-pool/image --device /dev/nbd0 \
--cookie 6f85d970-10b2-456b-8baf-676aa4d782e4 --options try-netlink
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Fixes: https://tracker.ceph.com/issues/52981
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Gather facts in UI should only be fetched if there is orch available and
get_facts feature is available for that orch backend.
Fix the Total Memory coming up as NaN Undefined
Remove `Add` Button in the Cluster Details table
Fixes: https://tracker.ceph.com/issues/53038
Signed-off-by: Nizamudeen A <nia@redhat.com>
mgr/dashboard: Proper error handling in module status guard
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
mgr/dashboard: Fix for form inside form closing issue
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
crimson/net: don't enforce peer-perceived-myaddr matches myaddr if haven't learned it yet.
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reducing the size of split_merge_multi has an interesting side effect of
causing removes to happen on some leaf nodes immediately after split.
After split, child nodes would have size 72 or 73. At size 72, the node
would be at_min_size() and a remove would put it below causing the
at_min_size() condition to fail and hande_merge to misbehave.
Replace at_min_capacity() with below_min_capacity().
below_min_capacity() will not be true for any child of a split, and
asserts that the child is below capacity by no more than 1.
Signed-off-by: Samuel Just <sjust@redhat.com>
Clarify that lookup_depth_range may return an iterator at_boundary() and
audity users.
Fix LBABtree::lookup to correctly handle at_boundary() after the call to
lookup_depth_range.
Fixes: https://tracker.ceph.com/issues/52805
Signed-off-by: Samuel Just <sjust@redhat.com>
From an external caller, the condition is identical. However, internally
iterators may be at a leaf boundary without being at end(). For those
checks, use at_boundary() instead.
Signed-off-by: Samuel Just <sjust@redhat.com>
The logic to bucket listing is complex due to the sharded bucket
indicies. When a log is examined, there should be enough information
to follow the logic.
Logging that touches every entry listed is at 20. Logging that
describes exiting of the listing are at level 10.
Additionally make logging more uniform and streamlined. Remove "INFO"
as that seems redundant (but keep "ERROR" and "WARNING"). Dispense
with class name decorating function name since there aren't any
similar function names.
Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
