* refs/pull/40500/head:
doc/cephadm: remove keepalived_user from haproxy docs
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>
Using subscription-manager will fail in a container so use dnf
config-manager which should work on bare metal as well as in a
container.
Fixes: https://tracker.ceph.com/issues/50118
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
it can be replaced with entity_name_t::parse(string_view)
also refactor entity_name_t::parse(string_view) a little bit, to
embed the logic of `entity_name_t::parse(const char*...)` in it.
Signed-off-by: Kefu Chai <kchai@redhat.com>
in 6147c09171, "lo" is also skipped when
daemon is trying to find an address to bind. but that change reverts the
fix of 201b592043, to address the problem.
an option named "ms_bind_exclude_lo_iface" is added, it defaults to
"true". but it can be changed to false to allow daemon to bind on "lo".
Fixes: https://tracker.ceph.com/issues/50012
Signed-off-by: Kefu Chai <kchai@redhat.com>
* do not replicate the same logic in IPv4 and IPv6 paths
* use helpers returning bool for filtering the candidate addresses
for better readability
Signed-off-by: Kefu Chai <kchai@redhat.com>
crimson/osd: include headers at where they are used
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Before the change an error handler (a callable passed as second
or further parameters to `safe_then()`) was supposed to return
`seastar::future<..>` if it handled the errors or one of allowed
error types otherwise (like `crimson::ct_error::enoent`). Now
they may return also an erroratored future (`errator<ErrorT>::future<...>`)
and its error-set will fused with other sources of errors to be
included in errorator `safe_then()` returns.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Before this commit there was an inconsistencty between
`unthrowable_wrapper::handle()` and `stateful_error_t::handle()`
in the regard of parameters the provided handler had to accept.
The former was fine with void-taking handlers while the latter
was not.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Well, likely all the commit does is just appending a couple
of extra bytes. Though, strictly juding, a func should be
`std::move()`d before calling in those cases. Otherwise we
can miss e.g. the `operator() &&` overload.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
The indentation is misleading. For example,
mgr advanced mgr/telemetry/last_opt_revision 3 *
osd advanced osd_max_backfills 10
osd basic osd_memory_target 6442450944
osd advanced osd_scrub_auto_repair true
mds.ar basic mds_join_fs ar
client.rgw.foo basic rgw_frontends beast port=8080 *
The indentation kind of implies that mds.ar (or client.whatever) is
beneath 'osd', which it is not, and there rarely a 'client' scoped
option to make it look right. Same problem for osd.foo etc.
Also, it is IMO easier to see the nesting structure when things align
naturally. e.g.
global
osd
osd.1
osd.2
mds
mds.foo
mds.foo.bar
client.foo.bar
...
Signed-off-by: Sage Weil <sage@newdream.net>
do not render the links in "important" block in gray, it's not
readable in light red background. so use the blue and purple colors
specified by sphinx_rtd_theme.
Signed-off-by: Kefu Chai <kchai@redhat.com>
