Commit Graph

114862 Commits

Author SHA1 Message Date
Nathan Cutler
ccc13cbff4 doc: cephfs: clarify that pseudo root path must be absolute
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2020-09-08 08:34:29 +02:00
Nathan Cutler
6f0c2496d6 doc: cephfs: fix misleading "ceph fs volume create" command
The "ceph fs volume create" command takes a placement string,
just like "ceph nfs cluster create" does. Align the documentation
so the placement string is explained in the same manner in both
places.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
2020-09-08 08:34:29 +02:00
Nathan Cutler
865001247b doc: cephfs: fix misleading "ceph nfs create" command
When a reader sees "ceph nfs create <type=cephfs>" it's not
clear that this means they should type "ceph nfs create cephfs".

I also took this opportunity to clarify the command description
based on my testing and discussions with the CephFS developers.

Fixes: https://tracker.ceph.com/issues/46559
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2020-09-08 08:34:29 +02:00
Kefu Chai
056d8776ce
Merge pull request #37003 from xxhdx1985126/wip-47310
crimson/osd: drop repop if osdmap has increased

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-08 13:38:51 +08:00
Venky Shankar
7251caf7e1
Merge pull request #36974 from jan--f/snap-schedule-keep-with-empty-retention
snap-schedule: don't prune all on empty retention
2020-09-08 10:15:28 +05:30
Xuehan Xu
2c17bc1933 crimson/osd: add can_discard_op method for detecting "discardable" client requests
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2020-09-08 12:36:41 +08:00
Xuehan Xu
e9ac113f4f crimson/osd: drop repop if it can be discarded
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2020-09-08 12:36:06 +08:00
Xuehan Xu
ab849a1378 crimson/osd: rename is_valid_rep_op_reply to can_discard_replica_op
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2020-09-08 12:35:14 +08:00
Sebastian Wagner
3627cd1e5c
Merge pull request #36903 from sebastian-philipp/python-common-simplify-hsp-to-json
python-common: Make HostPlacementSpec.to_json() more friendly

Reviewed-by: Adam King <adking@redhat.com>
2020-09-07 17:58:29 +02:00
Nathan Cutler
839c8ec6ba
Merge pull request #36994 from ktdreyer/boost-context-s390x
rpm: enable WITH_BOOST_CONTEXT for s390x

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
2020-09-07 12:39:12 +02:00
Sebastian Wagner
75d9369a02
Merge pull request #36432 from sebastian-philipp/cephadm-repo_digest
mgr/cephadm: convert tags to repo_digest

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
Reviewed-by: Varsha Rao <varao@redhat.com>
2020-09-07 11:57:51 +02:00
Kefu Chai
425b2167dc
Merge pull request #37015 from tchaikov/wip-seastar-packet
common/buffer_seastar: reserve the packet slots in ctor

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-09-07 17:44:05 +08:00
Sebastian Wagner
428125f8a4
Merge pull request #36946 from zdover23/wip-docs-36796-fix
doc/cephadm: Document mgr/cephadm/manage_etc_ceph_ceph_conf

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2020-09-07 10:48:27 +02:00
Sebastian Wagner
b54e270930
Merge pull request #36995 from smithfarm/wip-47305
rpm: on SUSE, podman is required for cephadm to work

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-09-07 10:39:25 +02:00
Kefu Chai
1ef86021ca
Merge pull request #36992 from uweigand/fix-encode-float
include/encoding: Fix encode/decode of float types on big-endian systems

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-07 14:50:37 +08:00
Kefu Chai
b13c14b6e8
Merge pull request #36829 from changchengx/osdmap
crush,osd: refine crushmap comment and implementation

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-07 14:49:08 +08:00
Kefu Chai
e3e6d30d37
Merge pull request #36947 from pdvian/wip-mgr-get-rule-root
mgr/mgr_module : Fix keyerror for op if rule steps first element is opcode

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-07 14:46:52 +08:00
Kefu Chai
bc4255ba2c
Merge pull request #36972 from smithfarm/wip-47112
rpm,deb: drop /etc/sudoers.d/cephadm

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: David Disseldorp <ddiss@suse.de>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-07 14:44:44 +08:00
Kefu Chai
7b23ddf13b
Merge pull request #36937 from tchaikov/wip-mgr-cleanup
mgr: use range-based loop and cleanups

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-09-07 14:42:01 +08:00
Kefu Chai
f236ead710
Merge pull request #36999 from neha-ojha/wip-47309
qa/*/mon/mon-last-epoch-clean.sh: mark osd out instead of down

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-07 14:40:51 +08:00
Kefu Chai
11ca0cdad0
Merge pull request #37008 from tchaikov/wip-crimson-pg-tell
crimson/osd: add "ceph tell <pgid> <command>" support

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2020-09-07 14:39:44 +08:00
Kefu Chai
94ca7736da common/buffer_seastar: reserve the packet slots in ctor
for better performance, and simpler this way

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-07 14:07:29 +08:00
Kefu Chai
2425c4b4de
Merge pull request #37010 from tchaikov/wip-crimson-osd-net
crimson/net: move implementation into .cc file

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2020-09-07 13:00:14 +08:00
Kefu Chai
df10f54f71
Merge pull request #37001 from tchaikov/wip-crimson-basic
qa/suites: add crimson-rados/basic tests

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-09-07 09:52:45 +08:00
Patrick Donnelly
c0d5d348e5
Merge PR #36600 into master
* refs/pull/36600/head:
	mds: make caps dump more readable

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Zheng Yan <zyan@redhat.com>
2020-09-06 08:54:38 -07:00
Kefu Chai
dfe6dd96c2 crimson/osd: add "ceph tell <pgid> <command>" support
* add an abstract class of `PGCommand` for `ceph tell <pgid> <command>`
* add two sample implementations for the pg tell commands.
  - "query"
  - "mark_unfound_lost"

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-06 21:49:34 +08:00
Changcheng Liu
57873ca779 crush/CrushWrapper: refine type_map/name_map comment
type_map is the item(bucket & device) type id and its type name.
name_map is the item(bucket & device) id and its name.

Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
2020-09-06 21:01:52 +08:00
Changcheng Liu
92d43dabbd crush/CrushWrapper: use "new_bucket_id" as var name of the added bucket
Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
2020-09-06 21:01:52 +08:00
Changcheng Liu
0d87e967dd crush/CrushWrapper: align variable name with comment
In the prolog of "for loop" statement, it writes "add child in the
location with 0 weight"

Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
2020-09-06 21:01:52 +08:00
Changcheng Liu
dce22e308f osd/OSDMap: no need to give same locations per time to create bucket
Suggested-by: Kefu Chai <kefu@redhat.com>
Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
2020-09-06 21:01:52 +08:00
Changcheng Liu
159028ef52 crush/CrushWrapper: refine comment to improve readability
Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
2020-09-06 21:01:52 +08:00
Changcheng Liu
0601a86ef1 osd/OSDMap: assert osd_weight default initialized value is CEPH_OSD_OUT
refer: http://www.cplusplus.com/reference/vector/vector/resize/
Explicitly specify initialization value to vector::resize operation.

Suggested-by: Kefu Chai <kefu@redhat.com>
Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
2020-09-06 20:58:34 +08:00
Changcheng Liu
076575909d osd/OSDMap: use class member instead of parameter to reset container size
Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
2020-09-06 20:57:19 +08:00
Changcheng Liu
02abda0214 osd/OSDMap: avoid re-initialize osd state and weight done in set_max_osd
In set_max_osd function, container's osd_weight and osd_vector have been
assigned with the right state/weight value.

Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
2020-09-06 20:57:11 +08:00
Changcheng Liu
b422be8191 crush: correct typo
Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
2020-09-06 20:56:59 +08:00
Changcheng Liu
51ae2909ef crush: no need to double check root bucket id
root bucket id should be definitely less than 0. assert(r < 0) here.
There's no possible to find device items in find_nonshadow_roots.

Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
2020-09-06 20:56:59 +08:00
Ulrich Weigand
f1f8b9f93b include/encoding: Fix encode/decode of float types on big-endian systems
Currently, floating-point types use "raw" encoding, which means they're
simply copied as byte stream.

This means that if the decoding happens on a machine that differs in
byte order from the source machine, the returned value will be
incorrect. As one effect of this problem, a big-endian OSD node cannot
join a cluster where the MON node is little-endian (or vice versa),
because the OSDMap (incremental) structure contains floating-point
values, and as a result of this conversion problem, the OSD node will
crash with an assertion failure as soon as it receives any OSDMap update
from the MON.

This should be fixed by always encoding floating-point values in
little-endian byte order just as is done for integers. (Note that this
still assumes source and target machines used the same floating-point
format except for byte order. But given that nearly all platforms these
days use IEEE binary32/binary64 for float/double, that seems a
reasonable assumption.)

Fixes: https://tracker.ceph.com/issues/47302

Signed-off-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
2020-09-06 13:28:07 +02:00
Kefu Chai
2931862bd8
Merge pull request #36924 from ddiss/sigabbrev_np
cmake: detect and use sigdescr_np() if available

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
2020-09-06 18:45:58 +08:00
Kefu Chai
babb98de46
Merge pull request #36929 from tchaikov/wip-python-common-no-unicode
python-common: s/unicode/str/

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-09-06 18:44:37 +08:00
Kefu Chai
36bfc0f429 crimson/net: move implementation into .cc file
for faster compilation.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-06 18:33:34 +08:00
Kefu Chai
4bfd9ba125
Merge pull request #37007 from xxhdx1985126/wip-47313-47311
crimson/osd: accurately judge whether to do drop_recovery_read on recovering objs

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-06 16:26:07 +08:00
Kefu Chai
ad091ca723
Merge pull request #37004 from tchaikov/wip-discard-repop
crimson/osd: discard op if pg changes or sender is down

Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
2020-09-06 16:00:36 +08:00
Kefu Chai
19167af61f crimson/osd: add PG::mark_unfound_lost()
it is a stub implementation for supporing asock command

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-06 15:30:15 +08:00
Kefu Chai
acfa6ea4a5 crimson/osd: add PG::dump_primary()
for implementing asock command "ceph tell 1.0 query"

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-06 15:30:15 +08:00
Kefu Chai
ba9e6c830a crimson/osd: drop unused header
osd_admin.h is referenced in the .cc file, so drop it in the header

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-06 15:30:15 +08:00
Kefu Chai
8dc68d3c1a crimson/osd: add OSD::get_pg()
for implementing asock commands.

and add `PGMap::get_pg()` as a helper

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-06 15:30:15 +08:00
Kefu Chai
fa3fb1de4e osd: refactor PrimaryLogPG::do_command("query")
we should let recovery_state.dump_peering_state() close the formatter
section, because it's recovery_state.dump_peering_state(), who opens it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-06 15:30:15 +08:00
Kefu Chai
4f88eaf8fa osd/PGStateUtils: do not forward declare unused class
PG is not referenced in this header

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-06 15:30:15 +08:00
Kefu Chai
5ab409dd18 crimson/osd: print pgid in OSD::load_pg()
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-06 15:30:15 +08:00
Kefu Chai
4b3200ea50 crimson/os: fix indent
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-06 15:30:15 +08:00