the inc_pending + promise<> solution is pratically identical to
seastar::gate, so let's use the prepackaged solution instead.
Signed-off-by: Kefu Chai <kchai@redhat.com>
* remove unix domain socket file when cleanup
so we don't need to remove it manually after each run.
* shutdown input and output streams when cleanup
so reactor does not watch them anymore.
Signed-off-by: Kefu Chai <kchai@redhat.com>
rgw: clean-up logging of function entering to make thorough and consistent
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Ali Maredia <amaredia@redhat.com>
This provides more thorough and consistent function tracing in CLS/RGW
when logging is set to 10 or higher.
Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
This commit comments out the OSD creation functions in rook_cluster.py
and module.py, since the submodule update has broken them.
Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
This commit fixes some errors caught by mypy in rook_cluster.py. Most of the
errors were caused by the update of the rook-client-python submodule in a previous
commit.
Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
This commit passes the zone attribute to the CephObjectStore CR when
creating a RGW instance using the Rook Orchestrator backend:
`ceph orch apply rgw <rgw-name> --realm=<realm-name> --zone=<zone-name>`
Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
When you add a host in maintenance mode and then exit the maintenance
mode, a 500 server error will popup which will interrupt the whole
exit maintenance process and leave the host in an unknown/offline state.
It happened when I was setting the status of the host through the
HostSpec(). With this change, I am using the enter_maintenance api of
the orch to enable the maintenance.
Fixes: https://tracker.ceph.com/issues/51218
Signed-off-by: Nizamudeen A <nia@redhat.com>
and disable app_cfg.auto_handle_sigint_sigterm, otherwise app template
handles SIGINT and SIGTERM by itself, and calls app.stop(). but we don't
use this mechinary at all. we use seastar::defer() instead of
seastar::at_exit() for doing graceful shutdown and cleanup.
Signed-off-by: Kefu Chai <kchai@redhat.com>
we could have more sophisticate mechinary for interrupting fio job,
but so far it is able to stop itself if it idle by handling ctrl-C.
Signed-off-by: Kefu Chai <kchai@redhat.com>
This PR removes "Octopus" from the curl-based installation
procedure.
After we moved on to Pacific, referring to Octopus looks wrong.
It looks wrong because it now is wrong.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
because we should only ensure the ordering of the requests touching
the objects, the other requests like pgls should not be ordered along
with them. so as the second step, guard the non-pg-op handling with
with_sequencer().
Signed-off-by: Kefu Chai <kchai@redhat.com>
for better performance, also silences the warning like:
../src/crimson/os/seastore/random_block_manager/nvme_manager.cc:444:23: warning: loop variable ‘b’ creates a copy from type ‘const crimson::os::seastore::rbm_alloc_delta_t’ [-Wrange-loop-construct]
444 | for (const auto b : alloc_blocks) {
| ^
Signed-off-by: Kefu Chai <kchai@redhat.com>
so finally() is able to identify the return is a future, and discard it
manually.
otherwise the return value will be discarded even the future is marked
[[nodiscard]], hence the C++ compiler warns.
Signed-off-by: Kefu Chai <kchai@redhat.com>
let's avoid getting new versions of those packages by accident.
Unfortunately this means we have to manually update those
packages regurarly.
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
because we should only ensure the ordering of the requests touching
the objects, the other requests like pgls should not be ordered along
with them, so as the first step, let's extract with_sequencer() method
out, so we can differentiate these two cases with minimal repeatings.
Signed-off-by: Kefu Chai <kchai@redhat.com>
since seastar now deprecates the old alien::submit_to() API, and
replaced it with a variant which requires a new parameter of "alien"
instance, let's pick it up, to amortize the cost to catch up with
the seastar master HEAD.
Signed-off-by: Kefu Chai <kchai@redhat.com>
mgr/cephadm: skip ok-to-stop for mds in upgrade if not enough mds daemons
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
