Commit Graph

98453 Commits

Author SHA1 Message Date
Sage Weil
c47b322bd3 Merge PR #27957 into master
* refs/pull/27957/head:
	json: JSONDecoder::err inherits from std::runtime_error
	rgw: RGWXMLDecoder::err inherits from std::runtime_error

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2019-05-30 12:26:17 -05:00
Kefu Chai
3cf14fcbe0
Merge pull request #28317 from tchaikov/wip-crimson-net-remove-redundant-move
crimson/net: remove redundant std::move()

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2019-05-31 01:16:26 +08:00
Kefu Chai
dea8e41930
Merge pull request #28289 from tchaikov/wip-kill-gcc-9-warnings
common,os: address string truncated warnings from GCC-9

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-05-30 23:56:41 +08:00
Kefu Chai
2953788f2a
Merge pull request #28055 from SUSE/wip-fix-39662
mgr/PyModuleRegistry: log error if we can't find any modules to load

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-05-30 23:56:02 +08:00
Kefu Chai
b300d60ffb crimson/net: remove redundant std::move()
see https://en.cppreference.com/w/cpp/language/copy_elision

it also silences warning like:

src/crimson/net/ProtocolV2.cc:146:26: warning: redundant move in return
statement [-Wredundant-move]
  146 |       return std::move(bl);
      |                          ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-05-30 22:06:46 +08:00
Kefu Chai
f6b022bdbe
Merge pull request #27806 from ashitakasam/add-osd-alarm
osd: Better error message when OSD count is less than osd_pool_default_size

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-05-30 21:28:54 +08:00
Kefu Chai
b2019a164b
Merge pull request #28278 from tchaikov/wip-buffer-remove-advance-size_t
buffer.h: remove list::iterator_impl::advance(size_t)

Reviewed-by: James Page <james.page@ubuntu.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-05-30 21:26:27 +08:00
Kefu Chai
cca664e795
Merge pull request #28251 from xiexingguo/wip-balancer-new-osd-weight
mgr/balancer: fix initial weight-set value for newly created osds

Reviewed-by: Sage Weil <sage@redhat.com>
2019-05-30 21:23:44 +08:00
Kefu Chai
8b1e713254
Merge pull request #28107 from ifed01/wip-ifed-add-devices
os/bluestore: show device name in "osd metadata output"

Reviewed-by: Sage Weil <sage@redhat.com>
2019-05-30 21:20:15 +08:00
Kefu Chai
7a0d0f7285
Merge pull request #28277 from javacruft/32bit-compat-fixes
common: avoid use of size_t in options

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-05-30 21:18:43 +08:00
Jason Dillaman
d760291c2a
Merge pull request #28250 from tchaikov/wip-silence-warnings
mon,test: silence warnings from GCC and test

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-05-30 07:42:05 -04:00
Kefu Chai
68c64e59c7
Merge pull request #25729 from the78mole/wip-32-bit-arm-fixes
cmake: boost fixes for ARM 32 bit

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-05-30 12:50:45 +08:00
Kefu Chai
10683cce90
Merge pull request #28255 from tchaikov/wip-convenience
common: no need to include ceph_assert.h

Reviewed-by: Sage Weil <sage@redhat.com>
2019-05-30 11:24:00 +08:00
Kefu Chai
5defdb9238
Merge pull request #28270 from NTmatter/patch-2
blobhash.h: remove extra [[fallthrough]]

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-05-30 11:22:18 +08:00
Sage Weil
5686d1ccd5 Merge PR #27799 into master
* refs/pull/27799/head:
	common/utime: don't pass %z to utime if there is a 'Z'
	test: test json encode/decode of utime_t
	mgr/ssh: parse new datetime
	mgr/devicehealth: parse new datetime
	mgr/crash: parse both old and new timestamp formats
	mgr/telemetry: use cluster-provided timestamp unmolested
	mon/MonMap: dump timestamps in UTC
	qa/tasks/ceph: tolerate 'T' or ' ' as date and time separator
	PendingReleaseNotes: note about change to ISO 8601 throughout
	test/cli: update regexs for timestamps
	log/LogClock: render timestamp in ISO 8601 format
	common/ceph_time: stringify in ISO 8601 format
	unittest_utime: add tests
	common/utime: make parse() handle (our) ISO 8601 output
	include/utime: make default string rendering ISO 8601 conformant
	include/utime: remove unused s[n]printf methods
	include/utime: make gmtime() output conformant ISO 8601

Reviewed-by: Kanika Murarka <kmurarka@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2019-05-29 15:27:52 -05:00
Sage Weil
1d1c4782ee common/utime: don't pass %z to utime if there is a 'Z'
This fails on centos 7 for some reason.

If it's UTC, we don't need to parse the tz portion, so avoid the issue by
leaving the %z out of the fmt string.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-05-29 14:12:15 -05:00
Casey Bodley
e24cd6bf3e test: test json encode/decode of utime_t
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2019-05-29 14:12:15 -05:00
Sage Weil
631ac85615 mgr/ssh: parse new datetime
Signed-off-by: Sage Weil <sage@redhat.com>
2019-05-29 14:12:15 -05:00
Sage Weil
b7e91923dc mgr/devicehealth: parse new datetime
Signed-off-by: Sage Weil <sage@redhat.com>
2019-05-29 14:12:15 -05:00
Sage Weil
8b02318f6b mgr/crash: parse both old and new timestamp formats
Signed-off-by: Sage Weil <sage@redhat.com>
2019-05-29 14:12:15 -05:00
Sage Weil
383006a5cc mgr/telemetry: use cluster-provided timestamp unmolested
The cluster stamp is now ISO 8601; just use that.

(The isoformat() puts a : in +hh:mm the timezone offset, which is slightly
different than what Ceph does; just pass Ceph's value through for
consistency.)

Signed-off-by: Sage Weil <sage@redhat.com>
2019-05-29 14:12:15 -05:00
Sage Weil
7eb971e93c mon/MonMap: dump timestamps in UTC
Signed-off-by: Sage Weil <sage@redhat.com>
2019-05-29 14:12:15 -05:00
Sage Weil
b747ae1711 qa/tasks/ceph: tolerate 'T' or ' ' as date and time separator
Signed-off-by: Sage Weil <sage@redhat.com>
2019-05-29 14:12:15 -05:00
Sage Weil
1f73631e75 PendingReleaseNotes: note about change to ISO 8601 throughout
Signed-off-by: Sage Weil <sage@redhat.com>
2019-05-29 14:12:15 -05:00
Sage Weil
8891fb56d4 test/cli: update regexs for timestamps
Signed-off-by: Sage Weil <sage@redhat.com>
2019-05-29 14:12:01 -05:00
Sage Weil
8f4811c3cb log/LogClock: render timestamp in ISO 8601 format
Signed-off-by: Sage Weil <sage@redhat.com>
2019-05-29 14:12:01 -05:00
Sage Weil
5e37a73247 common/ceph_time: stringify in ISO 8601 format
Signed-off-by: Sage Weil <sage@redhat.com>
2019-05-29 14:12:01 -05:00
Sage Weil
81c988093c unittest_utime: add tests
Signed-off-by: Sage Weil <sage@redhat.com>
2019-05-29 14:12:01 -05:00
Sage Weil
668d6e7f97 common/utime: make parse() handle (our) ISO 8601 output
- optional subsecond values
- optional timezone offset

Signed-off-by: Sage Weil <sage@redhat.com>
2019-05-29 14:12:01 -05:00
Sage Weil
79d8d761cf include/utime: make default string rendering ISO 8601 conformant
- use T separator
- include TZ offset

Signed-off-by: Sage Weil <sage@redhat.com>
2019-05-29 14:12:01 -05:00
Sage Weil
6b2102be22 include/utime: remove unused s[n]printf methods
Signed-off-by: Sage Weil <sage@redhat.com>
2019-05-29 14:12:01 -05:00
Sage Weil
ec3ddcb988 include/utime: make gmtime() output conformant ISO 8601
Use 'T' separated instead of ' '.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-05-29 14:12:01 -05:00
Yuri Weinstein
5111f6df16
Merge pull request #28271 from yuriw/wip-yuriw-crontab-master
qa/tests: removed filters for client-upgrade-* suites
2019-05-29 09:33:19 -07:00
Nathan Cutler
34bd11b992
Merge pull request #28170 from marxin/disable-lto-in-spec-file
rpm: Disable LTO in spec when being used.

Reviewed-by: Boris Ranto <branto@redhat.com>
Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
2019-05-29 18:21:34 +02:00
Kefu Chai
a9f8b1a609 buffer.h: remove list::iterator_impl::advance(size_t)
quote from Radoslaw's comment

> In general we could remove it as the `buffer` library tends to
> disrespects `size_t` – `list::_len` and `ptr::_len` are both
`unsigned`.
> There are some exceptions like `size_t buffer::ptr::get_offset()`
(used
> altogether with `::advance` in `denc.h`) but they deserve rework as
> well.

and in this very case, we simply cast `size_t` to `unsigned`. so we
could silently trim a 64bits integer to 32bit on 64bits architecture.

so for better portability, we can just remove it. also, this function is
inlined, so the ABI is not changed.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-05-29 23:54:50 +08:00
Lenz Grimmer
b604435fe3
mgr/dashboard: Fix NFS clients squash/access_type default values (#28235)
mgr/dashboard: Fix NFS clients squash/access_type default values

Reviewed-by: Ricardo Marques <rimarques@suse.com>
2019-05-29 17:40:31 +02:00
Thomas Johnson
62474ec989 blobhash.h: Remove extra fallthrough annotation
Remove the [[fallthrough]] annotation at the end of the switch statement
for Clang compatibility.

Fixes: https://tracker.ceph.com/issues/40052
Signed-off-by: Thomas Johnson <NTmatter@gmail.com>
2019-05-29 17:38:30 +02:00
Lenz Grimmer
ac520af893
Merge pull request #28211 from tspmelo/wip-service-root
mgr/dashboard: Change the provider of services to root
2019-05-29 17:32:42 +02:00
Lenz Grimmer
9922351e8b
Merge pull request #28118 from tspmelo/wip-on-push
mgr/dashboard: Reduce the number of renders on the tables
2019-05-29 17:29:43 +02:00
Lenz Grimmer
cea1d86ec2
mgr/dashboard: Add multi root support in CRUSH map (#28047)
mgr/dashboard: Add multi root support in CRUSH map

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
2019-05-29 17:28:04 +02:00
Jason Dillaman
ce3d380a4a
Merge pull request #28179 from trociny/wip-39980
rbd-mirror: don't overwrite status error returned by replay

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-05-29 10:58:52 -04:00
Jason Dillaman
16aa0a772e
Merge pull request #28240 from trociny/wip-journal-overflow
journal: optimize object overflow detection

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-05-29 10:58:12 -04:00
Casey Bodley
ff5f4a57eb
Merge pull request #28275 from tchaikov/wip-cmake-asan
ceph.in: do not preload libasan if it is found

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2019-05-29 10:44:13 -04:00
Kefu Chai
7b7fd12bd6
Merge pull request #28269 from NTmatter/patch-1
install-deps.sh: fix typo for krb5 on FreeBSD

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-05-29 22:23:10 +08:00
Lenz Grimmer
a9ffaa2c7e
Merge pull request #27978 from votdev/add_snmp_oids_to_prometheus_alerts
monitoring: SNMP OID per every Prometheus alert rule

Reviewed-by: Boris Ranto <branto@redhat.com>
Reviewed-by: Jan Fajerski <jfajerski@suse.com>
2019-05-29 15:58:23 +02:00
Sebastian Wagner
9272e2e525
Merge pull request #28225 from sebastian-philipp/script-run-mypy-sort-groups
script/run_mypy: Sort groups

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
2019-05-29 15:21:17 +02:00
Martin Liska
6ab109bb9b rpm: Disable LTO in spec when being used
Fixes: http://tracker.ceph.com/issues/39974
Works around: https://tracker.ceph.com/issues/40060

Signed-off-by: Martin Liška <Martin.Liska@suse.com>
2019-05-29 14:26:42 +02:00
Nathan Cutler
29afe39365
Merge pull request #28002 from smithfarm/wip-39323-ext
pybind/tox: handle possible WITH_PYTHON3 values other than "3"

Reviewed-by: Stephan Müller <smueller@suse.com>
2019-05-29 13:39:32 +02:00
Daniel Glaser
c89a6998f4 cmake: boost fixes for ARM 32 bit
see https://github.com/boostorg/context/pull/94

we should drop this change once ceph uses boost 1.70 or up

Signed-off-by: Daniel Glaser <me@the78mole.de>
2019-05-29 18:30:59 +08:00
Tiago Melo
cc81bbc83b mgr/dashboard: Change the provider of services to root
It looks like that even if we provide a service only in 1 module, there are
still situations where angular will create multiple instances of that service.

By setting root as its providers, this no longer happens.

Fixes: http://tracker.ceph.com/issues/39996

Signed-off-by: Tiago Melo <tmelo@suse.com>
2019-05-29 09:56:11 +00:00