Commit Graph

134924 Commits

Author SHA1 Message Date
Yuval Lifshitz
b524a430f3
Merge pull request #48758 from yuvalif/wip-yuval-kafka-tests
rgw/notification/test: add support for testing kafka security
2022-11-23 13:00:00 +02:00
Kefu Chai
e070ec36f7
Merge pull request #49011 from tchaikov/wip-crimson-fmt-v9
crimson: various fmt related changes and fixes.

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-11-23 08:37:43 +08:00
zdover23
6f0d368793
Merge pull request #49017 from zdover23/wip-doc-2022-11-23-glossary-cluster-map
doc/glossary: s/comprising/consisting of/

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2022-11-23 04:33:11 +10:00
Zac Dover
0855959503 doc/glossary: s/comprising/consisting of/
s/comprising/consisting of/ - Make the text easier to read for
non-native or weak readers of English.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-11-23 04:04:48 +10:00
Kefu Chai
a5eef07efb
Merge pull request #49001 from tchaikov/wip-fmt-v9
*: specialize fmt::formatter<> for formatting using {fmt}

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2022-11-23 00:03:16 +08:00
Kefu Chai
240e456c0f crimson/os: print exception using e.what()
see also e6223872c5

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-11-22 22:57:18 +08:00
Kefu Chai
2e7aea7b0f crimson/os: print pointer using fmt::ptr()
also, partial specialize fmt::format<> for boost::instrusive_ptr<>,
so we can use fmt::ptr() to print boost::intrusive_ptr<>, just like
how we print std::shared_ptr<>.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-11-22 22:57:18 +08:00
zdover23
0528e16f89
Merge pull request #48984 from Matan-B/wip-matanb-unit-debug-lvl
doc/dev/developer_guide/tests-unit-tests: Add unit test caveat

Reviewed-by: Zac Dover <zac.dover@gmail.com>
2022-11-23 00:11:45 +10:00
Kefu Chai
ec3ee002fd crimson/os: print the value of optional<>
if an optional is known to have value, we can just print its value.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-11-22 21:04:28 +08:00
Kefu Chai
c9569f8eb0 crimson: specialize fmt::formatter<>
so the specialized types can be formatted using {fmt} v9

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-11-22 21:04:28 +08:00
Kefu Chai
01f6bef6e5 *: specialize fmt::formatter<> for formatting using {fmt}
in {fmt} v9, fmt::formatter<> is not defined automatically for
the types with operator<<, we need to define them explictly. so in this
change, the types printed using `fmt::print()` or `fmt::format()` are
equiped with fmt::formatter<> to appease {fmt} v9.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-11-22 20:41:17 +08:00
Kefu Chai
021fa45573
Merge pull request #49000 from tchaikov/wip-crimson-fmt-v9
crimson: various fmt related changes and fixes.

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-11-22 15:08:04 +08:00
Kefu Chai
fa3025f3ba crimson/osd: print oid of missing clone
instead of printing the empty optional<>, print the oid of missing
clone. the oid is more interesting in this context.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-11-22 13:54:41 +08:00
Kefu Chai
3f67d67ede crimson: specialize fmt::formatter<> to print using {fmt}
in {fmt} v9, fmt::formatter<> is not defined automatically for
the types with operator<<, we need to define them explictly. so in this
change, the types printed using `fmt::print()` or `fmt::format()` are
equiped with fmt::formatter<> to appease {fmt} v9.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-11-22 13:54:41 +08:00
Kefu Chai
42dc970392 crimson/net: print shared_ptr using fmt::ptr()
in {fmt} v9, only `void*` pointers can be printed directly. when it
comes to typed pointer or smart pointers, we need to print them using
`fmt::ptr()`. in this change, an overload is added so we can print
`seastar::shared_ptr<>` via `fmt::ptr()` as well, just like how we
print `std::shared_ptr<>`.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-11-22 13:54:41 +08:00
Kefu Chai
8c118d630e crimson/osd: add formatter for std::optional<>
in `PG::do_update_log_missing()`, `std::optional<eversion_t>` is printed
using {fmt}, but {fmt} does not support formatting `std::optional<>`. so
we need to swing our own formatter. we can promote this formatter to
a more common place if it is proved to be useful otherwhere in the
source tree.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-11-22 13:54:41 +08:00
Kefu Chai
e6223872c5 crimson: print exceptions using exception.what()
{fmt} does not support formatting exceptions until
76adb05a78
so we need to print them via exception.what().

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-11-22 13:54:41 +08:00
Kefu Chai
06ce350ed6 crimson/common: print std::exception_ptr after conveting it to exception
fmt does not support formatting `std::exception_ptr`, so we need to
rethrow it, so we can convert it to a known exception type.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-11-22 13:54:41 +08:00
Kefu Chai
7803eb186d
Merge pull request #48987 from tchaikov/cmake-cares
cmake: s/c-ares::c-ares/c-ares::cares/

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-11-22 12:37:00 +08:00
zdover23
0b48157f59
Merge pull request #48998 from zdover23/wip-doc-2022-11-22-glossary-ceph-storage-cluster
doc/glossary: define "Ceph Storage Cluster"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2022-11-22 14:36:13 +10:00
Zac Dover
1fd6be8b6b doc/glossary: define "Ceph Storage Cluster"
Add "Ceph Storage Cluster" to the glossary.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-11-22 14:25:52 +10:00
Yingxin
6a3c09ed78
Merge pull request #48773 from myoungwon/wip-fix-out-date-delta
crimson/os/seastore: add deallocation map during replay to filter out out-dated delta

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-11-22 09:44:48 +08:00
Brad Hubbard
46bb9bd476
Merge pull request #48837 from badone/wip-ceph-debug-docker-ubuntu-src.list
scripts: Add Ubuntu source repo entry to ceph-debug-docker

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2022-11-22 08:42:15 +10:00
zdover23
4df8f2900e
Merge pull request #48989 from zdover23/wip-doc-2022-11-22-glossary-node
doc/glossary: Define "Ceph Node"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-11-22 04:05:10 +10:00
zdover23
a7eda84375
Merge pull request #48990 from zdover23/wip-doc-2022-11-22-glossary-cluster-map-oxford-comma
doc/glossary: add oxford comma to "Cluster Map"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-11-22 04:01:54 +10:00
Kefu Chai
3121de1c70 cmake: s/c-ares::c-ares/c-ares::cares/
to be aligned with the c-ares upstream, which provides
c-ares-config.cmake in c-ares v1.17 and up. this cmake config file
is also packaged by fedora and CentOS stream in c-ares-devel-1.17.1 and
up.

this change prepares us for bumping up Seastar submodule, which also
has a similar change: aea45c98f2

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-11-22 01:17:30 +08:00
Zac Dover
75b567d8e5 doc/glossary: add oxford comma to "Cluster Map"
Add an Oxford comma to a list under the "Cluster Map" headword in the
glossary, so that it doesn't read like "I'd like to thank my parents,
Ayn Rand and God."

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-11-22 02:52:23 +10:00
Zac Dover
24dcf00ac7 doc/glossary: Define "Ceph Node"
Add a definition of "Ceph Node" to the glossary.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-11-22 02:49:49 +10:00
zdover23
95a9082685
Merge pull request #48983 from zdover23/wip-doc-2022-11-21-rados-ops-add-or-rm-mons-prompts-2-of-2
doc/rados: add prompts to add-or-rm-prompts.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-11-22 00:58:49 +10:00
Matan Breizman
032f8cf601 doc/dev/developer_guide/tests-unit-tests: Add unit test caveat
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2022-11-21 14:56:24 +00:00
Venky Shankar
601de01501
Merge pull request #48810 from stefan-chivu/max-path-len-increase
dokan: Configurable maximum path length

Reviewed-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2022-11-21 19:34:22 +05:30
Zac Dover
dda330f8a8 doc/rados: add prompts to add-or-rm-prompts.rst
Add unselectable prompts to add-or-rm-prompts.rst. This is part 2 of 2.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-11-21 23:57:55 +10:00
Venky Shankar
21782ada80
Merge pull request #48664 from joscollin/wip-cephfs-top-drop-x-coord-map
cephfs-top: drop x_coord_map

Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
2022-11-21 18:54:35 +05:30
Venky Shankar
971d83efe1
Merge pull request #48850 from joscollin/wip-fix-clear-screen-no-fs
cephfs-top: run_display: clear the screen and block commands when no fs

Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
2022-11-21 18:54:17 +05:30
zdover23
f905b73f4a
Merge pull request #48956 from zdover23/wip-doc-2022-11-19-src-pybind-cephfs-cephfs-grammar
src/pybind/cephfs: fix grammar

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
2022-11-21 23:20:55 +10:00
Yuval Lifshitz
dcbc4afc21 rgw/notification/test: avoid kafka ssl tests in teuthology
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2022-11-21 11:56:11 +02:00
Stefan Chivu
8fa8724803 test/dokan: Added dokan max path test
Signed-off-by: Stefan Chivu <schivu@cloudbasesolutions.com>
2022-11-21 11:49:14 +02:00
Stefan Chivu
b1504a028c ceph-dokan: Made max path length configurable
Added ceph-dokan CLI optarg for configuring the value of
the maximum path length. By default, it will be set to 256 and
it will have a maximum value of 32767.

Signed-off-by: Stefan Chivu <schivu@cloudbasesolutions.com>
2022-11-21 11:48:59 +02:00
Jos Collin
46dbd644e4
cephfs-top: drop x_coord_map
As we started using curses pads in PR#48090, we don't need x_coord_map anymore.
In this patch, the metrics are positioned in cephfs-top based on padding (ITEMS_PAD).

Signed-off-by: Jos Collin <jcollin@redhat.com>
2022-11-21 15:15:50 +05:30
Venky Shankar
453bb9aa1f
Merge pull request #48910 from joscollin/wip-fix-header-show-filters
cephfs-top: display filters in the header

Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
2022-11-21 15:01:12 +05:30
zdover23
da616e5a65
Merge pull request #48978 from zdover23/wip-doc-2022-11-21-rados-ops-add-or-rm-mons-prompts-1-of-2
doc/rados: add prompts to add-or-rm-prompts.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2022-11-21 17:07:45 +10:00
myoungwon oh
e135b79e6e crimson/os/seastore/cbj: add deallocation map during replay to filter out out-dated delta
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-11-21 16:04:33 +09:00
Zac Dover
6f4b64df34 doc/rados: add prompts to add-or-rm-prompts.rst
Add unselectable prompts to add-or-rm-prompts.rst. This commit covers
the first 300 lines of the file. This is part 1 of 2.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-11-21 14:28:46 +10:00
zdover23
50dfaf9897
Merge pull request #48975 from zdover23/wip-doc-2022-11-21-glossary-SDS
doc/glossary: Add "SDS"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-11-21 13:05:58 +10:00
Zac Dover
ec61f6764f doc/glossary: Add "SDS"
Add "SDS" to the glossary.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-11-21 04:09:46 +10:00
Ilya Dryomov
fb9491e0ec
Merge pull request #48949 from ktdreyer/doc-windows-drive-letter
doc: display Windows RBD drive letter

Reviewed-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-11-20 11:24:25 +01:00
zdover23
7d82418f01
Merge pull request #48968 from zdover23/wip-doc-2022-11-20-rbd-immutable-object-cache-daemon-grammar
doc/rbd: improve grammar in "immutable object..."

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2022-11-20 17:57:25 +10:00
Zac Dover
3fc21e539d doc/rbd: improve grammar in "immutable object..."
Improve the grammar in the "Immutable Object Cache Daemon" section.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-11-20 17:13:20 +10:00
zdover23
cf5e7ad0ec
Merge pull request #48962 from zdover23/wip-doc-2022-11-20-radosgw-object-gateway-grammar
doc/radosw: improve radosgw text

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2022-11-20 15:33:58 +10:00
zdover23
5e13179279
Merge pull request #48963 from zdover23/wip-doc-2022-11-20-glossary-ceph-block-storage
doc/glossary: beef up "Ceph Block Storage"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2022-11-20 15:27:25 +10:00