Commit Graph

126945 Commits

Author SHA1 Message Date
Kefu Chai
b2e806eedb
Merge pull request #43307 from taodd/recv_stamp_fix
msg/async/ProtocolV2: Set the recv_stamp at the beginning of receiving a message

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Dan Hill <daniel.hill@canonical.com>
2021-10-07 06:33:21 +08:00
Kefu Chai
22d9a69f9c
Merge pull request #43380 from myoungwon/wip-dont-promote-dirty
osd: do not promote objects if op is is_dirty

Reviewed-by: Samuel Just <sjust@redhat.com>
2021-10-07 06:31:32 +08:00
Kefu Chai
ea586cdcf5
Merge pull request #43435 from rzarzynski/wip-crimson-pickv2only
crimson/osd: pick only v2 addresses.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
2021-10-07 06:19:54 +08:00
Ernesto Puerta
df89e6a174
Merge pull request #43256 from rhcs-dashboard/fix-48845-master
qa/mgr/dashboard/test_pool: don't check HEALTH_OK

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2021-10-06 21:49:12 +02:00
Neha Ojha
363b223844
Merge pull request #42964 from trociny/wip-52448
osd: re-cache peer_bytes on every peering state activate

Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-10-06 09:26:16 -07:00
Radoslaw Zarzynski
c7f2056f74 crimson/osd: pick only v2 addresses.
Otherwise we'll run into an assertion failure when binding:

```
INFO  2021-10-05 15:14:51,075 [shard 0] osd - picked address v2:0.0.0.0:0/0
INFO  2021-10-05 15:14:51,075 [shard 0] osd - picked address v1:0.0.0.0:0/0
ceph-osd: /home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-8025-geb9c0f59/rpm/el8/BUILD/ceph-17.0.0-8025-geb9c0f59/src/crimson/net/SocketMessenger.cc:89: crimson::errorator<crimson::unthrowable_wrapper<const std::error_code&, ((const std::error_code&)(& crimson::ec<std::errc::address_in_use>))>, crimson::unthrowable_wrapper<const std::error_code&, ((const std::error_code&)(& crimson::ec<std::errc::address_not_available>))> >::future<> crimson::net::SocketMessenger::try_bind(const entity_addrvec_t&, uint32_t, uint32_t): Assertion `addrs.size() == 1' failed.
Aborting on shard 0.
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-10-06 14:44:02 +00:00
Patrick Donnelly
ed8e8b7600
Merge PR #43399 into master
* refs/pull/43399/head:
	mgr/volumes/fs/operations: fix various flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
2021-10-05 20:17:49 -04:00
Patrick Donnelly
dcf333f403
Merge PR #43398 into master
* refs/pull/43398/head:
	mgr/volumes/fs: fix flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
2021-10-05 20:17:19 -04:00
Patrick Donnelly
4e723b7c82
Merge PR #43397 into master
* refs/pull/43397/head:
	mgr/volumes/fs: fix flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
2021-10-05 20:16:50 -04:00
Patrick Donnelly
59ec54aa73
Merge PR #43395 into master
* refs/pull/43395/head:
	mgr/volumes/fs/operations/versions: fix various flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
2021-10-05 20:16:19 -04:00
Patrick Donnelly
4f60a67115
Merge PR #43392 into master
* refs/pull/43392/head:
	mgr/volumes/fs/operations: fix various flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
2021-10-05 20:15:47 -04:00
Patrick Donnelly
d5287440ba
Merge PR #43391 into master
* refs/pull/43391/head:
	mgr/volumes/fs/vol_spec.py: fix flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
2021-10-05 20:15:18 -04:00
Patrick Donnelly
7f6aa14be5
Merge PR #43390 into master
* refs/pull/43390/head:
	mgr/volumes/fs/operations : Fix flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
2021-10-05 20:14:49 -04:00
Patrick Donnelly
a8a7680e5f
Merge PR #43387 into master
* refs/pull/43387/head:
	mgr/volumes: fix various flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
2021-10-05 20:14:06 -04:00
Patrick Donnelly
2c1f6819af
Merge PR #43375 into master
* refs/pull/43375/head:
	mgr/volumes/fs: add extra blank line

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
2021-10-05 20:13:34 -04:00
Patrick Donnelly
02516d6231
Merge PR #43357 into master
* refs/pull/43357/head:
	mgr/nfs: stick to lazy evaluation of logger messages
	mgr/nfs: change _cmd_rgw_export_create_rgw() name
	mgr/nfs: don't log fsal keys
	mgr/nfs: Add more debug log messages

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
2021-10-05 20:12:44 -04:00
Yuri Weinstein
d5759e030b
Merge pull request #42977 from amathuria/wip-amathuri-scrub-duration
osd/scrub: Add scrub duration to pg dump stats

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2021-10-05 07:49:03 -07:00
Deepika Upadhyay
e4db160015
Merge pull request #43175 from ideepika/wip-supress-jaeger-cmake-logs
cmake,rgw: use jaeger-base target, as a dependency for building dbstore

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-10-05 14:00:50 +05:30
Josh Durgin
eb9c0f5982
Merge pull request #43410 from zdover23/wip-doc-2021-10-04-min-hardware-typo
docs/start: fix min. hardware rec. typo

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-10-04 11:02:06 -07:00
Zac Dover
14151f2abe docs/start: fix min. hardware rec. typo
The minimum hardware recommendations said that we
recommended a minimum of "24GB+ per daemon".

I changed this to read "2-4GB+ per daemon".

Reddit actually caught this one:
https://www.reddit.com/r/ceph/comments/q14ey2/cephs_mon_minimum_requirements/

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2021-10-05 02:57:51 +10:00
Deepika Upadhyay
463193bcaf cmake,rgw: use jaeger-base target, as a dependency for building dbstore
* dbstore also has tracing dependencies and missing linking for libraries
* use `using` keyword in common/tracer.cc to silence unused method
  warnings
* log building of external project jaegertracing, opentracing into build
  file, (done to reduce external project build verbosity)

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2021-10-04 13:52:49 +05:30
Sage Weil
0bc19b5449
Merge pull request #43402 from liewegas/doc-general-rep
doc/foundation: Martin is new general member rep
2021-10-03 13:42:45 -05:00
Patrick Donnelly
66cc38db1c
Merge PR #43383 into master
* refs/pull/43383/head:
	doc: fixed typo in terminology

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-10-02 12:27:40 -04:00
Sage Weil
df5be4ba93 doc/foundation: Martin is new general member rep
Signed-off-by: Sage Weil <sage@newdream.net>
2021-10-02 10:49:46 -05:00
crossbears
fb88546dae mgr/volumes/fs/operations: fix various flake8 issues
Fixes: https://tracker.ceph.com/issues/51390
Signed-off-by: Zoey <jingyasu@my.yorku.ca>
2021-10-01 19:52:55 -04:00
Eunice Lee
00e1df1d43 mgr/volumes/fs/vol_spec.py: fix flake8 issues
Fixes: https://tracker.ceph.com/issues/51384

Signed-off-by: Eunice Lee <eunice337@gmail.com>
2021-10-01 15:59:58 -07:00
Hargun Kaur
5b292130f2 mgr/volumes/fs: fix flake8 issues
Fixes: https://tracker.ceph.com/issues/51407

Signed-off-by: Hargun Kaur <hargunalone@gmail.com>
2021-10-01 22:39:33 +00:00
Gokcen Iskender
c8af51d302
mgr/volumes/fs/operations/versions: fix various flake8 issues
Fixes: https://tracker.ceph.com/issues/51403
Signed-off-by: Gokcen Iskender <gokceng@gmail.com>
2021-10-01 15:16:29 -07:00
Eunice Lee
add94f1e48 mgr/volumes/fs: fix flake8 issues
Fixes: https://tracker.ceph.com/issues/51381

Signed-off-by: Eunice Lee <eunice337@gmail.com>
2021-10-01 15:11:28 -07:00
Gokcen Iskender
364d38e26a
mgr/volumes/fs/operations: fix various flake8 issues
Fixes: https://tracker.ceph.com/issues/51398
Signed-off-by: Gokcen Iskender <gokceng@gmail.com>
2021-10-01 15:09:07 -07:00
Anuradha Kulkarni
e0ddb81358 mgr/volumes/fs/operations : Fix flake8 issues
Fixes : https://tracker.ceph.com/issues/51396

Signed-off-by: Anuradha Kulkarni <anuradhak1990@gmail.com>
2021-10-01 18:00:27 -04:00
Almen Ng
4d3e366e0b mgr/volumes: fix various flake8 issues
Fixes: https://tracker.ceph.com/issues/51380

Signed-off-by: Almen Ng <almen000509@gmail.com>
2021-10-01 17:28:34 -04:00
Ernesto Puerta
ce535dd8e0
Merge pull request #41255 from rhcs-dashboard/angular-11-upgrade
mgr/dashboard: Angular v11 Migration

Reviewed-by: aaryanporwal <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2021-10-01 18:13:09 +02:00
Ernesto Puerta
c525e74154
Merge pull request #42716 from sshambar/bug-52002
mgr/dashboard,prometheus: fix handling of server_addr

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: sebastian-philipp <NOT@FOUND>
Reviewed-by: sshambar <NOT@FOUND>
2021-10-01 18:12:11 +02:00
zdover23
f5ee2c4bf1
Merge pull request #43277 from anthonyeleven/anthonyeleven/fix-47839
ceph: add example BlueStore migration via the ceph-objectstore-tool dup op

Reviewed-by: Zac Dover <zac.dover@gmail.com>
2021-10-02 00:22:22 +10:00
Jos Collin
d1d4cdcc39
doc: fixed typo in terminology
Signed-off-by: Jos Collin <jcollin@redhat.com>
2021-10-01 16:04:44 +05:30
Aishwarya Mathuria
1b4e416f81 osd/scrub: Add scrub duration to pg dump stats
Addition of a new column, SCRUB_DURATION, to the pg stats that stores the time taken for a PG scrub.

Fixes: https://tracker.ceph.com/issues/52605
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
2021-10-01 13:27:27 +05:30
Nizamudeen A
fa6fb0087c mgr/dashboard: Remove i18n Warning about duplicate id
Fixes: https://tracker.ceph.com/issues/50268
Signed-off-by: Nizamudeen A <nia@redhat.com>
2021-10-01 12:29:07 +05:30
Nizamudeen A
f7d73d0420 mgr/dashboard: Taking care of deprecation warnings and other errors
1. deprecation  group is deprecated: This API is not typesafe and can result in issues with Closure Compiler renaming. Use the `FormBuilder#group` overload with `AbstractControlOptions` instead.

2. cypress/integration/rgw/users.po.ts(113,23): error TS2345: Argument of type 'void' is not assignable to parameter of type 'string'.

3. Cannot find module 'isomorphic-form-data' from 'node_modules/swagger-ui/dist/swagger-ui.js'

Fixes: https://tracker.ceph.com/issues/50268
Signed-off-by: Nizamudeen A <nia@redhat.com>
2021-10-01 12:29:07 +05:30
Nizamudeen A
de26485018 mgr/dashboard: Angular v11 Migration
Fixes: https://tracker.ceph.com/issues/50268
Signed-off-by: Nizamudeen A <nia@redhat.com>
2021-10-01 12:28:40 +05:30
myoungwon oh
4cb57a7621 osd: do not promote objects if op is is_dirty
manifest object contains object_info_t even if the object
is flushed, so OSD can reply the result of is_dirty.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2021-10-01 10:29:32 +09:00
Manasvi Goyal
ffad09fc41
mgr/volumes/fs: add extra blank line
Fixes: https://tracker.ceph.com/issues/51392
Signed-off-by: Manasvi Goyal <mg.manasvi@gmail.com>
2021-10-01 01:38:31 +05:30
Patrick Donnelly
6939ea034a
Merge PR #43323 into master
* refs/pull/43323/head:
	mgr/volumes/fs: add extra blank line

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
2021-09-30 12:50:54 -04:00
Patrick Donnelly
8031dee8ea
Merge PR #43322 into master
* refs/pull/43322/head:
	mgr/volumes/fs: add extra blank line

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
2021-09-30 12:49:37 -04:00
Yuri Weinstein
33bcd2e509
Merge pull request #36733 from majianpeng/rocksdb-remove-redundant-perfcount
kv/RocksdbStore: remove perfcounter l_rocksdb_gets.

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-09-30 07:52:30 -07:00
Yuri Weinstein
d14580d44b
Merge pull request #34624 from zhouyh-orcadt/fix_optracker_coredump
common/TrackedOp: fix osd reboot optracker coredump

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-09-30 07:51:32 -07:00
Kefu Chai
96edb523c1
Merge pull request #43355 from rzarzynski/wip-crimson-write_meta
crimson/osd: write the 'osd_key' meta on OSD::mkfs(). 

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2021-09-30 22:16:51 +08:00
Kefu Chai
130c7261aa
Merge pull request #43364 from rzarzynski/wip-crimson-canceliores-on-stop
crimson/osd: cancel IO reservations on PG::stop().

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2021-09-30 22:14:11 +08:00
Ernesto Puerta
2283cb068b
qa/mgr/dashboard/test_pool: don't check HEALTH_OK
Fixes: https://tracker.ceph.com/issues/48845
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2021-09-30 14:16:46 +02:00
Radoslaw Zarzynski
6b04b96991 crimson/osd: cancel IO reservations on PG::stop().
`PG::request_{local,remote}_recovery_reservation()` dynamically allocates
up to 2 instances of `LambdaContext<T>` and transfers their ownership to
the `AsyncReserver<T, F>`. This is expressed in raw pointers (`new` and
`delete`) notion. Further analysis shows the only place where `delete`
for these objects is called is the `AsyncReserver::cancel_reservation()`.
In contrast to the classical OSD, crimson doesn't invoke the method when
stopping a PG during the shutdown sequence. This would explain the
following ASan issue observed at Sepia:

```
Direct leak of 576 byte(s) in 24 object(s) allocated from:
    #0 0x7fa108fc57b0 in operator new(unsigned long) (/lib64/libasan.so.5+0xf17b0)
    #1 0x55723d8b0b56 in non-virtual thunk to crimson::osd::PG::request_local_background_io_reservation(unsigned int, std::unique_ptr<PGPeeringEvent, std::default_delete<PGPeeringEvent> >, std::unique_ptr<PGPeeringEvent, std::default_delete<PGPeeringEvent> >) (/usr/bin/ceph-osd+0x24d95b56)
    #2 0x55723f1f66ef in PeeringState::WaitDeleteReserved::WaitDeleteReserved(boost::statechart::state<PeeringState::WaitDeleteReserved, PeeringState::ToDelete, boost::mpl::list<mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, (boost::statechart::history_mode)0>::my_context) (/usr/bin/ceph-osd+0x266db6ef)
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-09-30 11:28:08 +00:00