Commit Graph

110645 Commits

Author SHA1 Message Date
Xiubo Li
afe19f24ba qa/tasks/cephfs/test_volumes: to make sure the size is int type
Fix "Error EINVAL: invalid size option '4915200.0'".

In pytho2 int/2 will get a int type result, but in python3 it maybe
a float type.

Fixes: https://tracker.ceph.com/issues/45247
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2020-04-24 05:05:54 -04:00
Xiubo Li
65f97690af qa/tasks/cephfs/mount: to make sure that the count/seek are int type
To fix "stderr:dd: invalid number: '5.0'".

Fixes: https://tracker.ceph.com/issues/45247
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2020-04-24 05:05:54 -04:00
Xiubo Li
666974e0a6 qa/tasks/cephfs/cephfs_test_case: switch 'dict_keys' object to list
Fix the "TypeError: 'dict_keys' object does not support indexing" under
py3.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
2020-04-24 04:04:18 -04:00
Kefu Chai
f80ce9ec07
Merge pull request #33769 from lxbsz/qa_vstart_runner_os
qa/vstart_runner.py: add os and arch properties support

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-04-24 15:41:54 +08:00
Xiubo Li
624944503e qa/tasks/vstart_runner: make remote.sh return str as default
To address the issue in https://github.com/ceph/teuthology/pull/1459.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
2020-04-24 03:05:34 -04:00
Xiubo Li
704ce2c969 qa/vstart_runner.py: add os and arch properties support
Fixes: https://tracker.ceph.com/issues/44456
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2020-04-24 03:05:34 -04:00
Kefu Chai
036c40e943
Merge pull request #34685 from lxbsz/vstart_runner
qa/tasks/cephfs/mount: switch to StringIO to fix TypeErrors

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-04-24 09:09:49 +08:00
Xiubo Li
0631342d10 qa/tasks/cephfs/mount: switch to StringIO to fix TypeErrors
TypeError: cannot use a string pattern on a bytes-like object

Fixes: https://tracker.ceph.com/issues/45175
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2020-04-23 20:55:35 -04:00
Xiubo Li
c541bae6b1 qa/vstart_runner: remove the debug info
Fixes: https://tracker.ceph.com/issues/45175
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2020-04-23 20:55:35 -04:00
Casey Bodley
ce5f3e3047
Merge pull request #34570 from cbodley/wip-bucket-layout-json
rgw: bucket layout fixes

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
2020-04-23 11:16:55 -04:00
Casey Bodley
f43e58071e
Merge pull request #34645 from cbodley/wip-rgw-reshard-target-layout
rgw: use target bucket layout for reshard

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
2020-04-23 11:16:44 -04:00
Jason Dillaman
92b3122a06
Merge pull request #33937 from changchengx/unsigned_compare
librbd: fix unsigned value compared with zero

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-04-23 10:48:33 -04:00
Boris Ranto
05573aa57d
Merge pull request #34694 from mikechristie/ceph-iscsi-selinux-fixes
ceph-iscsi:  selinux fixes

Reviewed-by: Boris Ranto <branto@redhat.com>
2020-04-23 13:52:36 +02:00
Sebastian Wagner
9e91081f06
Merge pull request #34678 from sebastian-philipp/doc-cephadm-install-fix-placement
doc/cephadm: install.rst: fix placement spec.

Reviewed-by: Alexandra Settle <asettle@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2020-04-23 12:20:30 +02:00
Sebastian Wagner
6a588788b7
Merge pull request #34674 from sebastian-philipp/cephadm-ceph-volume-lock-if-fsid
cephadm: Aquire lock, if fsid != None

Reviewed-by: Michael Fritch <mfritch@suse.com>
2020-04-23 12:09:22 +02:00
Sebastian Wagner
aab7045dec
Merge pull request #34620 from mgfritch/cephadm-timeout-test-fixup
qa/workunits/cephadm/test_cephadm.sh: extend timeout test
2020-04-23 12:03:20 +02:00
Sebastian Wagner
3784f63551
Merge pull request #34600 from dsavineau/issue_45120
cephadm: fix adopt prometheus command

Reviewed-by: Michael Fritch <mfritch@suse.com>
2020-04-23 12:02:31 +02:00
Sebastian Wagner
8dcb67de84
Merge pull request #34688 from sebastian-philipp/qa-test-cephadm-octopus-version
qa/workunits/cephadm/test_cephadm: Also test octopus

Reviewed-by: Michael Fritch <mfritch@suse.com>
2020-04-23 12:01:48 +02:00
Sebastian Wagner
bf2988ab10
Merge pull request #34691 from sebastian-philipp/cephadm-ssk-keyring-check_call
mgr/cephadm: use check_call  for `ssh-keygen`

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2020-04-23 12:01:20 +02:00
Igor Fedotov
70839d99dd
Merge pull request #33065 from ifed01/wip-ifed-spurious-readerr-alert
os/bluestore: introduce health alert on spurious read errors.

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2020-04-23 11:32:25 +03:00
Laura Paduano
1a616c207c
Merge pull request #34666 from rhcs-dashboard/44405-test-totp-increase-time
mgr/dashboard: fix tasks.mgr.dashboard.test_rgw.RgwBucketTest.test_all

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
2020-04-23 09:47:58 +02:00
Kefu Chai
0c2f0bde8a
Merge pull request #34483 from dabukalam/master
doc/rados: Remove obsolete placement group note from EC pool creation

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-04-23 15:33:06 +08:00
Kefu Chai
5a7fb2c2e8
Merge pull request #33916 from aclamk/fix-bs-avl-memaccounting
os/bluestore: Adds shutdown in destructor of AvlAllocator

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-04-23 15:22:19 +08:00
Kefu Chai
e6fe7f44af
Merge pull request #34559 from tchaikov/wip-19076-refactor
mon/OSDMonitor: refactor loops for better readability

Reviewed-by: Joao Eduardo Luis <joao@suse.de>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
2020-04-23 10:34:26 +08:00
Josh Durgin
d61f57d078
Merge pull request #34328 from liewegas/cpatch
script/cpatch: initial version

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
2020-04-22 18:34:36 -07:00
Jason Dillaman
e9130bcf0b
Merge pull request #34430 from yison/rwl-image-writeback-cache-seq4
rbd/cache: Replicated Write Log core codes part 4

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-04-22 19:28:17 -04:00
Mike Christie
53be181653 selinux: Fix ceph-iscsi etc access
This fixes the selinux errors like this for /etc/target

-----------------------------------
Additional Information:
Source Context                system_u:system_r:ceph_t:s0
Target Context                system_u:object_r:targetd_etc_rw_t:s0
Target Objects                target [ dir ]
Source                        rbd-target-api
Source Path                   rbd-target-api
Port                          <Unknown>
Host                          ans8
Source RPM Packages
Target RPM Packages
Policy RPM                    selinux-policy-3.14.3-20.el8.noarch
Selinux Enabled               True
Policy Type                   targeted
Enforcing Mode                Enforcing
Host Name                     ans8
Platform                      Linux ans8 4.18.0-147.el8.x86_64 #1 SMP
Thu Sep 26
                              15:52:44 UTC 2019 x86_64 x86_64
Alert Count                   1
First Seen                    2020-01-08 18:39:48 EST
Last Seen                     2020-01-08 18:39:48 EST
Local ID                      9a13ee18-eaf2-4f2a-872f-2809ee4928f6

Raw Audit Messages
type=AVC msg=audit(1578526788.148:69): avc:  denied  { search } for
pid=995 comm="rbd-target-api" name="target" dev="sda1" ino=52198
scontext=system_u:system_r:ceph_t:s0
tcontext=system_u:object_r:targetd_etc_rw_t:s0 tclass=dir permissive=1

Hash: rbd-target-api,ceph_t,targetd_etc_rw_t,dir,search

which are a result of the rtslib library the ceph-iscsi daemons use
accessing /etc/target to read/write a file which stores meta data the
target uses.

Signed-off-by: Mike Christie <mchristi@redhat.com>
2020-04-22 11:52:02 -05:00
Mike Christie
8187235c91 selinux: Fix ceph-iscsi configfs access
This fixes the the following selinux error when using ceph-iscsi's
rbd-target-api daemon (rbd-target-gw has the same issue). They are
a result of the a python library, rtslib, which the daemons use.

Additional Information:
Source Context                system_u:system_r:ceph_t:s0
Target Context                system_u:object_r:configfs_t:s0
Target Objects
/sys/kernel/config/target/iscsi/iqn.2003-01.com.re
                              dhat:ceph-iscsi/tpgt_1/attrib/authentication
[
                              file ]
Source                        rbd-target-api
Source Path                   /usr/libexec/platform-python3.6
Port                          <Unknown>
Host                          ans8
Source RPM Packages           platform-python-3.6.8-15.1.el8.x86_64
Target RPM Packages
Policy RPM                    selinux-policy-3.14.3-20.el8.noarch
Selinux Enabled               True
Policy Type                   targeted
Enforcing Mode                Enforcing
Host Name                     ans8
Platform                      Linux ans8 4.18.0-147.el8.x86_64 #1 SMP
Thu Sep 26
                              15:52:44 UTC 2019 x86_64 x86_64
Alert Count                   1
First Seen                    2020-01-08 18:39:47 EST
Last Seen                     2020-01-08 18:39:47 EST
Local ID                      6f8c3415-7a50-4dc8-b3d2-2621e1d00ca3

Raw Audit Messages
type=AVC msg=audit(1578526787.577:68): avc:  denied  { ioctl } for
pid=995 comm="rbd-target-api"
path="/sys/kernel/config/target/iscsi/iqn.2003-01.com.redhat:ceph-iscsi/tpgt_1/attrib/authentication"
dev="configfs" ino=25703 ioctlcmd=0x5401
scontext=system_u:system_r:ceph_t:s0
tcontext=system_u:object_r:configfs_t:s0 tclass=file permissive=1

type=SYSCALL msg=audit(1578526787.577:68): arch=x86_64 syscall=ioctl
success=no exit=ENOTTY a0=34 a1=5401 a2=7ffd4f8f1f60 a3=3052cd2d95839b96
items=0 ppid=1 pid=995 auid=4294967295 uid=0 gid=0 euid=0 suid=0 fsuid=0
egid=0 sgid=0 fsgid=0 tty=(none) ses=4294967295 comm=rbd-target-api
exe=/usr/libexec/platform-python3.6 subj=system_u:system_r:ceph_t:s0
key=(null)

Hash: rbd-target-api,ceph_t,configfs_t,file,ioctl

Signed-off-by: Mike Christie <mchristi@redhat.com>
2020-04-22 11:52:00 -05:00
Casey Bodley
9a3aecbaf3
Merge pull request #34669 from yuvalif/remove_queue_dependency
cls/2pc_queue: remove the dependency of cls_2pc_queue with cls_queue

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2020-04-22 10:35:48 -04:00
Casey Bodley
b80dee0123
Merge pull request #34664 from yuvalif/clarify_topic_creation_format
rgw/doc: clarify topic creation format

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2020-04-22 10:35:28 -04:00
Sebastian Wagner
370bddb301 mgr/cephadm: use check_call for ssh-keygen
Mainly to provide any reasonable error

Fixes: https://tracker.ceph.com/issues/44832
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-04-22 16:10:27 +02:00
Casey Bodley
3466890e50
Merge pull request #34613 from cbodley/wip-44661
rgw: use DEFER_DROP_PRIVILEGES flag unconditionally

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
2020-04-22 10:06:06 -04:00
Sebastian Wagner
bf9cd06c6b qa/workunits/cephadm/test_cephadm: Also test octopus
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-04-22 15:31:19 +02:00
Sebastian Wagner
31958dfcb5
Merge pull request #34621 from mgfritch/cephadm-test-cleanup
qa/workunits/cephadm/test_cephadm.sh: add CLEANUP var
2020-04-22 14:38:16 +02:00
Sebastian Wagner
2ee8034c20
Merge pull request #34568 from sebastian-philipp/orch-upgrade-usage
mgr/orch: upgrade: better input validation

Reviewed-by: Joshua Schmid <jschmid@suse.de>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2020-04-22 14:37:55 +02:00
Sebastian Wagner
2e23a5422b
Merge pull request #34565 from SUSE/wip-fix-45095
cephadm: handle adopting offline OSDs

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-04-22 14:37:04 +02:00
Lenz Grimmer
65239481f1
Merge pull request #34442 from tspmelo/wip-fix-rgw-bucket-checkbox
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-04-22 13:31:49 +02:00
Sebastian Wagner
950943d67d doc/cephadm: install.rst: fix placement spec.
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-04-22 12:38:13 +02:00
Sebastian Wagner
2107649ffa cephadm: Aquire lock, if fsid != None
Fixes:

```
Traceback (most recent call last):
  File "./cephadm", line 4494, in <module>
    r = args.func()
  File "./cephadm", line 1077, in _infer_fsid
    return func()
  File "./cephadm", line 1103, in _infer_image
    return func()
  File "./cephadm", line 2813, in command_ceph_volume
    l = FileLock(args.fsid)
  File "./cephadm", line 560, in __init__
    self._lock_file = os.path.join(LOCK_DIR, name + '.lock')
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'
```

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-04-22 11:51:49 +02:00
Yan, Zheng
cd94861e96
Merge pull request #33479 from simon-rock/simon_split_stray
mds : enable fragmentation of stray dir when conditions are met
2020-04-22 14:55:57 +08:00
Gregory Farnum
da3904609f
Merge pull request #34561 from kotreshhr/ceph-fs-status-output
mgr/status: Fix "ceph fs status" json format writing to stderr

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
2020-04-21 22:17:42 -07:00
Gregory Farnum
f278e10038
Merge pull request #34546 from varshar16/wip-flake8-cephfs-shell
cephfs-shell: Fix multiple flake8 errors

Reviewed-by: Rishabh Dave <ridave@redhat.com>
2020-04-21 22:16:43 -07:00
Gregory Farnum
54d4b31f0c
Merge pull request #34534 from ajarr/fix-43061
mon/FSCommands: Fix 'add_data_pool' command and 'fs new' command

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2020-04-21 22:15:23 -07:00
Gregory Farnum
3504799810
Merge pull request #34164 from ukernel/wip-44382
qa/cephfs: update TestClusterFull:test_barrier

Reviewed-by: Jeff Layton <jlayton@redhat.com>
2020-04-21 22:14:10 -07:00
Gregory Farnum
6fae077e9e
Merge pull request #33576 from lxbsz/fuse
unshare-ns-mount: add isolating netns for mount helper support

Reviewed-by: Jeff Layton <jlayton@redhat.com>
2020-04-21 22:12:37 -07:00
Gregory Farnum
fec0e61c21
Merge pull request #34121 from ADI10HERO/flake8_fix1
cephfs-shell: Fix flake8 errors (F841, E302, E502, E128, E305 and E222)

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Varsha Rao <varao@redhat.com>
2020-04-21 22:10:59 -07:00
Gregory Farnum
ce0845c529
Merge pull request #34531 from lxbsz/libfuse3
ceph-fuse: link to libfuse3 and pass `-o big_writes` to libfuse if libfuse < 3.0.0

Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-04-21 22:08:15 -07:00
Gregory Farnum
4b80709884
Merge pull request #34274 from ukernel/wip-44801
client: reset requested_max_size if file write is not wanted

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2020-04-21 22:07:06 -07:00
Yuval Lifshitz
ad56f9e826 cls/2pc_queue: remove the dependency of cls_2pc_queue with cls_queue
both queues share the same code base, however, cls_2pc_queue should work
even if cls_queue objectclass is not loaded into the osd

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2020-04-21 19:15:42 +03:00
Alfonso Martínez
ee2b2d1978 mgr/dashboard: fix tasks.mgr.dashboard.test_rgw.RgwBucketTest.test_all
Increased the time for getting 2nd TOTP.

Fixes: https://tracker.ceph.com/issues/44405
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
2020-04-21 15:27:06 +02:00