Commit Graph

115119 Commits

Author SHA1 Message Date
Jos Collin
af0c0cd6b7
mon: test before adding/removing required_client_features
Fixes: https://tracker.ceph.com/issues/47006
Signed-off-by: Jos Collin <jcollin@redhat.com>
2020-09-24 06:43:49 +05:30
Lenz Grimmer
4432903f00
Merge pull request #37044 from votdev/update_on_demand
mgr/dashboard: Update datatable only when necessary

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2020-09-14 11:50:19 +02:00
Lenz Grimmer
856d9de394
Merge pull request #36845 from bk201/wip-44803
mgr/dashboard: allow getting fresh inventory data from the orchestrator

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-09-14 11:48:22 +02:00
Lenz Grimmer
42a32baaaa
Merge pull request #36365 from bk201/wip-44637
mgr/dashboard: add e2e tests for Orchestrator components

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2020-09-14 10:56:41 +02:00
Kefu Chai
a2cc67f563
Merge pull request #37127 from tchaikov/wip-crimson-errorator
crimson/common: add specialization for futurize::invoke(Func, monostate)

Reviewed-by: Samuel Just <sjust@redhat.com>
2020-09-14 13:19:47 +08:00
Kefu Chai
ac58f85e13 crimson/common: add comment to explain the partial specialization
it might be confusing why we don't use explicit specialization for
defining errorator::futurize::stored_to_future.

quote from item 16, § 17.7.3, n4659:

In an explicit specialization declaration for a member of a class
template or a member template that appears in namespace scope, the
member template and some of its enclosing class templates may remain
unspecialized, except that the declaration shall not explicitly
specialize a class member template if its enclosing class templates are
not explicitly specialized as well.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-14 10:14:05 +08:00
Kefu Chai
1dbafcb43d
Merge pull request #37098 from tchaikov/wip-47179
common/admin_socket: always validate the parameters

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-09-14 09:44:35 +08:00
Kefu Chai
47e88cd7c3 crimson/common: add specialization for futurize::invoke(Func, monostate)
this is a leftover of 260a702ba9. where we
bumped up the Seastar API level to 5, in which seastar::internal::monostate
is used to represent the stored state of a future instead of a tuple<>.

to address FTBFS with GCC-9.2.1

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-14 09:03:44 +08:00
Patrick Donnelly
aa7f399148
Merge PR #36987 into master
* refs/pull/36987/head:
	mgr: PyModuleRegistry::unregister_client() can run endlessly

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-13 13:24:13 -07:00
Kefu Chai
3cb1e73075
Merge pull request #37069 from tchaikov/wip-seastar-lv5
crimson/common: use seastar API level 5

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-09-14 00:37:38 +08:00
Kefu Chai
06da7b182e seastar: pickup alien fixes
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-13 22:54:18 +08:00
Kefu Chai
85b5db0cce
Merge pull request #37097 from tchaikov/wip-buffer-offsetof
common/buffer: use homebrew BUF_OFFSETOF to replace offsetof()

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-09-12 23:13:39 +08:00
Kefu Chai
043603ab6f
Merge pull request #37117 from bstillwell/zstd-upgrade-v1_4_5
zstd: upgrade to v1.4.5

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-12 23:12:36 +08:00
Kefu Chai
ad895eed3a
Merge pull request #37096 from majianpeng/osd-pg-remove-unused-ocde
osd/PG: remove unused function.

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-12 19:31:13 +08:00
Kefu Chai
ae4fd30ffc
Merge pull request #36918 from tchaikov/wip-pybind-type-annotations
pybind/rados: use PEP484 style type annotations

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2020-09-12 06:49:58 +08:00
Kefu Chai
075cc0ffd6
Merge pull request #37105 from tchaikov/wip-47404
mgr/zabbix: indent the output of "zabbix config-show"

Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-09-12 06:27:51 +08:00
Jason Dillaman
c55e2c8706
Merge pull request #37012 from trociny/wip-46803
librbd: track complete async operation requests

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-09-11 18:14:46 -04:00
Bryan Stillwell
7f23cd611f zstd: upgrade to v1.4.5
Since the v1.4.0 release there have been a few improvements to Zstandard
including improved compression ratios, faster compression, and faster
decompression.

Signed-off-by: Bryan Stillwell <bstillwell@godaddy.com>
2020-09-11 15:54:56 -06:00
Josh Durgin
05efc0a3ac
Merge pull request #37114 from yuriw/wip-yuriw-crontab-master
qa/tests: running rados with -p 80 to produce better test results on …

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-09-11 14:42:24 -07:00
Sebastian Wagner
0f90e60faa
Merge pull request #35543 from sebastian-philipp/qa-cephadm-iscsi
qa/cephadm: Add iSCSI

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Georgios Kyratsas <gkyratsas@suse.com>
Reviewed-by: Matthew Oliver <moliver@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2020-09-11 21:10:37 +02:00
Sebastian Wagner
3a59cd7971
Merge pull request #36936 from mgfritch/cephadm-keyring-rm
mgr/cephadm: remove keyring during daemon post-remove

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-09-11 21:09:19 +02:00
Ramana Raja
4b2911fc70
Merge pull request #32581 from rishabh-d-dave/wip-djf-15070
mon, cephfs: Add auth caps for CephFS fsids

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
2020-09-12 00:00:52 +05:30
Yuri Weinstein
c261f662c4 qa/tests: running rados with -p 80 to produce better test results on master
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
2020-09-11 10:49:35 -07:00
Kefu Chai
a728b9dbbd
Merge pull request #37021 from tchaikov/wip-osd-pass-by-ref
osd: pass pg_log_t by lvalue reference

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2020-09-12 01:38:09 +08:00
Casey Bodley
068d46c126
Merge pull request #37011 from tchaikov/wip-rgw-cache-list
rgw: set command desc for "cache list"

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2020-09-11 13:04:00 -04:00
Kefu Chai
2f2914da5d
Merge pull request #37002 from tchaikov/wip-alpine-cleanup
alpine: remove .editorconfig

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2020-09-12 00:43:36 +08:00
Kefu Chai
d9c4be0c0e pybind/rados: do not encode bytes
the annotations ensures the type of input parameter, so no need to
encode a bytes object anymore

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-12 00:30:55 +08:00
Kefu Chai
0b8fdaa4bc ceph.in: read bytes from stdin
the data read from stdin is used as the input parameter for calls like
`cluster.osd_command(...)` and `cluster.mon_command`. all of them
expect a bytes `inbuf`. in Python2, this sys.stdin.read() returns a str,
and we don't differentiate str from byte back then. but we need enforce
the type now for better readablity and type correctness.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-12 00:30:55 +08:00
Kefu Chai
ea7e907b3b test/pybind: pass a str to "ping_monitor()"
monitors' names are not numbers, they are referenced by names in
general. their ranks are numbers though, but that's different story.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-12 00:30:55 +08:00
Kefu Chai
a7b506046e pybind/rados: define unicode alias
for silencing warnings like:

WARNING: Cannot resolve forward reference in type annotations of "rados.Rados.conf_get": name 'unicode' is not defined

because cython < 3.0 with language_level = "3", translates "str" to "unicode"
to be python2 compatible, but we've migrated to python3. and the specified
"language_level" is "3'. see also
https://github.com/cython/cython/issues/1370

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-12 00:30:55 +08:00
Kefu Chai
a56cd5630d pybind/rados: drop redundant type in docstring
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-12 00:30:54 +08:00
Kefu Chai
4e23ca1974 pybind/rados: remove duplicated statement
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-12 00:30:54 +08:00
Kefu Chai
159858b049 pybind: s/unicode/str/
we've migrated to python3, so no "unicode" anymore.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-12 00:30:54 +08:00
Kefu Chai
bbf9f5bbe3 pybind/rados: use PEP484 style type annotations
* use PEP484 style typo annotations
* drop homebrew `requires()` decorator
* drop tests for `requires()` decorator
* add test for type annotations

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-12 00:30:54 +08:00
Kefu Chai
b59dde535a pybind/ceph_argparse.py: pass a str not a list to mon_command()
no need to construct a list as the cmd. and more importantly,

the document of Rados.mon_command() reads:

  Rados.mon_command(self, cmd, inbuf, timeout=0, target=None):
  ...
  :param cmd: JSON formatted string.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-12 00:30:54 +08:00
Kefu Chai
2d10914d5a pybind/rados: construct cmd as an array of a single entry
otherwise what monitor receives would be something like

mon_command({ " p r e f i x " :   " o s d   m a p " ...

difficult to parse/grep by machine/human.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-12 00:30:54 +08:00
Kefu Chai
51a2a72215 pybind/rados: add type annotations to Rados.mon_command()
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-12 00:30:54 +08:00
Casey Bodley
cd6e535110
Merge pull request #37052 from cbodley/wip-rgw-rest-op-err
rgw: RGWRESTOp no longer tracks separate error code

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2020-09-11 11:33:11 -04:00
Michael Fritch
eea25b5ac7
mgr/cephadm: merge update_keyring_caps -> create_keyring
keyring is removed during daemon remove, which obsoletes the need to
update the keyring caps after get-or-create

Signed-off-by: Michael Fritch <mfritch@suse.com>
2020-09-11 08:10:44 -06:00
Michael Fritch
2266cc1e75
mgr/cephadm: disallow removing the mon keyring
Signed-off-by: Michael Fritch <mfritch@suse.com>
2020-09-11 08:10:38 -06:00
Michael Fritch
11bbfd5836
mgr/cephadm: remove keyring during daemon post-remove
Fixes: https://tracker.ceph.com/issues/47298
Signed-off-by: Michael Fritch <mfritch@suse.com>
2020-09-11 08:10:32 -06:00
Michael Fritch
183f7c34a3
mgr/cephadm: pass DaemonDescription during pre/post remove
add more context than simply passing the `daemon_id`

Signed-off-by: Michael Fritch <mfritch@suse.com>
2020-09-11 08:10:26 -06:00
Michael Fritch
a0cefab9e5
mgr/cephadm: add post_remove daemon action
invoked after a daemon has been removed

Signed-off-by: Michael Fritch <mfritch@suse.com>
2020-09-11 08:10:17 -06:00
Mykola Golub
07fbc4b71d librbd: track complete async operation requests
to prevent duplicate maintenance operations due to RPC hiccups.

Fixes: https://tracker.ceph.com/issues/46803
Signed-off-by: Mykola Golub <mgolub@suse.com>
2020-09-11 14:48:53 +01:00
Jason Dillaman
251ccb8d95
Merge pull request #36825 from trociny/wip-47068
librbd: task finisher should distinguish quiesce tasks with different ID

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-09-11 09:25:57 -04:00
Rishabh Dave
995c73639b qa/cephfs: add tests for "fs authorize" subcommand
Make caps FS-specific affects "fs authorize" subcommand. Let's add few
tests to verify its behaviour.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2020-09-11 18:04:23 +05:30
Rishabh Dave
4e0f090861 qa/cephfs: backup mount object before running tests
Right now, only client IDs are stashed and restored but with the recent
changes (addition of more attributes to mount objects, specifically),
this is not enough. Saving and restoring these details before and after
tests respectively ensures that mount commands rus smoothly. Not doing
this typically leads to mount command failure for the second test in the
testsuite under execution since the client IDs are saved and restored in
CephFSTestCase.setUp and CephFSTestCase.tearDown respectively but the
rest of the details are not.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2020-09-11 18:04:23 +05:30
Rishabh Dave
352a41d1b3 qa/cephfs: add tests for multi-FS auth tests
Add testsuite for testing authorization on Ceph cluster with multiple
file systems and enable it to be executable with Teuthology framework.

Also add helper methods required to setup the test environment for
multi-FS tests.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2020-09-11 18:02:48 +05:30
Kefu Chai
ddceba1647 mgr/zabbix: indent the output of "zabbix config-show"
Fixes: https://tracker.ceph.com/issues/47404
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-11 20:29:59 +08:00
Sebastian Wagner
1bd86d3316 mgr/cephadm: allow iscsi to be named by teuthology
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-09-11 14:18:54 +02:00