Commit Graph

133407 Commits

Author SHA1 Message Date
John Mulligan
a41678a4c7 pybind/mgr: add additional decorators for mgr response handling
Add a ErrorResponseHandler decorator for catching and automatically
handling ErrorResponseBase exceptions like Responder does but it *only*
handles exceptions. Normal return value tuples are passed on to the mgr.

Add a EmptyResponder decorator that catches errors but returns "empty"
strings as a response to the mgr. This matches a number of preexisting
functions that don't return json or any other value on success.

Both these decorators are added in order to match behaviors of Responder
decorator without opting into auto formatted responses wholesale. They
are intended to be used when converting older apis to use object_format
module.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2022-08-23 13:01:45 -04:00
Venky Shankar
d1ca282f60
Merge pull request #45949 from neesingh-rh/feature-51434
mgr/volumes: Add volume info command

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
2022-08-23 21:33:09 +05:30
Venky Shankar
b3b6a829e5
Merge pull request #44501 from SMIL-Infra/fix-mds-evicted
mon/MDSMonitor: fix standby-replay mds being removed from MDSMap unexpectedly

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2022-08-23 21:30:18 +05:30
Daniel Gryniewicz
39fae6bdd2
Merge pull request #47678 from dang/wip-dang-admin-user
RGW - Admin - Pass user to created bucket

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-08-23 11:40:50 -04:00
Laura Flores
4cf097d7e0
Merge pull request #47642 from ljflores/wip-librados-fix
qa/workunits/rados: pull librados files from "main" instead of "master"
2022-08-23 10:32:31 -05:00
Kefu Chai
9734b7f32b
Merge pull request #47624 from Mer1997/wip-57138
mgr/snap-schedule: use the right way to check the result returned by…

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-08-23 23:29:06 +08:00
Kefu Chai
7f47ade98a
Merge pull request #47301 from rzarzynski/wip-bug-55851
msg: reset ProtocolV2's frame assembler in appropriate thread

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-08-23 23:27:54 +08:00
Kefu Chai
ccff328190
Merge pull request #46943 from kalaspuffar/python39
mgr/diskprediction_local: Support Python 3.9 for disk prediction module.

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-08-23 23:26:07 +08:00
Kefu Chai
a1d8b793e1
Merge pull request #47672 from Matan-B/wip-matanb-buffer-next
include/buffer: clear_and_dispose() fix implicitly-declared operator= usage

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-08-23 23:24:15 +08:00
Kefu Chai
a9ac5438a7
Merge pull request #47710 from tchaikov/denc-concept
include/denc: define is_const_iterator as a concept

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-08-23 23:21:35 +08:00
Kefu Chai
9dda4b4188
Merge pull request #47718 from tchaikov/wip-no-isp2
*: replace functions in intarith.h with the ones provided by standard library

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2022-08-23 23:19:41 +08:00
Matan
2f23b96182
Merge pull request #46419 from Matan-B/wip-matanb-c-snaps
crimson/osd: Snaps IO path

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-08-23 17:45:18 +03:00
Venky Shankar
5ef57ea4a0
Merge pull request #47182 from lxbsz/wip-56638
libcephfs: define AT_NO_ATTR_SYNC back for backward compatibility

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
2022-08-23 19:39:40 +05:30
Ilya Dryomov
3eda6f9682
Merge pull request #47737 from ceph/release-docs2
admin: Fix check if PR or release branch docs build

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-08-23 14:24:36 +02:00
Venky Shankar
a9a7d50d20
Merge pull request #47542 from batrick/i56140
tools/cephfs: add basic detection/cleanup tool for dentry first damage

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2022-08-23 16:22:29 +05:30
Nizamudeen A
0e0e5803a4
Merge pull request #43771 from rhcs-dashboard/wip-52701-master
mgr/dashboard: add backend-driven UI tables

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: sherrif10 <NOT@FOUND>
Reviewed-by: Zac Dover <zac.dover@gmail.com>
2022-08-23 15:33:30 +05:30
Venky Shankar
78871e59c0
Merge pull request #46599 from kotreshhr/rename_config_on_flush
mgr/volumes: Better handle config file on osd full scenario

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
2022-08-23 13:25:02 +05:30
Venky Shankar
5e1625fa7c
Merge pull request #47063 from lxbsz/wip-56529
mds/client: fail the request if the peer MDS doesn't support getvxattr op

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
2022-08-23 13:22:09 +05:30
Venky Shankar
528670c86c
Merge pull request #47132 from lxbsz/_rmsnap_finish_clean
mds: remove useless code in _rmsnap_finish()

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2022-08-23 12:49:57 +05:30
Venky Shankar
e496f48cb0
Merge pull request #47384 from lxbsz/wip-56633
mds: add more debug logs before crashing the MDS

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
2022-08-23 12:43:36 +05:30
Casey Bodley
95f6cbfe17
Merge pull request #47613 from cbodley/wip-56920
rgw/coroutine: check for null stack on wakeup

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2022-08-22 21:02:30 -04:00
Patrick Donnelly
4d9be7e13b
Merge PR #47732 into main
* refs/pull/47732/head:
	Revert "Merge pull request #47092 from dparmar18/wip-dparmar-cephadm-simple-1"

Reviewed-by: Adam King <adking@redhat.com>
2022-08-22 20:04:54 -04:00
Casey Bodley
a8250553c6 rgw/coroutine: check for null stack on wakeup
Fixes: https://tracker.ceph.com/issues/56920

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2022-08-22 19:28:19 -04:00
Anthony D'Atri
5ce745801b
Merge pull request #47690 from mty22/update-inactive-ceph-mirrors
doc: Remove inactive Ceph mirrors.
2022-08-22 14:16:24 -07:00
David Galloway
f92133ca52 admin: Fix check if PR or release branch docs build
Uses built-in RTD vars.  https://docs.readthedocs.io/en/stable/environment-variables.html.

Follow up to https://github.com/ceph/ceph/pull/46917#discussion_r942359130.

Signed-off-by: David Galloway <dgallowa@redhat.com>
2022-08-22 16:40:09 -04:00
Anthony D'Atri
e87b47d855
Merge pull request #45552 from wxypro/man-cephfs-mirror
doc/man/cephfs-mirror.rst: Update missing options for cephfs-mirror
2022-08-22 11:43:16 -07:00
Anthony D'Atri
103b3f59ca
Merge pull request #47727 from snosratiershad/docs/correct-radosgw-admin-doc-bucket-name
doc/man/8: Remove slash behind bucket name in radosgw-admin.rst
2022-08-22 11:26:49 -07:00
Patrick Donnelly
a8a86789c7
Revert "Merge pull request #47092 from dparmar18/wip-dparmar-cephadm-simple-1"
This reverts commit 1c4da3dbd2, reversing
changes made to ee1e163b1e.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2022-08-22 13:10:27 -04:00
Salar Nosrati-Ershad
7840573a92 doc/man/8: Remove slash behind bucket name in radosgw-admin.rst
Signed-off-by: Salar Nosrati-Ershad <snosratiershad@gmail.com>
2022-08-22 20:22:12 +04:30
Pere Diaz Bou
52b2224c3e
Merge pull request #47371 from rhcs-dashboard/mstart-configurable
mstart: make some mstart env variables configurable 

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-08-22 17:42:49 +02:00
Nizamudeen A
198fc58b38
Merge pull request #47207 from oOHenry/rgw-dashboard-ssl-error
mgr/dashboard: fix rgw connect when using ssl

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: David Galloway <dgallowa@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-08-22 20:41:02 +05:30
Kefu Chai
4bb9b6c424
Merge pull request #47720 from tchaikov/wip-mgr-dashboard-test-with-headers
qa/tasks/mgr/dashboard: accept headers as a param

Reviewed-by: Nizamudeen A <nia@redhat.com>
2022-08-22 22:34:57 +08:00
Ilya Dryomov
37fd6a27e8
Merge pull request #47716 from MalteJ/patch-1
doc: virtio discard is supported since kernel 5.0

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-08-22 12:23:54 +02:00
Kefu Chai
b8dd567c54 include/intarith: drop popcount()
as it is not used anymore.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-22 18:03:59 +08:00
Kefu Chai
844260f3a2 common, test: use std::popcount() when appropriate
prefer the facilities provided by standard library over the homebrew
ones for better readability and maintainability.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-22 18:03:59 +08:00
Kefu Chai
f4706f95e6 include/intarith: drop clz()
it is not used anymore

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-22 18:03:59 +08:00
Kefu Chai
e132be7ee5 os/bluestore: use std::countl_zero() when appropriate
prefer the facilities provided by standard library over the homebrew
ones for better readability and maintainability.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-22 18:03:59 +08:00
Kefu Chai
dc92dfc9c3 include/intarith: rewrite cbits() in C++20
rewrite cbits() using concept and std::countl_zero(), for better
readability and maintanability.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-22 18:03:59 +08:00
Kefu Chai
275ec55c95 include/intarith: drop isp2()
as it is not used anymore.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-22 18:03:59 +08:00
Kefu Chai
05e355b592 *: s/isp2/has_single_bit/
prefer the facilities provided by standard library over the homebrew
ones for better readability and maintainability.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-22 18:03:59 +08:00
Malte Janduda
ad86ffb35d doc: virtio discard is supported since kernel 5.0
Signed-off-by: Malte Janduda <mail@janduda.net>
2022-08-22 11:35:38 +02:00
Pere Diaz Bou
cbe98b345a
Merge pull request #46702 from rhcs-dashboard/expand-cluster-hide-maintenance
mgr/dashboard: Hide maintenance option on expand cluster

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
2022-08-22 09:58:37 +02:00
Xiubo Li
bb0d56a93a libcephfs: define AT_NO_ATTR_SYNC back for backward compatibility
This was introduce by commit e2a67f2a65,
for the third part applications they may still use the old macro.

Add it back and marked it as deprecated.

Fixes: https://tracker.ceph.com/issues/56638
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2022-08-22 14:09:31 +08:00
Kefu Chai
afe8058b6c qa/tasks/mgr/dashboard: accept headers as an option param
* add optional "headers" parameter to _request() and _get()
* correct the test of test_force_no_gzip, as the header in response
  should be "application/vnd.ceph.api.v1.0+json", not "application/json"

with this change, we are able to pass headers to _get() in dashboard api
tests.

without this change, we'd have following error when testing
`test_force_no_gzip` defined by `tasks.mgr.dashboard.test_requests.RequestsTest`:

raceback (most recent call last):
  File "/home/jenkins-build/build/workspace/ceph-api/src/pybind/mgr/dashboard/services/exception.py", line 47, in dashboard_exception_handler
    return handler(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/cherrypy/_cpdispatch.py", line 54, in __call__
    return self.callable(*self.args, **self.kwargs)
  File "/home/jenkins-build/build/workspace/ceph-api/src/pybind/mgr/dashboard/controllers/_base_controller.py", line 263, in inner
    ret = func(*args, **kwargs)
TypeError: Summary.__call__() got an unexpected keyword argument 'headers'

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-22 14:01:16 +08:00
Nizamudeen A
3dc45e450e mgr/dashboard: add out_client dir to api and e2e checks
Signed-off-by: Nizamudeen A <nia@redhat.com>
2022-08-22 11:04:18 +05:30
Nizamudeen A
6ef65a00e1 vstart: isolate the client logs
Signed-off-by: Nizamudeen A <nia@redhat.com>
2022-08-22 11:04:18 +05:30
Nizamudeen A
35c8c89258 mstart: make some mstart env variables configurable
Signed-off-by: Nizamudeen A <nia@redhat.com>
2022-08-22 11:04:18 +05:30
Kefu Chai
5fd0f9cd48
Merge pull request #47711 from tchaikov/wip-crimson-os-cleanups
crimson/os: cleanups

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-22 13:29:19 +08:00
Anthony D'Atri
1c9e84a447
Merge pull request #47715 from maryfrances01/wip-doc-punctuation-error
doc/radosgw: Fix punctuation and grammar in encryption.rst
2022-08-21 09:59:28 -07:00
Mary Frances
77770920f7 doc: Fixes a punctuation and grammar issue 2022-08-21 06:29:41 -07:00