the version command is handled by HelpHook, which does not print newline
at the end of the returned JSON. so the output of "status" subcommand
looks like:
=== osd.1 ===
osd.1: running {"version":"Development"}=== osd.2 ===
osd.2: not running.
with this change, a newline is added to the end of version.
also use the "daemon" subcommand to talk to the asok, let the "ceph" cli
to figure out the asok path.
Signed-off-by: Kefu Chai <kchai@redhat.com>
tests: osd-scrub-repair.sh disable scrub backoff in test
Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed-by: Loic Dachary <ldachary@redhat.com>
there is good chance that the newly scheduled scrub fail to pass the
flip-coin check: the probability of scheduling a new scrub 1/3 every
time we flip the coin. so, instead hardwiring the probability to 1/3,
a new option named "osd_scrub_backoff_ratio" is introduced. so we can
override it when performing test.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Update all calls to Messenger::create()
take 'ms_public_type' or 'ms_cluster_type' instead of 'ms_type'
issue: 971661
Change-Id: Ib234daf393d1838ef596dde35a6d83c1aeecaf10
Signed-off-by: Sarit Zubakov <saritz@mellanox.com>
We use m_work_queue of type ContextWQ in handle_update function but we
do not include common/WorkQueue.h that defines ContextWQ. This results
in dereference of an incomplete type and causes build error in latest
Fedora rawhide (future 26).
Fixes: http://tracker.ceph.com/issues/18862
Signed-off-by: Boris Ranto <branto@redhat.com>
Some variables have been already free'd by calling
release(), no need to call delete() again on them.
CID 1396200 (#1 of 1): Double free (USE_AFTER_FREE)
double_free: Calling operator delete frees pointer
getxattr_completion which has already been freed.
CID 1396206 (#1 of 1): Double free (USE_AFTER_FREE)
double_free: Calling operator delete frees pointer
getxattr_completion which has already been freed.
CID 1396214 (#1 of 1): Double free (USE_AFTER_FREE)
double_free: Calling operator delete frees pointer
stat_completion which has already been freed.
CID 1396218 (#1 of 1): Double free (USE_AFTER_FREE)
double_free: Calling operator delete frees pointer
stat_completion which has already been freed.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix for:
CID 1395468 (#1 of 1): Self assignment (NO_EFFECT)
self_assign: Assigning bh->last_write to itself has no effect.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
CID 1395784 (#2-1 of 2): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable state going out of scope
leaks the storage it points to.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
ID 1398895 (#1 of 1): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable config going out of scope leaks
the storage it points to.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix for:
CID 1398896: Resource leak (RESOURCE_LEAK)
overwrite_var: Overwriting fe in fe = new
RGWLoadGenFrontend(env, config) leaks the storage that fe
points to.
Do not check again and again for framework if there is
already a match, make use of if/else. This should also
fix the RESOURCE_LEAK warning.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
and update the CMakeLists.txt accordingly, as upstream changed the
target name to build the static library.
5647d5e reverted the previous change by accident.
Fixes: http://tracker.ceph.com/issues/18464
Signed-off-by: Kefu Chai <kchai@redhat.com>
